All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sá" <Nuno.Sa@analog.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>
Subject: Re: [RFC PATCH 4/4] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads
Date: Wed, 28 Apr 2021 14:24:58 +0300	[thread overview]
Message-ID: <CAHp75Ve5Dyz-Cc7p8G4JzZ1Jhbey330WEHu2u7DLrRsoRbvgjg@mail.gmail.com> (raw)
In-Reply-To: <20210428082203.3587022-4-sean@geanix.com>

On Wed, Apr 28, 2021 at 11:22 AM Sean Nyekjaer <sean@geanix.com> wrote:
>
> When flushing the hw fifo there is a bug in the I2C that prevents burst
> reads of more than one sample pair.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> This series depends on "iio: accel: add support for
> FXLS8962AF/FXLS8964AF accelerometers"

This should be part of that series.

Besides, see below.

...

> +       bool i2c_device;


> +       data->i2c_device = i2c_device;

This is redundant. Use i2c_verify_client() instead.


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-04-28 11:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:22 [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Sean Nyekjaer
2021-04-28  8:22 ` [RFC PATCH 2/4] iio: accel: fxls8962af: add interrupt support Sean Nyekjaer
2021-04-28 14:26   ` Jonathan Cameron
2021-04-29  8:58   ` Lars-Peter Clausen
2021-04-29  9:35     ` Andy Shevchenko
2021-04-29  9:37       ` Lars-Peter Clausen
2021-04-29 11:35         ` Andy Shevchenko
2021-04-29 19:19           ` Lars-Peter Clausen
2021-04-30  8:54             ` Andy Shevchenko
2021-04-28  8:22 ` [RFC PATCH 3/4] iio: accel: fxls8962af: add hw buffered sampling Sean Nyekjaer
2021-04-28 11:05   ` Sean Nyekjaer
2021-04-28 13:53     ` Jonathan Cameron
2021-04-28 16:32   ` Jonathan Cameron
2021-04-29  7:40     ` Sean Nyekjaer
2021-04-29 14:52       ` Jonathan Cameron
2021-04-28  8:22 ` [RFC PATCH 4/4] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads Sean Nyekjaer
2021-04-28 11:24   ` Andy Shevchenko [this message]
2021-04-28 11:37     ` Sean Nyekjaer
2021-04-28 13:56 ` [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Jonathan Cameron
2021-05-03 19:21 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Ve5Dyz-Cc7p8G4JzZ1Jhbey330WEHu2u7DLrRsoRbvgjg@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=Nuno.Sa@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sean@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.