From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28324C433DB for ; Mon, 8 Feb 2021 16:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C75DA64E8B for ; Mon, 8 Feb 2021 16:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbhBHQRe (ORCPT ); Mon, 8 Feb 2021 11:17:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbhBHQRV (ORCPT ); Mon, 8 Feb 2021 11:17:21 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0CCDC061786; Mon, 8 Feb 2021 08:16:41 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id m6so10033487pfk.1; Mon, 08 Feb 2021 08:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WsJCNxoOgawUj7Zr3PeZyr3znV20VI9UZXxnXDXzdvs=; b=U0OD2796M2UhURPNe4IChEOVyT/iAmYNvaDyk30Rqz9ncMVbwvASefx+TLV/Lqbunw 1KmGPVpqLXajRiDDHRTcb83gUCO+FNJpH2utz+SZQ99OCaeaSKzVV+k5/Pz/k2IfLhf5 H19aU9TDyuwDC6TbDu4CnhjufcmNEeSzAC9H24HORJMfbQBGIboVlee0FLAjMLd9Aukp vGmMl69XEdRIU5pv8JrxtaOM2nhzLrrDuUtCYtT7P17JcGYG1IDvySaQEvDIsGRujrbg wJdw0tPeC89VzCLkD1RB+YMSlwEdeSrmlLJM2jTad4KdtZunXpyl4+il47IFIV3EBLBV 0qMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsJCNxoOgawUj7Zr3PeZyr3znV20VI9UZXxnXDXzdvs=; b=FLY1JLwbHOWtAsWWT07QQR3mtZMmMCIMaqU0kLB6lTNW57LPni+lAHpxaNTB2/igUB lhc793WjaBtYT2XQTRVSYWYAMSrivcSWMzfH37nmLSNg2jaWoTuW/fsB1yb4fhYhAw6n gdn5afiXbRCOMc8ArY8nNM4vhSQiKkt+HMcCfLq6OfwoYuNtQ0nxo7n2jnYmf7EN48Wq AX1uoGdGkMIocIPOUi5pbvQloZdyheaxHj478pOvrcHh19YqjUgn9JGb8CdGB7PoM3ny k65LQZFfKkq1b+kdK5ZcbzwH9cBfsM++1eufmpoKWYIN70MepqG5eUUy0avnitIogbrh M+0A== X-Gm-Message-State: AOAM530yt7gEj+wuvcnFiGwQ4zmai5sYN3QL0/1rzEahhO+LhJMckrc3 EduzwSecdFpBf02uEcOFthkzp65KAE5K7Q/2Eto= X-Google-Smtp-Source: ABdhPJw19SlZGykBCKiYzgNJdxkHEeiF9SWOqGXarLbhcReCBD7gKOEt8vefovgT+spNPLLK3TJjhbkGCYx15o14r9Y= X-Received: by 2002:a62:445:0:b029:19c:162b:bbef with SMTP id 66-20020a6204450000b029019c162bbbefmr19016500pfe.40.1612801001178; Mon, 08 Feb 2021 08:16:41 -0800 (PST) MIME-Version: 1.0 References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-11-calvin.johnson@oss.nxp.com> In-Reply-To: <20210208151244.16338-11-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Mon, 8 Feb 2021 18:16:24 +0200 Message-ID: Subject: Re: [net-next PATCH v5 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Laurentiu Tudor , Linux Kernel Mailing List , "linux.cj" , Diana Madalina Craciun , netdev , linux-arm Mailing List , ACPI Devel Maling List , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 8, 2021 at 5:14 PM Calvin Johnson wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. ... > +/** > + * acpi_mdiobus_register - Register mii_bus and create PHYs from the ACPI ASL. > + * Redundant blank line. > + * @mdio: pointer to mii_bus structure > + * @fwnode: pointer to fwnode of MDIO bus. > + * > + * This function registers the mii_bus structure and registers a phy_device > + * for each child node of @fwnode. > + */ > +int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode) > +{ > + struct fwnode_handle *child; > + u32 addr; > + int ret; > + > + /* Mask out all PHYs from auto probing. */ > + mdio->phy_mask = ~0; I would rather see GENMASK(31, 0) here because in case the type of the variable is changed we will need to amend this anyway. > + ret = mdiobus_register(mdio); > + if (ret) > + return ret; > + mdio->dev.fwnode = fwnode; Shouldn't it be rather ACPI_SET_COMPANION() as other bus / drivers do? > +/* Loop over the child nodes and register a phy_device for each PHY */ Indentation. > + fwnode_for_each_child_node(fwnode, child) { > + ret = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), &addr); > + if ((ret) || addr >= PHY_MAX_ADDR) Too many parentheses. > + continue; > + > + ret = fwnode_mdiobus_register_phy(mdio, child, addr); > + if (ret == -ENODEV) > + dev_err(&mdio->dev, > + "MDIO device at address %d is missing.\n", > + addr); > + } > + return 0; > +} ... > +/* > + * ACPI helpers for the MDIO (Ethernet PHY) API > + * > + */ It's one line AFAICT! ... > +#include > +#include This seems a bit inconsistent with the below. I see the user of mdiobus_register(). It's the only header should be included. Everything else would be forward declared like struct fwnode_handle; > +#if IS_ENABLED(CONFIG_ACPI_MDIO) > +int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode); > +#else /* CONFIG_ACPI_MDIO */ > +static inline int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode) > +{ > + /* > + * Fall back to mdiobus_register() function to register a bus. > + * This way, we don't have to keep compat bits around in drivers. > + */ > + > + return mdiobus_register(mdio); > +} > +#endif -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B72DC433DB for ; Mon, 8 Feb 2021 16:18:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E63064E87 for ; Mon, 8 Feb 2021 16:18:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E63064E87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IbK8KdUFPlqcZc3fX8wgCKJClEw4e1tBeePczcEFKgM=; b=VohhaTAeuaWVHpEk3DpwHndiC +dK8rZcKbW4R33aRsNeILosJ37MO6mHucuqq5JBCBsM+agjBQhO/FkgdXn6Xg993Gt+RXenYAsn7e id4fEWv4/EpQftAErWX2NQ2KTQAFScdSrfl5R8bzO6EDfdZGJaQaUJxi6A0ZjKFdSEQL2sHtjO65K gXF3P4FxIYwT5lAGyt0CPINOZq7eSDaq7lJ8f4g+y2H/2+bNf6WIqNYt0WPoSF7bJZY7CaqPSKPKa RI2Iq//OlNftNsm8nV9wQaJccPscuFCr4gaZSIds1CMqrHiMiKx6kszUOBQKlpDU3SgA6ap8uDWEL g7hmeXb2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l99DR-0006l6-Ev; Mon, 08 Feb 2021 16:16:45 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l99DP-0006kJ-6g for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 16:16:44 +0000 Received: by mail-pg1-x52d.google.com with SMTP id c132so10526697pga.3 for ; Mon, 08 Feb 2021 08:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WsJCNxoOgawUj7Zr3PeZyr3znV20VI9UZXxnXDXzdvs=; b=U0OD2796M2UhURPNe4IChEOVyT/iAmYNvaDyk30Rqz9ncMVbwvASefx+TLV/Lqbunw 1KmGPVpqLXajRiDDHRTcb83gUCO+FNJpH2utz+SZQ99OCaeaSKzVV+k5/Pz/k2IfLhf5 H19aU9TDyuwDC6TbDu4CnhjufcmNEeSzAC9H24HORJMfbQBGIboVlee0FLAjMLd9Aukp vGmMl69XEdRIU5pv8JrxtaOM2nhzLrrDuUtCYtT7P17JcGYG1IDvySaQEvDIsGRujrbg wJdw0tPeC89VzCLkD1RB+YMSlwEdeSrmlLJM2jTad4KdtZunXpyl4+il47IFIV3EBLBV 0qMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsJCNxoOgawUj7Zr3PeZyr3znV20VI9UZXxnXDXzdvs=; b=h/+8zPEdVkNPS5q9/ZzUFtgf1bvX/NA1qghAXuPnbcpDb5vnBB/VHK+M5kS3QyxT5a XJ3lQN+wDI5wXcLFCtt3A5bvXhQQa28c9oHgio1qJnmxebuVQffmT57lMkQT5b+52OWJ SuuamGcQ/dmfz8+DqOQnN7sUUWKNvzyaJ1vtArkNFyn5J5kwVMZxeKOqXCNe5Wpa8wg8 mbyKAsMZbrfYiCbHtZTOEIymDDbyFudeCHDEBePXRcLG2W8UtTdhkT++EOWzCNs2qfz9 X3DvwU8jtcc9kGb3d9ZeAyCNEIyhP/pNf7UmNTXbu/2albfk0wTikVqEBDI8U9/BvDR1 006g== X-Gm-Message-State: AOAM5325G2OPiE8XQSNJdX3fEvUAFsL/ayQMcfA6YSO5yQw/ErI83iXV taNTYtfL3Boh447vstz/ZHTeR/BWtnfoHQ+XrWQ= X-Google-Smtp-Source: ABdhPJw19SlZGykBCKiYzgNJdxkHEeiF9SWOqGXarLbhcReCBD7gKOEt8vefovgT+spNPLLK3TJjhbkGCYx15o14r9Y= X-Received: by 2002:a62:445:0:b029:19c:162b:bbef with SMTP id 66-20020a6204450000b029019c162bbbefmr19016500pfe.40.1612801001178; Mon, 08 Feb 2021 08:16:41 -0800 (PST) MIME-Version: 1.0 References: <20210208151244.16338-1-calvin.johnson@oss.nxp.com> <20210208151244.16338-11-calvin.johnson@oss.nxp.com> In-Reply-To: <20210208151244.16338-11-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Mon, 8 Feb 2021 18:16:24 +0200 Message-ID: Subject: Re: [net-next PATCH v5 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_111643_309938_0E3CFE1E X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J . Wysocki" , Grant Likely , Ioana Ciornei , Florian Fainelli , Saravana Kannan , Jon , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Jakub Kicinski , Florin Laurentiu Chiculita , Madalin Bucur , Pieter Jansen Van Vuuren , Marcin Wojtas , linux-arm Mailing List , Laurentiu Tudor , netdev , Randy Dunlap , Linux Kernel Mailing List , Jeremy Linton , Cristi Sovaiala , "linux.cj" , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 8, 2021 at 5:14 PM Calvin Johnson wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. ... > +/** > + * acpi_mdiobus_register - Register mii_bus and create PHYs from the ACPI ASL. > + * Redundant blank line. > + * @mdio: pointer to mii_bus structure > + * @fwnode: pointer to fwnode of MDIO bus. > + * > + * This function registers the mii_bus structure and registers a phy_device > + * for each child node of @fwnode. > + */ > +int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode) > +{ > + struct fwnode_handle *child; > + u32 addr; > + int ret; > + > + /* Mask out all PHYs from auto probing. */ > + mdio->phy_mask = ~0; I would rather see GENMASK(31, 0) here because in case the type of the variable is changed we will need to amend this anyway. > + ret = mdiobus_register(mdio); > + if (ret) > + return ret; > + mdio->dev.fwnode = fwnode; Shouldn't it be rather ACPI_SET_COMPANION() as other bus / drivers do? > +/* Loop over the child nodes and register a phy_device for each PHY */ Indentation. > + fwnode_for_each_child_node(fwnode, child) { > + ret = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), &addr); > + if ((ret) || addr >= PHY_MAX_ADDR) Too many parentheses. > + continue; > + > + ret = fwnode_mdiobus_register_phy(mdio, child, addr); > + if (ret == -ENODEV) > + dev_err(&mdio->dev, > + "MDIO device at address %d is missing.\n", > + addr); > + } > + return 0; > +} ... > +/* > + * ACPI helpers for the MDIO (Ethernet PHY) API > + * > + */ It's one line AFAICT! ... > +#include > +#include This seems a bit inconsistent with the below. I see the user of mdiobus_register(). It's the only header should be included. Everything else would be forward declared like struct fwnode_handle; > +#if IS_ENABLED(CONFIG_ACPI_MDIO) > +int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode); > +#else /* CONFIG_ACPI_MDIO */ > +static inline int acpi_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode) > +{ > + /* > + * Fall back to mdiobus_register() function to register a bus. > + * This way, we don't have to keep compat bits around in drivers. > + */ > + > + return mdiobus_register(mdio); > +} > +#endif -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel