All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Dawson <spdawson@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] vlc: new package
Date: Tue, 7 Jan 2014 11:20:48 +0000	[thread overview]
Message-ID: <CAHt8ZCPBrzeWazPKTOy+JT7Bfu38VWYN29LFz-pUo5zuEmZx4Q@mail.gmail.com> (raw)
In-Reply-To: <20140107142617.64f53ddc@skate>

Hi Thomas. Thanks for the feedback.

On 7 January 2014 06:26, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Maybe we should use positive logic everywhere, no? I.e invert all the
> conditions to be:
>
> ifeq ($(BR2_<foo>),y)
>   use the feature
> else
>   don't use the feature
> endif

Yes, that would make more sense I think.

>> +ifeq ($(BR2_PACKAGE_LIVE555),)
>> +VLC_CONF_OPT += --disable-live555
>> +else
>> +VLC_CONF_OPT += --disable-live555
>
> This should be --enable-live555

Oops. Will fix this, and all other occurrences of the same mistake.

>> +ifeq ($(BR2_PACKAGE_XLIB_LIBX11),)
>> +VLC_CONF_OPT += --without-x
>> +else
>> +VLC_CONF_OPT += --with-x
>> +VLC_DEPENDENCIES += xlib_libX11
>> +endif
>
> I wonder if this block shouldn't interact with the XCB block above.

I'm not so sure. I know xlib_libX11 selects libxcb, but I don't see
that mirroring this dependency will add any value to the vlc package
make file. That said, I'm quite happy to change it if you think that
the right thing to do.

Simon.

  reply	other threads:[~2014-01-07 11:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 22:09 [Buildroot] [PATCH] vlc: new package spdawson at gmail.com
2014-01-07  3:39 ` Baruch Siach
2014-01-07 11:17   ` Simon Dawson
2014-01-07 11:51     ` Baruch Siach
2014-01-07 11:52       ` Simon Dawson
2014-01-07  6:26 ` Thomas Petazzoni
2014-01-07 11:20   ` Simon Dawson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-04-02 16:05 Alexey Brodkin
2013-03-19 10:05 Alexey Brodkin
2013-04-02  5:08 ` Bernd Kuhls
2013-04-26  7:33   ` Alexey Brodkin
2013-05-06 15:35 ` Alexey Brodkin
2014-02-04  9:40 ` Thomas Petazzoni
2014-02-04  9:55   ` Alexey Brodkin
2012-02-28  0:02 [Buildroot] [PATCH] vlc: New package Ismael Luceno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHt8ZCPBrzeWazPKTOy+JT7Bfu38VWYN29LFz-pUo5zuEmZx4Q@mail.gmail.com \
    --to=spdawson@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.