From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
qemu-level <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2] build-sys: fix git version from -version
Date: Tue, 29 Sep 2020 19:33:04 +0400 [thread overview]
Message-ID: <CAJ+F1C+oGqrKYKPTnNrO-3XM7_raaHY4ofdbd1xxtY8CPYd-mQ@mail.gmail.com> (raw)
In-Reply-To: <CAE2XoE9x4ovaUaNJhh=-deYqYJKQC68wQaACQbnC28EZoeEqUg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Tue, Sep 29, 2020 at 6:43 PM 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com>
wrote:
>
>
> On Tue, Sep 29, 2020 at 10:38 PM <marcandre.lureau@redhat.com> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Typo introduced with the script.
> >
> > Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > scripts/qemu-version.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> > index 03128c56a2..3f6e7e6d41 100755
> > --- a/scripts/qemu-version.sh
> > +++ b/scripts/qemu-version.sh
> > @@ -9,7 +9,7 @@ version="$3"
> > if [ -z "$pkgversion" ]; then
> > cd "$dir"
> > if [ -e .git ]; then
> > - pkgversion=$(git describe --match 'v*' --dirty | echo "")
> > + pkgversion=$(git describe --match 'v*' --dirty) || :
> > fi
> > fi
> >
> > --
> > 2.26.2
> >
> >
> Maybe this script can convert to python? as we are converting to
> meson+python,
> for less care about different bash/zsh/xsh differences?
>
You are welcome to do it :)
thanks
> --
> 此致
> 礼
> 罗勇刚
> Yours
> sincerely,
> Yonggang Luo
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2316 bytes --]
next prev parent reply other threads:[~2020-09-29 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 14:36 [PATCH v2] build-sys: fix git version from -version marcandre.lureau
2020-09-29 14:42 ` 罗勇刚(Yonggang Luo)
2020-09-29 15:33 ` Marc-André Lureau [this message]
2020-09-29 15:56 ` 罗勇刚(Yonggang Luo)
2020-09-29 14:52 ` Eric Blake
2020-10-01 10:17 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+F1C+oGqrKYKPTnNrO-3XM7_raaHY4ofdbd1xxtY8CPYd-mQ@mail.gmail.com \
--to=marcandre.lureau@gmail.com \
--cc=lersek@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.