From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49881C433F5 for ; Tue, 5 Oct 2021 21:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3177C6126A for ; Tue, 5 Oct 2021 21:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235126AbhJEVpg (ORCPT ); Tue, 5 Oct 2021 17:45:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235088AbhJEVpf (ORCPT ); Tue, 5 Oct 2021 17:45:35 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 385CAC061749 for ; Tue, 5 Oct 2021 14:43:44 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id l6so326133plh.9 for ; Tue, 05 Oct 2021 14:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KueyQP1qhZFXjcASjngiU44PCPT1m0q8kUWaGeTu76Y=; b=wvHYe1hON2UBjCvCrhb7WUdeFjV8+LdwRxK5rw+KpAZ3fRx2qqaune3ittmGEf2MeU JiWAmZ2fftTiR+I8pxszim004hsd0Q13HwxPxDIlHK0i9etQKd1XZljax00sUzDj0b5d Ny1Z3nxHB+JiiyN+WyPrHcAklsF0p27YijqpVPg/N3WJG5XXlS8zo71dqUcrYZxmqNge NLeBN7SsyrAz7/PO78W+0uuqgHrgtkxW7ZggVbtdvqD25jkEhHYXKuf3qCJxRo1JpycO 7x/JVnnjWzhW1k6dZfnBYTiI7VFIq3eyJALAR8kGCDfbtrPGEadiLbxVChY5loDXQaJJ r5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KueyQP1qhZFXjcASjngiU44PCPT1m0q8kUWaGeTu76Y=; b=VI0RALxklRnzzP7DB0J3B99PheuYzplMf1bybSoM9h6LH2Z435wSr07tJNHB7rYCAc WsJi/SbcI2UWraG7whECgnxrmRvdYWu4iDC8cG0ZAl+cnNw75MIFe2Ax6YN3Yc7LG4tJ 8uUOjA+scHUuitw2hU+kM5xeSOtRjHnwfzJzXZgn5kWQ9PPMVS6+AE6xEXDOTslTesdx aI0F80Y/XXFo5JzaxiCxD7/ETBAQBZ1J9LJfawc5sp8aldd9Q1UsUQxiyUf2/J77wfBG 9mL8ElAmH9Bma9OJ4HgLVOq2BvV/s37c6yY+sUXe7WGxRcqerLhNWozOg6a5cnryQl+y gSlw== X-Gm-Message-State: AOAM533eCHYXHFMaV8QRPhcNcdjUl90KM8CQpPc6bUfz7d3XKZiNdLNc ioRttH/3tYAK/tWTIb3BM4IfE23EtoZFHV2phEH1GA== X-Google-Smtp-Source: ABdhPJz5msu3tpgzjyQlXtcG3TaMTV8djnu63L0f25Gd4yaLGKWeWwPfwN1wloTy8zkkyk9KCPXOpiNDEEm+EwuDXTs= X-Received: by 2002:a17:902:d903:b0:13e:d890:e4c4 with SMTP id c3-20020a170902d90300b0013ed890e4c4mr7512780plz.12.1633470223694; Tue, 05 Oct 2021 14:43:43 -0700 (PDT) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Tim Harvey Date: Tue, 5 Oct 2021 14:43:32 -0700 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Jagan Teki Cc: Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > Hi Sam, > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > Hi Jagan, > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > This series supports common bridge support for Samsung MIPI DSIM > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > Right now bridge offers two sets of implementations. > > > > > > A. With component_ops and exynos specific code exclusively for > > > exynos dsi drivers and it's legacy bindings. > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > users like i.MX8MM. > > > > > > The future plan is to fix the implementation A) by dropping > > > component_ops and fixing exynos specific code in order to make > > > the bridge more mature to use and the same is mentioned in > > > drivers TODO. > > > > > > Patch 0001 - 0006: Bridge conversion > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > Anyone interest, please have a look on this repo > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > Would appreciate anyone from the exynos team to test it on > > > the exynos platform? > > > > > > Any inputs? > > > > I really like where you are headign with this! > > No testing - sorry. But I will try to provide a bit of feedback on the > > individual patches. > > > > I hope you find a way to move forward with this. > > Thanks for the response. > > We have found some issues with Bridge conversion on existing exynos > drivers. The component based DSI drivers(like exynos) are difficult to > attach if it involves kms hotplug. kms hotplug would require drm > pointer and that pointer would only available after the bind call > finishes. But the bridge attach in bind call will defer till it find > the attached bridge. > > Right now I'm trying to find the proper way to attach the bridges for > component based DSI drivers which involves kms hot-plug. > > If you have any ideas on this, please let me know. > Jagan, How is your progress on this series? Looking at your repo it looks like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim branch but you've got a lot of things there that are likely not related to this series? Best regards, Tim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6C9C433F5 for ; Tue, 5 Oct 2021 21:45:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA2ED6115B for ; Tue, 5 Oct 2021 21:45:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA2ED6115B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9UmCnMigWNnG7z74Hr5QIs/0L7wjNrfQ+UYHktEJEUA=; b=AeBrDtyDmC9mfA BGk7vhGlGD2Aj3lwHadptqucufLgRxX/KZlm0mfP4XiPHrc7M6bRiIncgoZpk42MPkukHl9cO096J XgDYElAbeQVLkQSt2cgI2HcCt5yKysC4sEGzKmlCWcU4git03Hneo41BXjuaCJpjUUh9T875fe/B9 ml7rdWiV3mg/pCPyUfQjzQHGI86D4q4g7o/n73rZ8ixO/n3eE9JyfI/D7iJd4uQS2Wdfwcqi5Niq0 Vw7F46KX32RGBDuUTX1ZVOdMw6RpgKrZc4mUZ6rFPq8C+4HN1hSUEant+tYGKrR70a6kMkTrFIQ/k hM7j1umxvrvzR2+5UIRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXsE0-00Bxty-CP; Tue, 05 Oct 2021 21:43:48 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXsDw-00BxtW-OK for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 21:43:46 +0000 Received: by mail-pl1-x62c.google.com with SMTP id x4so377273pln.5 for ; Tue, 05 Oct 2021 14:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KueyQP1qhZFXjcASjngiU44PCPT1m0q8kUWaGeTu76Y=; b=wvHYe1hON2UBjCvCrhb7WUdeFjV8+LdwRxK5rw+KpAZ3fRx2qqaune3ittmGEf2MeU JiWAmZ2fftTiR+I8pxszim004hsd0Q13HwxPxDIlHK0i9etQKd1XZljax00sUzDj0b5d Ny1Z3nxHB+JiiyN+WyPrHcAklsF0p27YijqpVPg/N3WJG5XXlS8zo71dqUcrYZxmqNge NLeBN7SsyrAz7/PO78W+0uuqgHrgtkxW7ZggVbtdvqD25jkEhHYXKuf3qCJxRo1JpycO 7x/JVnnjWzhW1k6dZfnBYTiI7VFIq3eyJALAR8kGCDfbtrPGEadiLbxVChY5loDXQaJJ r5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KueyQP1qhZFXjcASjngiU44PCPT1m0q8kUWaGeTu76Y=; b=e4S724sDzCTBfzEPnEn+wxUsMBHiaytbp8lO26n6LPuuLsgJhUr4x3ptYQPYGng/TH HEX4GHRELz11vt9woAhAWzVS/XDA5CIqI2t5AfC5iry2ZCrAnasQEtcwzyUA+O0s6XFN Cddpia2xpNrpbPTDpQokbvNepOWUxNj/kaOdtm160vYyApd5VnjzUcszlMK6AJCljIZ8 jxNr5GxOdWMocRK5+RSkbhQWwZOBIGpwZtCnIHpQtgBjoUuyKYb4q3Zvsr7o1hNjhveQ LKYHKU9NHnNy1mx3qL9IJYAvO6RbNPijzRdXBqxQhNDG7+9ltN5JzY5TxlJBjHocMVvT YZmg== X-Gm-Message-State: AOAM533HHx62RgBefokV7wtGnxpzwGvZI/SGrO7o/Yx49vIQQ4E2CbjB kvhFoKmOxCepQAbIclqizAf563iPZQZB2Rs3eSUNbg== X-Google-Smtp-Source: ABdhPJz5msu3tpgzjyQlXtcG3TaMTV8djnu63L0f25Gd4yaLGKWeWwPfwN1wloTy8zkkyk9KCPXOpiNDEEm+EwuDXTs= X-Received: by 2002:a17:902:d903:b0:13e:d890:e4c4 with SMTP id c3-20020a170902d90300b0013ed890e4c4mr7512780plz.12.1633470223694; Tue, 05 Oct 2021 14:43:43 -0700 (PDT) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Tim Harvey Date: Tue, 5 Oct 2021 14:43:32 -0700 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Jagan Teki Cc: Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_144344_858825_FD78078E X-CRM114-Status: GOOD ( 32.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > Hi Sam, > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > Hi Jagan, > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > This series supports common bridge support for Samsung MIPI DSIM > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > Right now bridge offers two sets of implementations. > > > > > > A. With component_ops and exynos specific code exclusively for > > > exynos dsi drivers and it's legacy bindings. > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > users like i.MX8MM. > > > > > > The future plan is to fix the implementation A) by dropping > > > component_ops and fixing exynos specific code in order to make > > > the bridge more mature to use and the same is mentioned in > > > drivers TODO. > > > > > > Patch 0001 - 0006: Bridge conversion > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > Anyone interest, please have a look on this repo > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > Would appreciate anyone from the exynos team to test it on > > > the exynos platform? > > > > > > Any inputs? > > > > I really like where you are headign with this! > > No testing - sorry. But I will try to provide a bit of feedback on the > > individual patches. > > > > I hope you find a way to move forward with this. > > Thanks for the response. > > We have found some issues with Bridge conversion on existing exynos > drivers. The component based DSI drivers(like exynos) are difficult to > attach if it involves kms hotplug. kms hotplug would require drm > pointer and that pointer would only available after the bind call > finishes. But the bridge attach in bind call will defer till it find > the attached bridge. > > Right now I'm trying to find the proper way to attach the bridges for > component based DSI drivers which involves kms hot-plug. > > If you have any ideas on this, please let me know. > Jagan, How is your progress on this series? Looking at your repo it looks like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim branch but you've got a lot of things there that are likely not related to this series? Best regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel