All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Albert Aribaud" <albert.u.boot@aribaud.net>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Tom Rini" <trini@konsulko.com>
Subject: Re: [PATCH v2 2/3] arm: Add an __image_copy_start symbol for ARMv8
Date: Mon, 26 Jul 2021 11:20:25 -0700	[thread overview]
Message-ID: <CAJ+vNU38bUc4yZs0T7HfR9d_vEoJJf1-SedJD05_Zn-pmg+XBA@mail.gmail.com> (raw)
In-Reply-To: <20210725165416.470735-2-sjg@chromium.org>

On Sun, Jul 25, 2021 at 9:54 AM Simon Glass <sjg@chromium.org> wrote:
>
> This symbol is needed for binman to locate the start of the image. Add it.
>
> Note: the existing line to bring in the .__image_copy_start symbol does
> not appear to do anything.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Add new patch to add an __image_copy_start symbol for ARMv8
>
>  arch/arm/cpu/armv8/u-boot-spl.lds | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot-spl.lds
> index 9edb662b094..2827a07590d 100644
> --- a/arch/arm/cpu/armv8/u-boot-spl.lds
> +++ b/arch/arm/cpu/armv8/u-boot-spl.lds
> @@ -22,6 +22,7 @@ ENTRY(_start)
>  SECTIONS
>  {
>         .text : {
> +               __image_copy_start = .;
>                 . = ALIGN(8);
>                 *(.__image_copy_start)
>                 CPUDIR/start.o (.text*)
> --
> 2.32.0.432.gabb21c7263-goog
>

Sould the '*(.__image_copy_start)' be removed?

I'll admit that I'm not very knowledgable when it comes to linker
files. I did verify removing it boots fine.

Tim

  reply	other threads:[~2021-07-26 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 16:54 [PATCH v2 1/3] imx8: Drop raw image support Simon Glass
2021-07-25 16:54 ` [PATCH v2 2/3] arm: Add an __image_copy_start symbol for ARMv8 Simon Glass
2021-07-26 18:20   ` Tim Harvey [this message]
2021-07-28  2:46     ` Simon Glass
2021-07-25 16:54 ` [PATCH v2 3/3] binman: Show an error if __image_copy_start is missing Simon Glass
2021-07-26 18:36   ` Tim Harvey
2021-07-26  7:33 ` [PATCH v2 1/3] imx8: Drop raw image support Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+vNU38bUc4yZs0T7HfR9d_vEoJJf1-SedJD05_Zn-pmg+XBA@mail.gmail.com \
    --to=tharvey@gateworks.com \
    --cc=albert.u.boot@aribaud.net \
    --cc=marek.behun@nic.cz \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.