All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Shijith Thotton <sthotton@marvell.com>, Akhil Goyal <gakhil@marvell.com>
Cc: dev <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>,
	 Anoob Joseph <anoobj@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
	Ankur Dwivedi <adwivedi@marvell.com>,
	 Ray Kinsella <mdr@ashroe.eu>, Aaron Conole <aconole@redhat.com>,
	dpdklab <dpdklab@iol.unh.edu>,
	Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework
Date: Thu, 15 Jul 2021 16:21:58 +0200	[thread overview]
Message-ID: <CAJFAV8xFay4SuQLx5po1TaKKNmhFLRaFffFBTjCu+w-3EETu1w@mail.gmail.com> (raw)
In-Reply-To: <2bd2c4be2295105b81843d31c1bcb4dab7e1aff7.1624481225.git.sthotton@marvell.com>

Hello,

On Wed, Jun 23, 2021 at 10:54 PM Shijith Thotton <sthotton@marvell.com> wrote:
> diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
> index 3cb140b4de..0d9eec3f2e 100644
> --- a/drivers/event/octeontx/meson.build
> +++ b/drivers/event/octeontx/meson.build
> @@ -12,3 +12,4 @@ sources = files(
>  )
>
>  deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'net_octeontx']
> +deps += ['crypto_octeontx']

This extra dependency resulted in disabling the event/octeontx driver
in FreeBSD, since crypto/octeontx only builds on Linux.
Removing hw support triggers a ABI failure for FreeBSD.


- This had been reported by UNH CI:
http://mails.dpdk.org/archives/test-report/2021-June/200637.html
It seems the result has been ignored but it should have at least
raised some discussion.


- I asked UNH to stop testing FreeBSD abi for now, waiting to get the
main branch fixed.

I don't have the time to look at this, please can you work on it?

Several options:
* crypto/octeontx is made so that it compiles on FreeBSD,
* the abi check is extended to have exceptions per OS,
* the FreeBSD abi reference is regenerated at UNH not to have those
drivers in it (not sure it is doable),


Thanks.

-- 
David Marchand


  parent reply	other threads:[~2021-07-15 14:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 16:48 [dpdk-dev] [PATCH 0/2] OCTEONTX crypto adapter support Shijith Thotton
2021-06-22 16:48 ` [dpdk-dev] [PATCH 1/2] drivers: add octeontx crypto adapter framework Shijith Thotton
2021-06-22 16:48 ` [dpdk-dev] [PATCH 2/2] drivers: add octeontx crypto adapter data path Shijith Thotton
2021-07-06 20:20   ` Akhil Goyal
2021-06-23 20:53 ` [dpdk-dev] [PATCH v2 0/2] OCTEONTX crypto adapter support Shijith Thotton
2021-06-23 20:53   ` [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework Shijith Thotton
2021-07-06 20:14     ` Akhil Goyal
2021-07-15 14:21     ` David Marchand [this message]
2021-07-16  8:39       ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20 11:58         ` Akhil Goyal
2021-07-20 12:14           ` David Marchand
2021-07-21  9:44             ` Thomas Monjalon
2021-07-21 15:11               ` Brandon Lo
2021-07-22  7:45               ` Akhil Goyal
2021-07-22  9:06                 ` [dpdk-dev] [PATCH] crypto/octeontx: enable build on non Linux OS Shijith Thotton
2021-07-22  9:17                   ` Akhil Goyal
2021-07-22 19:06                     ` Thomas Monjalon
2021-07-22 19:08                       ` Thomas Monjalon
2021-07-22 20:20                         ` Brandon Lo
2021-07-22 20:32                           ` Thomas Monjalon
2021-06-23 20:53   ` [dpdk-dev] [PATCH v2 2/2] drivers: add octeontx crypto adapter data path Shijith Thotton
2021-06-30  8:54     ` Akhil Goyal
2021-06-30 16:23       ` [dpdk-dev] [dpdk-ci] " Brandon Lo
2021-07-07  9:28   ` [dpdk-dev] [PATCH v2 0/2] OCTEONTX crypto adapter support Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xFay4SuQLx5po1TaKKNmhFLRaFffFBTjCu+w-3EETu1w@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=aconole@redhat.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lylavoie@iol.unh.edu \
    --cc=mdr@ashroe.eu \
    --cc=pbhagavatula@marvell.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.