From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev <dev@dpdk.org>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
nd <nd@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] LPM changes
Date: Tue, 15 Sep 2020 16:41:12 +0200 [thread overview]
Message-ID: <CAJFAV8yMf8Sn6gi6aiR6xwUFszhp00wpD18YdaEqZCt3=uowkg@mail.gmail.com> (raw)
In-Reply-To: <20200907081518.46350-1-ruifeng.wang@arm.com>
On Mon, Sep 7, 2020 at 10:15 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>
> The rte_lpm structure is exported because lookup API is inlined.
> But most of the structure can be hidden.
> Discussion at: http://patches.dpdk.org/patch/72403/
> This patch set aimed to hide the rte_lpm structure as much as possible.
>
> A data free issue was identified and fixed.
>
> Ruifeng Wang (2):
> lpm: fix free of data structure
> lpm: hide internal data
>
> lib/librte_lpm/rte_lpm.c | 154 +++++++++++++++++++++++----------------
> lib/librte_lpm/rte_lpm.h | 7 --
> 2 files changed, 92 insertions(+), 69 deletions(-)
Cc: maintainers.
Those changes look good to me.
Opinions?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-09-15 15:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 8:15 [dpdk-dev] [PATCH 0/2] LPM changes Ruifeng Wang
2020-09-07 8:15 ` [dpdk-dev] [PATCH 1/2] lpm: fix free of data structure Ruifeng Wang
2020-09-15 15:55 ` Bruce Richardson
2020-09-15 16:25 ` Medvedkin, Vladimir
2020-09-07 8:15 ` [dpdk-dev] [PATCH 2/2] lpm: hide internal data Ruifeng Wang
2020-09-15 16:02 ` Bruce Richardson
2020-09-15 16:28 ` Medvedkin, Vladimir
2020-09-16 3:17 ` Ruifeng Wang
2020-09-30 8:45 ` Kevin Traynor
2020-10-09 6:54 ` Ruifeng Wang
2020-10-13 13:53 ` Kevin Traynor
2020-10-13 14:58 ` Michel Machado
2020-10-13 15:41 ` Medvedkin, Vladimir
2020-10-13 17:46 ` Michel Machado
2020-10-13 19:06 ` Medvedkin, Vladimir
2020-10-13 19:48 ` Michel Machado
2020-10-14 13:10 ` Medvedkin, Vladimir
2020-10-14 23:57 ` Honnappa Nagarahalli
2020-10-15 13:39 ` Michel Machado
2020-10-15 17:38 ` Honnappa Nagarahalli
2020-10-15 19:30 ` Medvedkin, Vladimir
2020-10-15 22:54 ` Honnappa Nagarahalli
2020-10-16 11:39 ` Kevin Traynor
2020-10-16 13:55 ` Michel Machado
2020-10-19 14:53 ` David Marchand
2020-10-20 14:22 ` Thomas Monjalon
2020-10-20 14:32 ` Medvedkin, Vladimir
2020-10-19 17:53 ` Honnappa Nagarahalli
2020-09-15 14:41 ` David Marchand [this message]
2020-10-19 13:37 ` [dpdk-dev] [PATCH 0/2] LPM changes Kevin Traynor
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 " Ruifeng Wang
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 1/2] lpm: fix free of data structure Ruifeng Wang
2020-10-21 3:02 ` [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data Ruifeng Wang
2020-10-21 7:58 ` Thomas Monjalon
2020-10-21 8:15 ` Ruifeng Wang
2020-10-22 15:14 ` David Marchand
2020-10-23 6:13 ` Ruifeng Wang
2020-10-23 16:08 ` Medvedkin, Vladimir
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 0/2] LPM changes David Marchand
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 1/2] lpm: fix free of data structure David Marchand
2020-10-23 9:38 ` [dpdk-dev] [PATCH v3 2/2] lpm: hide internal data David Marchand
2020-10-26 8:26 ` [dpdk-dev] [PATCH v3 0/2] LPM changes David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yMf8Sn6gi6aiR6xwUFszhp00wpD18YdaEqZCt3=uowkg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.