From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB00C433E0 for ; Tue, 16 Feb 2021 10:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E20F64D99 for ; Tue, 16 Feb 2021 10:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbhBPKXV (ORCPT ); Tue, 16 Feb 2021 05:23:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:57342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbhBPKVl (ORCPT ); Tue, 16 Feb 2021 05:21:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F2DA264DE0; Tue, 16 Feb 2021 10:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613470861; bh=ELgcIQXALPguJaOZgn++Pynu3kfkRH1G8GoAn1mqJ7I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dUNelPnuuhmu96bj6fTNcSfGg47UQELco9Wybizd4fEB1Y/c4kFxMzMXmOpiTvjap dhzMWT3ffyy863iy2K1oUy5JCvgwb3+ohpz/xFE6/t1KwKJ4Dh65Q5NDKSsA7LWwYc IAOv468qpJQ7/a8lOkiFljTzalBE/tAHpFnhXTfz/4LZSo0i6i2Iqh/UKdXizawoXC eC19rg+pFzrgWQ4paUI8i5vfujOENcw2lhsJ59zC98szkP65I/e42JCxIHAd1QkGu+ jcfslsRYBk49+SuyxdPTBc1pQqqTkv78BiIQ2EI6+zMpWfP7EIPnzwH3EBdZk4d6Sd iQSx67iLfrylg== Received: by mail-ej1-f49.google.com with SMTP id g5so12149426ejt.2; Tue, 16 Feb 2021 02:21:00 -0800 (PST) X-Gm-Message-State: AOAM531DwpUExM21556kTFZS4pbhoqIWtIpPkBpPEhB0yqDnAdyFsf9r F+vUj0DxavsJ0DCASmULWLwWpxQTjMrQATktoKY= X-Google-Smtp-Source: ABdhPJxX5NZv34e/hqZBU7CvR8NWGRl3k9oSuP8v63dIVVtzMYfS1vLWWxVVIDu5jyJywxm+62+AJJnAl0q6bab3aBM= X-Received: by 2002:a17:906:2898:: with SMTP id o24mr19293928ejd.215.1613470859401; Tue, 16 Feb 2021 02:20:59 -0800 (PST) MIME-Version: 1.0 References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-24-marcan@marcan.st> <20210215191748.uhus2e6gclkwgjo5@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 16 Feb 2021 11:20:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs To: Arnd Bergmann Cc: Hector Martin , Linux ARM , Marc Zyngier , Rob Herring , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , DTML , "linux-kernel@vger.kernel.org" , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: > > > + return samsung_early_console_setup(device, opt); > > > > Don't you need to handle the error code - set PROT_DEFAULT() or whatever > > was there before? > > __set_fixmap() has no return value, it just writes a page table entry and > does not fail. I meant, handle samsung_early_console_setup() error code (NULL). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923EEC433DB for ; Tue, 16 Feb 2021 10:22:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36AD064D99 for ; Tue, 16 Feb 2021 10:22:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36AD064D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=deIlJkn09Bm75T/96EGw3qe7fRVasoYKA7gBEqepgSo=; b=MDov/pkzdnAs6OZjF5g089izv iTawou6UOa9neBlLE7kuu7UrKla9XaDWTZHG9weAqOjgXqMEY40YdCYo0aJYgAeu6wqlpzmuuHwyU oHE0uTvsvLjDoGlHX8oL4tTrgp9CiR8Z0O5b0afuD2PQEs2NZ/Jzm1omuO0sub1gvQNj+EeCNXokz nbuOdrGparg3a8zkHce/4tMsqhFVR50HenDWPWX/9Jz0aOtsTMaaKq/0GSaDRnHM3xoyIhgbKMxL+ hc0l8JWE8qAXiWn0LY1dL4nxI361PKeLIgDl1Gs+OObJeBNzecW419Af4YkRrXwRqvzbbiK5EuqPp ZHmk3V3ZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBxTd-0007RZ-KE; Tue, 16 Feb 2021 10:21:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lBxTa-0007Qo-Th for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2021 10:21:03 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DC7F64E04 for ; Tue, 16 Feb 2021 10:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613470861; bh=ELgcIQXALPguJaOZgn++Pynu3kfkRH1G8GoAn1mqJ7I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dUNelPnuuhmu96bj6fTNcSfGg47UQELco9Wybizd4fEB1Y/c4kFxMzMXmOpiTvjap dhzMWT3ffyy863iy2K1oUy5JCvgwb3+ohpz/xFE6/t1KwKJ4Dh65Q5NDKSsA7LWwYc IAOv468qpJQ7/a8lOkiFljTzalBE/tAHpFnhXTfz/4LZSo0i6i2Iqh/UKdXizawoXC eC19rg+pFzrgWQ4paUI8i5vfujOENcw2lhsJ59zC98szkP65I/e42JCxIHAd1QkGu+ jcfslsRYBk49+SuyxdPTBc1pQqqTkv78BiIQ2EI6+zMpWfP7EIPnzwH3EBdZk4d6Sd iQSx67iLfrylg== Received: by mail-ej1-f42.google.com with SMTP id f14so15623557ejc.8 for ; Tue, 16 Feb 2021 02:21:00 -0800 (PST) X-Gm-Message-State: AOAM53059t+3ZaHpcbtt1oTNU+RbPF2eRLzA/fNPqzxNakgOjNM9ZJcQ 96OePBnjb/cICRMKhy5siFWPpsN/1oUaZGYlkL0= X-Google-Smtp-Source: ABdhPJxX5NZv34e/hqZBU7CvR8NWGRl3k9oSuP8v63dIVVtzMYfS1vLWWxVVIDu5jyJywxm+62+AJJnAl0q6bab3aBM= X-Received: by 2002:a17:906:2898:: with SMTP id o24mr19293928ejd.215.1613470859401; Tue, 16 Feb 2021 02:20:59 -0800 (PST) MIME-Version: 1.0 References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-24-marcan@marcan.st> <20210215191748.uhus2e6gclkwgjo5@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 16 Feb 2021 11:20:46 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 23/25] tty: serial: samsung_tty: Add earlycon support for Apple UARTs To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210216_052103_035655_04CDF367 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Arnd Bergmann , DTML , Tony Lindgren , Marc Zyngier , Linus Walleij , Hector Martin , "linux-kernel@vger.kernel.org" , Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , Linux ARM , Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann wrote: > > > + return samsung_early_console_setup(device, opt); > > > > Don't you need to handle the error code - set PROT_DEFAULT() or whatever > > was there before? > > __set_fixmap() has no return value, it just writes a page table entry and > does not fail. I meant, handle samsung_early_console_setup() error code (NULL). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel