From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9584C43457 for ; Mon, 12 Oct 2020 17:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8391F20838 for ; Mon, 12 Oct 2020 17:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602522505; bh=diu7jTvqirdea73U2Pivn25Z5fqp8dxACmIMHPhvbwQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=lvYU6nWEtqLiny7Cn2wV2A0+L/oddP6FsFg+r+/7KIP8/TIZH3aYCfibIH11D+Ldg JR1uA47uEK9raGMGhKMR0FreMiULiGkQL5niucuSkPvemvPaYmLSJAJ8GHgTiY5TsH 0/DMSjc+tc/CATYmtP6B/NUhbZq/4p2fvkVHPs6M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404040AbgJLRIY (ORCPT ); Mon, 12 Oct 2020 13:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:43252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403845AbgJLRIY (ORCPT ); Mon, 12 Oct 2020 13:08:24 -0400 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D09C2087D; Mon, 12 Oct 2020 17:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602522503; bh=diu7jTvqirdea73U2Pivn25Z5fqp8dxACmIMHPhvbwQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eAbD7YbuBxUjjRD7VMI3SGS3JQ3/TPUQvQE/GWdsGv+V5X5ieFF4h7fQgI7OYFS1b Y+DRqJUmrxFo3PvsyQj/5Gqc5T6wtjZIJVkyKK/+/KuSG6NGe10bRkdb3R8Lo16/K6 dMkMi9dt6nkV86/Y/W/AiB3XefGkBc8YLmq3+Sck= Received: by mail-ed1-f44.google.com with SMTP id l16so17798859eds.3; Mon, 12 Oct 2020 10:08:23 -0700 (PDT) X-Gm-Message-State: AOAM532+OxvaA2c7AgICD3OSDGbJa5UOp65LY+Halr/WkCHQN6iapH7h WohjzY8qIfl5wWRMtDHTttwX34HowDeRfavP6Rs= X-Google-Smtp-Source: ABdhPJznFFkxxdcO9CFLA1y4py80sWN1jeeBhSeZnTVvSdAbSWX+EHDk5exEBJ+K31o8PGsm86EFdFdTJq7JbVnnqqk= X-Received: by 2002:aa7:c643:: with SMTP id z3mr13042703edr.104.1602522502225; Mon, 12 Oct 2020 10:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> In-Reply-To: <1601958415.26323.25.camel@mhfsdcap03> From: Krzysztof Kozlowski Date: Mon, 12 Oct 2020 19:08:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu Cc: Joerg Roedel , Matthias Brugger , Rob Herring , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , anan.sun@mediatek.com, chao.hao@mediatek.com, ming-fan.chen@mediatek.com, Greg Kroah-Hartman , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > > 2 files changed, 154 insertions(+), 103 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > > > > [...] > > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > > + > > > + - description: mt7623 generation one HW > > > + items: > > > + - const: mediatek,mt7623-m4u > > > + - const: mediatek,mt2701-m4u > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + description: | > > > + bclk is optional. here is the list which require this bclk: > > > + mt2701, mt2712, mt7623 and mt8173. > > > > Similarly to my comment in other patch, this should be part of schema > > within 'if-then'. > > Thanks for the review. > > I will change like this: > > ============= > clocks: > items: > - description: bclk is the block clock. > > clock-names: > items: > - const: bclk > > required: > - compatible > - reg > - interrupts > - mediatek,larbs > - '#iommu-cells' > if: > properties: > compatible: > contains: > enum: > - mediatek,mt2701-m4u > - mediatek,mt2712-m4u > - mediatek,mt8173-m4u > > then: > required: > - clocks > ============== > > If this is not right, please tell me. > (dt_binding_check is ok.) Looks fine, except "if" should be part of some "allOf" block. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABE3C433E7 for ; Mon, 12 Oct 2020 17:08:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5EAE2087E for ; Mon, 12 Oct 2020 17:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l33ti6Wh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5EAE2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E22E48697D; Mon, 12 Oct 2020 17:08:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q1lch5EWJ-kn; Mon, 12 Oct 2020 17:08:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 3A0E68692C; Mon, 12 Oct 2020 17:08:27 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C3A8C07FF; Mon, 12 Oct 2020 17:08:27 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 24B6EC0051 for ; Mon, 12 Oct 2020 17:08:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0CADE86963 for ; Mon, 12 Oct 2020 17:08:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fU4ffyc9Y07V for ; Mon, 12 Oct 2020 17:08:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 443458692C for ; Mon, 12 Oct 2020 17:08:25 +0000 (UTC) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADEBC214D8 for ; Mon, 12 Oct 2020 17:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602522504; bh=diu7jTvqirdea73U2Pivn25Z5fqp8dxACmIMHPhvbwQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=l33ti6Wh+Yoy28eOWfBvJIGFVVsEGuoGcfMEc1rp3LXWY2i1AsPCJKFJ6JTa8n2Ej zXnu25cLJRfBDN2Hu9c0VAgD8B97+fz2FO6Sr1e/x+F5NBsYByZbFD/O5LeYIT97kb 7C9jn70SgLa9QD/DQPLf+JcrmnMyxCXFsstt94M4= Received: by mail-ed1-f41.google.com with SMTP id t21so17785300eds.6 for ; Mon, 12 Oct 2020 10:08:23 -0700 (PDT) X-Gm-Message-State: AOAM533rUwIFsqBVkXb7Dax1GfRA2qAYvzFo3t+1v7ddH8J+oIlOp2xh ppwzR0uZ2+rMgVOa3xQ7k1m515YqE6W5aqV+0KI= X-Google-Smtp-Source: ABdhPJznFFkxxdcO9CFLA1y4py80sWN1jeeBhSeZnTVvSdAbSWX+EHDk5exEBJ+K31o8PGsm86EFdFdTJq7JbVnnqqk= X-Received: by 2002:aa7:c643:: with SMTP id z3mr13042703edr.104.1602522502225; Mon, 12 Oct 2020 10:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> In-Reply-To: <1601958415.26323.25.camel@mhfsdcap03> From: Krzysztof Kozlowski Date: Mon, 12 Oct 2020 19:08:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > > 2 files changed, 154 insertions(+), 103 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > > > > [...] > > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > > + > > > + - description: mt7623 generation one HW > > > + items: > > > + - const: mediatek,mt7623-m4u > > > + - const: mediatek,mt2701-m4u > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + description: | > > > + bclk is optional. here is the list which require this bclk: > > > + mt2701, mt2712, mt7623 and mt8173. > > > > Similarly to my comment in other patch, this should be part of schema > > within 'if-then'. > > Thanks for the review. > > I will change like this: > > ============= > clocks: > items: > - description: bclk is the block clock. > > clock-names: > items: > - const: bclk > > required: > - compatible > - reg > - interrupts > - mediatek,larbs > - '#iommu-cells' > if: > properties: > compatible: > contains: > enum: > - mediatek,mt2701-m4u > - mediatek,mt2712-m4u > - mediatek,mt8173-m4u > > then: > required: > - clocks > ============== > > If this is not right, please tell me. > (dt_binding_check is ok.) Looks fine, except "if" should be part of some "allOf" block. Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E8FC433E7 for ; Mon, 12 Oct 2020 17:08:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E166A20838 for ; Mon, 12 Oct 2020 17:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O/wkpxr8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l33ti6Wh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E166A20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dnfxlLGFzPdqMtZWCTTPRDnH6PlmMZmom584Z3jQItA=; b=O/wkpxr878e+LyKZWnrJM6osM Gr132BFOp3TKUZ7a8Y1pIFKXwWVeHsBRu9sjTfNblGTv3gPQRA9QGSfpKmP9H6mQsgosX+hXNVl31 QH75pA7ZM3ns1IcmmBaEKTYAMFRYRBB41JFAoHyLzoXHHdUJIufWtyp2zitP86+KXSb2IRlqKvmh+ WiiqUO/rkQalvD4CuwQkRjhfxa8/DtEwhNgf0aY6cONXod/6rSzx8dctNod7zPLu/i8BlPUQ82IWf O25jPMKGIZG61S42jvZCK3YuFGiBQYeDOQ66kP8NjW/oIy+/b+wcdEfg2icHEG589DyYcODbKppIT tbDjSDglA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS1JK-0003bR-GI; Mon, 12 Oct 2020 17:08:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS1JB-0003W8-OK; Mon, 12 Oct 2020 17:08:26 +0000 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0126214DB; Mon, 12 Oct 2020 17:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602522504; bh=diu7jTvqirdea73U2Pivn25Z5fqp8dxACmIMHPhvbwQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=l33ti6Wh+Yoy28eOWfBvJIGFVVsEGuoGcfMEc1rp3LXWY2i1AsPCJKFJ6JTa8n2Ej zXnu25cLJRfBDN2Hu9c0VAgD8B97+fz2FO6Sr1e/x+F5NBsYByZbFD/O5LeYIT97kb 7C9jn70SgLa9QD/DQPLf+JcrmnMyxCXFsstt94M4= Received: by mail-ed1-f42.google.com with SMTP id l24so17796823edj.8; Mon, 12 Oct 2020 10:08:23 -0700 (PDT) X-Gm-Message-State: AOAM530oq3Ahw7bD78NbjGxv5SP5bwen5NY/p3PQCsmoEc7ylM2nTh0/ 3KXjyY/mlOso/jvI9ZBvVl5CjdiTxSTPz8niKeY= X-Google-Smtp-Source: ABdhPJznFFkxxdcO9CFLA1y4py80sWN1jeeBhSeZnTVvSdAbSWX+EHDk5exEBJ+K31o8PGsm86EFdFdTJq7JbVnnqqk= X-Received: by 2002:aa7:c643:: with SMTP id z3mr13042703edr.104.1602522502225; Mon, 12 Oct 2020 10:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> In-Reply-To: <1601958415.26323.25.camel@mhfsdcap03> From: Krzysztof Kozlowski Date: Mon, 12 Oct 2020 19:08:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_130825_919643_CEF603A1 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > > 2 files changed, 154 insertions(+), 103 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > > > > [...] > > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > > + > > > + - description: mt7623 generation one HW > > > + items: > > > + - const: mediatek,mt7623-m4u > > > + - const: mediatek,mt2701-m4u > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + description: | > > > + bclk is optional. here is the list which require this bclk: > > > + mt2701, mt2712, mt7623 and mt8173. > > > > Similarly to my comment in other patch, this should be part of schema > > within 'if-then'. > > Thanks for the review. > > I will change like this: > > ============= > clocks: > items: > - description: bclk is the block clock. > > clock-names: > items: > - const: bclk > > required: > - compatible > - reg > - interrupts > - mediatek,larbs > - '#iommu-cells' > if: > properties: > compatible: > contains: > enum: > - mediatek,mt2701-m4u > - mediatek,mt2712-m4u > - mediatek,mt8173-m4u > > then: > required: > - clocks > ============== > > If this is not right, please tell me. > (dt_binding_check is ok.) Looks fine, except "if" should be part of some "allOf" block. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7737C433E7 for ; Mon, 12 Oct 2020 17:09:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C88820838 for ; Mon, 12 Oct 2020 17:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bdQkLJGF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l33ti6Wh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C88820838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LL4QL1Wp5YkM6A0Cl8UtmGrZ/n9/KR2zGDeyalr99c4=; b=bdQkLJGFQD6wGPmWJ6BoHMzre IYW/2VdG3e3iGYyZg3GeHeaMV+w05Gnp7auTbTsxYiuXO4fGNGfwWYa1xsgdXRrwUf7jsZYWoOtam ecNs2iHD/d5anlG1yMF7tyMwFWLHi8cF+tsE1aSlVBw2LkFqNr2yADPw7iyxdKW6/Gso7xFv6t3gR zEw9ugcB6uaQFiPmL/y3s0re75apCH/rUUH8NVRBbRXdKw1fquuwJT5vywzLND0ImsElBq/Qo0YD8 AjietSTxFxdHqR2v+sonVktLo10+tqN90xuIe8tg8cchT7zrV4rGmUsccub+V13sl9lJY5+QeXYTp 5IK8c7MYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS1JE-0003XO-An; Mon, 12 Oct 2020 17:08:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS1JB-0003W8-OK; Mon, 12 Oct 2020 17:08:26 +0000 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0126214DB; Mon, 12 Oct 2020 17:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602522504; bh=diu7jTvqirdea73U2Pivn25Z5fqp8dxACmIMHPhvbwQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=l33ti6Wh+Yoy28eOWfBvJIGFVVsEGuoGcfMEc1rp3LXWY2i1AsPCJKFJ6JTa8n2Ej zXnu25cLJRfBDN2Hu9c0VAgD8B97+fz2FO6Sr1e/x+F5NBsYByZbFD/O5LeYIT97kb 7C9jn70SgLa9QD/DQPLf+JcrmnMyxCXFsstt94M4= Received: by mail-ed1-f42.google.com with SMTP id l24so17796823edj.8; Mon, 12 Oct 2020 10:08:23 -0700 (PDT) X-Gm-Message-State: AOAM530oq3Ahw7bD78NbjGxv5SP5bwen5NY/p3PQCsmoEc7ylM2nTh0/ 3KXjyY/mlOso/jvI9ZBvVl5CjdiTxSTPz8niKeY= X-Google-Smtp-Source: ABdhPJznFFkxxdcO9CFLA1y4py80sWN1jeeBhSeZnTVvSdAbSWX+EHDk5exEBJ+K31o8PGsm86EFdFdTJq7JbVnnqqk= X-Received: by 2002:aa7:c643:: with SMTP id z3mr13042703edr.104.1602522502225; Mon, 12 Oct 2020 10:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> In-Reply-To: <1601958415.26323.25.camel@mhfsdcap03> From: Krzysztof Kozlowski Date: Mon, 12 Oct 2020 19:08:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema To: Yong Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_130825_919643_CEF603A1 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu > > > --- > > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > > 2 files changed, 154 insertions(+), 103 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > > > > [...] > > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > > + > > > + - description: mt7623 generation one HW > > > + items: > > > + - const: mediatek,mt7623-m4u > > > + - const: mediatek,mt2701-m4u > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + description: | > > > + bclk is optional. here is the list which require this bclk: > > > + mt2701, mt2712, mt7623 and mt8173. > > > > Similarly to my comment in other patch, this should be part of schema > > within 'if-then'. > > Thanks for the review. > > I will change like this: > > ============= > clocks: > items: > - description: bclk is the block clock. > > clock-names: > items: > - const: bclk > > required: > - compatible > - reg > - interrupts > - mediatek,larbs > - '#iommu-cells' > if: > properties: > compatible: > contains: > enum: > - mediatek,mt2701-m4u > - mediatek,mt2712-m4u > - mediatek,mt8173-m4u > > then: > required: > - clocks > ============== > > If this is not right, please tell me. > (dt_binding_check is ok.) Looks fine, except "if" should be part of some "allOf" block. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel