From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20151111214435.GB95024@tevye.fc.hp.com> References: <20151109215904.GB33245@tevye.fc.hp.com> <20151111214435.GB95024@tevye.fc.hp.com> Date: Thu, 12 Nov 2015 00:52:47 +0300 Message-ID: Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru From: Dmitry Krivenok Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org To: Jerry Hoemann Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, Len Brown , dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org List-ID: > but, we still want to go through entire list. Shouldn't you break the loop immediately after you found the bus and sent ioctl? Maybe I'm missing something, but I see no reason to continue iterating after the bus was found (even though you don't do anything and just compare IDs and "continue"). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839AbbKKVwu (ORCPT ); Wed, 11 Nov 2015 16:52:50 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:36166 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbbKKVws (ORCPT ); Wed, 11 Nov 2015 16:52:48 -0500 MIME-Version: 1.0 In-Reply-To: <20151111214435.GB95024@tevye.fc.hp.com> References: <20151109215904.GB33245@tevye.fc.hp.com> <20151111214435.GB95024@tevye.fc.hp.com> Date: Thu, 12 Nov 2015 00:52:47 +0300 Message-ID: Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru From: Dmitry Krivenok To: Jerry Hoemann Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, Len Brown , dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > but, we still want to go through entire list. Shouldn't you break the loop immediately after you found the bus and sent ioctl? Maybe I'm missing something, but I see no reason to continue iterating after the bus was found (even though you don't do anything and just compare IDs and "continue").