From: Joel Fernandes <joelaf@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
LKML <linux-kernel@vger.kernel.org>,
"Cc: Android Kernel" <kernel-team@android.com>,
Boqun Feng <boqun.feng@gmail.com>,
Byungchul Park <byungchul.park@lge.com>,
Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Glexiner <tglx@linutronix.de>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage
Date: Mon, 6 Aug 2018 17:43:19 -0700 [thread overview]
Message-ID: <CAJWu+oqvpev_EZC38_mi+UNRCxS8GqNVagHyGM4dUjruzKgwgQ@mail.gmail.com> (raw)
In-Reply-To: <20180806155058.5ee875f4@gandalf.local.home>
On Mon, Aug 6, 2018 at 12:50 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> With this patch applied, I'm constantly getting lockdep errors. Instead
> of doing a full revert of the patch, I did this, which makes all those
> errors go away. I may apply this for now, and we can revisit having
> lockdep use the tracepoint code. But since it's currently always
> enabled, I'm thinking of just leaving this as is. The macros are still
> clean from Joel's patch.
>
> Thoughts?
I like your patch. Thanks a lot for doing this.. It keeps most of the
benefits of my patch while avoiding the issues with lockdep. I agree
we can look at the remaining lockdep issue after. There were several
lockdep issues with this patch that I fixed over the the months, but
there's still the one that Masami reported that I believe you're also
seeing. Once I'm back I'll work on figuring that one out.
Could you pull in the fixes to the other issues I posted though? With
that we should be good.
https://lore.kernel.org/patchwork/patch/971104/
https://lore.kernel.org/patchwork/patch/971829/
thanks,
- Joel
next prev parent reply other threads:[~2018-08-07 0:43 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 22:24 [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes
2018-07-30 22:24 ` [PATCH v12 1/3] lockdep: use this_cpu_ptr instead of get_cpu_var stats Joel Fernandes
2018-07-30 22:24 ` [PATCH v12 2/3] tracepoint: Make rcuidle tracepoint callers use SRCU Joel Fernandes
2018-07-30 23:10 ` Steven Rostedt
2018-08-10 15:35 ` Steven Rostedt
2018-08-10 16:32 ` Steven Rostedt
2018-07-30 22:24 ` [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes
2018-08-06 19:50 ` Steven Rostedt
2018-08-07 0:43 ` Joel Fernandes [this message]
2018-08-07 1:43 ` Steven Rostedt
2018-08-07 13:33 ` Joel Fernandes
2018-08-07 13:49 ` Steven Rostedt
2018-08-07 14:10 ` Joel Fernandes
2018-08-07 14:34 ` Steven Rostedt
2018-08-07 14:48 ` Joel Fernandes
2018-08-07 15:09 ` Steven Rostedt
2018-08-07 15:24 ` Joel Fernandes
2018-08-07 23:45 ` Steven Rostedt
2018-08-07 23:54 ` Joel Fernandes
2018-08-08 0:48 ` Steven Rostedt
2018-08-08 1:17 ` Joel Fernandes
2018-08-08 1:55 ` Steven Rostedt
2018-08-08 2:13 ` Joel Fernandes
2018-08-08 2:28 ` Steven Rostedt
2018-08-08 3:44 ` Joel Fernandes
2018-08-08 3:53 ` Joel Fernandes
2018-08-08 5:06 ` Joel Fernandes
2018-08-08 12:46 ` Steven Rostedt
2018-08-08 13:03 ` Paul E. McKenney
2018-08-08 13:07 ` Steven Rostedt
2018-08-08 14:33 ` Paul E. McKenney
2018-08-08 14:49 ` Steven Rostedt
2018-08-08 15:05 ` Paul E. McKenney
2018-08-08 15:23 ` Steven Rostedt
2018-08-08 16:02 ` Paul E. McKenney
2018-08-08 16:24 ` Steven Rostedt
2018-08-08 17:21 ` Paul E. McKenney
2018-08-08 13:00 ` Paul E. McKenney
2018-08-08 14:10 ` Joel Fernandes
2018-08-08 14:49 ` Paul E. McKenney
2018-08-08 19:24 ` Joel Fernandes
2018-08-08 20:18 ` Paul E. McKenney
2018-08-08 22:15 ` Joel Fernandes
2018-08-08 22:47 ` Paul E. McKenney
2018-08-09 12:18 ` joel
2018-08-08 14:27 ` Steven Rostedt
2018-08-08 14:42 ` Paul E. McKenney
2018-08-08 15:27 ` Steven Rostedt
2018-08-08 16:03 ` Paul E. McKenney
2018-08-02 14:55 ` [PATCH v12 0/3] " Masami Hiramatsu
2018-08-03 2:57 ` Joel Fernandes
2018-08-03 7:23 ` Masami Hiramatsu
2018-08-04 4:51 ` Joel Fernandes
2018-08-05 16:46 ` Joel Fernandes
2018-08-06 2:07 ` Masami Hiramatsu
2018-08-06 15:24 ` Joel Fernandes
2018-08-03 7:34 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJWu+oqvpev_EZC38_mi+UNRCxS8GqNVagHyGM4dUjruzKgwgQ@mail.gmail.com \
--to=joelaf@google.com \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.