All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hillf Danton <dhillf@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Daniel J Blueman <daniel@numascale-asia.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Steffen Persvold <sp@numascale.com>
Subject: Re: kswapd craziness round 2
Date: Thu, 21 Feb 2013 20:07:03 +0800	[thread overview]
Message-ID: <CAJd=RBCiYof5rRVK+62OFMw+5F=5rS=qxRYF+OHpuRz895bn4w@mail.gmail.com> (raw)
In-Reply-To: <51254AD2.7000906@suse.cz>

On Thu, Feb 21, 2013 at 6:14 AM, Jiri Slaby <jslaby@suse.cz> wrote:
>>
>> Does Ingo's revert help? https://lkml.org/lkml/2013/2/15/168
>
> Not at all...
>
Then mind taking a try?

--- a/mm/vmscan.c	Thu Feb 21 20:01:02 2013
+++ b/mm/vmscan.c	Thu Feb 21 20:05:58 2013
@@ -1715,7 +1715,7 @@ static void get_scan_count(struct lruvec
 	 * to swap.  Better start now and leave the - probably heavily
 	 * thrashing - remaining file pages alone.
 	 */
-	if (global_reclaim(sc)) {
+	if (global_reclaim(sc) && sc->priority >= DEF_PRIORITY - 2) {
 		free = zone_page_state(zone, NR_FREE_PAGES);
 		if (unlikely(file + free <= high_wmark_pages(zone))) {
 			scan_balance = SCAN_ANON;
@@ -2840,9 +2840,10 @@ out:
 		 * reclaim if they wish.
 		 */
 		if (sc.nr_reclaimed < SWAP_CLUSTER_MAX)
-			order = sc.order = 0;
-
-		goto loop_again;
+			if (order != 0) {
+				sc.order = order = 0;
+				goto loop_again;
+			}
 	}

 	/*
--

  reply	other threads:[~2013-02-21 12:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  6:18 kswapd craziness round 2 Daniel J Blueman
2013-02-18 11:42 ` Hillf Danton
2013-02-18 15:05   ` Daniel J Blueman
2013-02-20 22:14   ` Jiri Slaby
2013-02-21 12:07     ` Hillf Danton [this message]
2013-02-24 21:27       ` Jiri Slaby
2013-02-28 17:02       ` Jiri Slaby
2013-03-01 14:02         ` Hillf Danton
2013-03-07 19:37           ` Jiri Slaby
2013-03-08  6:42             ` Hillf Danton
2013-03-08  6:42               ` Hillf Danton
2013-03-08  7:29               ` Zlatko Calusic
2013-03-08  7:29                 ` Zlatko Calusic
2013-03-08  8:27                 ` Hillf Danton
2013-03-08  8:27                   ` Hillf Danton
2013-03-08 23:21               ` Jiri Slaby
2013-03-08 23:21                 ` Jiri Slaby
2013-03-19 16:59                 ` Pádraig Brady
2013-03-19 16:59                   ` Pádraig Brady
2013-03-20  4:12                   ` Hillf Danton
2013-03-20  4:12                     ` Hillf Danton
2013-03-20  8:39                     ` Jiri Slaby
2013-03-20  8:39                       ` Jiri Slaby
  -- strict thread matches above, loose matches on Subject: below --
2013-02-17 22:02 Jiri Slaby
2013-02-17 22:02 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJd=RBCiYof5rRVK+62OFMw+5F=5rS=qxRYF+OHpuRz895bn4w@mail.gmail.com' \
    --to=dhillf@gmail.com \
    --cc=daniel@numascale-asia.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sp@numascale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.