From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE0DC47094 for ; Thu, 10 Jun 2021 12:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C3F613DF for ; Thu, 10 Jun 2021 12:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbhFJMoU (ORCPT ); Thu, 10 Jun 2021 08:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbhFJMoT (ORCPT ); Thu, 10 Jun 2021 08:44:19 -0400 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F965C0617A6 for ; Thu, 10 Jun 2021 05:42:23 -0700 (PDT) Received: by mail-ua1-x936.google.com with SMTP id n61so1224223uan.2 for ; Thu, 10 Jun 2021 05:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=bWmonaOQtQnoMrqggNjQmbBLp/OFsefkhaXRpT3N30oDxasxyxX5+zHqOhyxg8TwQ1 9WhDWldZuNugQzNq9CRVa79/7odXcgVZfZJpa4jozV3UwwVJh+rViZAq1j+cqvO83+lk Ul0lp34cK0STCoHisDcJwkiJqPEl1W1Jca9Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=WdYejUVdDRY4CX6DcKgPHM87pJrz7l1hzxizyTZbZhtYMopXauj6GiCkVWZI/g7wDv wu9oDu9NV1TZmP14Nb/4lx1aALbR8fzJF5LwDk0IRWsEQWFVeg5SlejWtwJumP0gBG2z MUhRiXw9GunWthUXAswavtAPxIJ2NJWb5vcT+gmJ232wTvHz5sux+XIwT0EdAuOKgJE7 5678GJOBZpxZYEBy6SHLU5K+YsKr/qydgf59m4QErJ5DLCoCdJ0An2/isdsn1+ION8hU FijaTKJHFkapDv9Dzk+URgBNZ/uE8QSvIMORhJAGJAjQNHVLJkS5LeW/Q1saC6dfi6J2 nSYQ== X-Gm-Message-State: AOAM531zFGmSo0O/k20GHZh7c4jk4mFFxpemO7nhXjnQ5rzK2IJh85aT dSB2/J1B1pMT+qNcL5V6bqbWph72zrxi4n4qzwvJWg== X-Google-Smtp-Source: ABdhPJzSnBnKZyOmEQg1Mlk1J3k9vxKYbX0hKrYXjQBdDrHZwFo89gBvp5Cl9ryn+jRW8T0jKkHsp9O4DmV9/7gYf0I= X-Received: by 2002:ab0:2690:: with SMTP id t16mr4105093uao.9.1623328942641; Thu, 10 Jun 2021 05:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20210607144631.8717-1-jack@suse.cz> <20210607145236.31852-12-jack@suse.cz> In-Reply-To: <20210607145236.31852-12-jack@suse.cz> From: Miklos Szeredi Date: Thu, 10 Jun 2021 14:42:12 +0200 Message-ID: Subject: Re: [PATCH 12/14] fuse: Convert to using invalidate_lock To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , CIFS , Ext4 , linux-f2fs-devel@lists.sourceforge.net, linux-mm , linux-xfs , Steve French , Ted Tso , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Miklos Szeredi > Signed-off-by: Jan Kara Reviewed-by: Miklos Szeredi Thanks, Miklos From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0CDC48BD1 for ; Thu, 10 Jun 2021 12:42:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3E97613DF for ; Thu, 10 Jun 2021 12:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3E97613DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=szeredi.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EBCF6B0036; Thu, 10 Jun 2021 08:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19C6E6B006E; Thu, 10 Jun 2021 08:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 021056B0070; Thu, 10 Jun 2021 08:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id C1A186B0036 for ; Thu, 10 Jun 2021 08:42:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 689B4582D for ; Thu, 10 Jun 2021 12:42:24 +0000 (UTC) X-FDA: 78237777408.01.A27CFD0 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf09.hostedemail.com (Postfix) with ESMTP id BA9E06000147 for ; Thu, 10 Jun 2021 12:42:20 +0000 (UTC) Received: by mail-ua1-f52.google.com with SMTP id c10so1222472uan.6 for ; Thu, 10 Jun 2021 05:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=bWmonaOQtQnoMrqggNjQmbBLp/OFsefkhaXRpT3N30oDxasxyxX5+zHqOhyxg8TwQ1 9WhDWldZuNugQzNq9CRVa79/7odXcgVZfZJpa4jozV3UwwVJh+rViZAq1j+cqvO83+lk Ul0lp34cK0STCoHisDcJwkiJqPEl1W1Jca9Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=mFu5xG/qS7TQD+o8JRXzb1JRXQ132okR7spVOZKZq0DQFj+ijthGXPs0W6eEXx1joU ku0217t/8GHRe+UQNo1sbzUr8DgMtKLI7rDsp2OYvcTi8Raz0pz44SmTOtIgTUjvFxRh MdkFamqKrHk3IJJAEuxAB3DkcVPYAsibi3Rz1OnmfqbSx9yMEAB0Bj+rgtIKuFcNMbo7 hjmLuA0bPLdBqgJDdghFzoXGI91ZPGxXeLkwxmvqJ/Enyt78yNd4eIyzxpXR/sERlMJT MdXRMXWdma+4Re83wlu1gSwZDc3DySwgegfru3U+fRPoacv7m5JoxYicNgy/7nghdmw6 oVbg== X-Gm-Message-State: AOAM533tXb5vgWyexpCCbGYabVube6SpMPEIkZ/A9BJ611uJjFZAQG2/ r8cI2MFSGDB19s/lCJ4IREtqSAP6TLpHtJhUD5YyrA== X-Google-Smtp-Source: ABdhPJzSnBnKZyOmEQg1Mlk1J3k9vxKYbX0hKrYXjQBdDrHZwFo89gBvp5Cl9ryn+jRW8T0jKkHsp9O4DmV9/7gYf0I= X-Received: by 2002:ab0:2690:: with SMTP id t16mr4105093uao.9.1623328942641; Thu, 10 Jun 2021 05:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20210607144631.8717-1-jack@suse.cz> <20210607145236.31852-12-jack@suse.cz> In-Reply-To: <20210607145236.31852-12-jack@suse.cz> From: Miklos Szeredi Date: Thu, 10 Jun 2021 14:42:12 +0200 Message-ID: Subject: Re: [PATCH 12/14] fuse: Convert to using invalidate_lock To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , CIFS , Ext4 , linux-f2fs-devel@lists.sourceforge.net, linux-mm , linux-xfs , Steve French , Ted Tso , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf09.hostedemail.com; dkim=none ("invalid DKIM record") header.d=szeredi.hu header.s=google header.b=bWmonaOQ; dmarc=none; spf=pass (imf09.hostedemail.com: domain of miklos@szeredi.hu designates 209.85.222.52 as permitted sender) smtp.mailfrom=miklos@szeredi.hu X-Rspamd-Server: rspam02 X-Stat-Signature: dw7tds5fhc55m19gjqjepgnemembcjxs X-Rspamd-Queue-Id: BA9E06000147 X-HE-Tag: 1623328940-512046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Miklos Szeredi > Signed-off-by: Jan Kara Reviewed-by: Miklos Szeredi Thanks, Miklos From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B197C47094 for ; Thu, 10 Jun 2021 13:40:31 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D58E960FE3; Thu, 10 Jun 2021 13:40:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D58E960FE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=szeredi.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lrKv4-00084v-9A; Thu, 10 Jun 2021 13:40:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKv3-00084o-1J for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Jun 2021 13:40:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=BbxNS6YrWaoR5lgk13C0ZoYLNw F7dlmbfX5+KPN9SNT6tX5g5Yf/MbQiJ500KwPKOoOygD5i61zHb2d0IrJGetAvgY5rNvn0M88cM6D SzZps+b8jjHdC2pIrYByOrsFAtVoJ+vMXZCECzZOnTNHAbdkLlLUEdwgmV8flkLN6dQM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=YuTCynKd0Jo0MMeZWBQldLy0uR iTA2Qiiu5IgaNcuUDOLZ2XS/pHYpDQZOfdYkJM6w5T21oRf5biWrC2QRmcBztmWvh14aNcI61vJta 768pOjUc7nMNtD1vTioZZHteA6peenfjazfepIWQJK8vAj99S2R06iQjnEissDg2RDUw=; Received: from mail-yb1-f175.google.com ([209.85.219.175]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1lrKv0-00054B-0M for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Jun 2021 13:40:27 +0000 Received: by mail-yb1-f175.google.com with SMTP id q21so40790550ybg.8 for ; Thu, 10 Jun 2021 06:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=bWmonaOQtQnoMrqggNjQmbBLp/OFsefkhaXRpT3N30oDxasxyxX5+zHqOhyxg8TwQ1 9WhDWldZuNugQzNq9CRVa79/7odXcgVZfZJpa4jozV3UwwVJh+rViZAq1j+cqvO83+lk Ul0lp34cK0STCoHisDcJwkiJqPEl1W1Jca9Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=RxnTgS9oyuGqX18YQBJjrOvw4FjYNkC3KPWSFp6wSgQIdo1RAJiJry0oWG7xsVm7kH 0VZfyErswPd5xDl8BblZ4Z1Sfezqo7cJ0MiUCelz3AL26+ZDRJ0t5BuQQXQlrqaTLIKl IYTgxp8zeQFWQ89Tb6MMuOqXB0dvcYGmMXxMh9pvJYQNdvg9qb2TA26iU3bG0S0yCddG 8P8aKwcAlyXuVq+EMKQa2kanIf6bCd/aPh3XXZmILB22KkI7HZQ+7XzpQ1Aw4VieoQGJ bTCY75554IzWtbEdoL1G+USCvgB47elp1oBrCN9HP0/ANMB7tDqFE3KLwC1PpyG58IJ8 inXg== X-Gm-Message-State: AOAM530+Z9rDcELYvCdLsDVg7+g4cdTaYIwe81uxIEkxBHz2X64yKwRg RUq75e/Fn7db8cn1dDkQf9t1zeuFk0c3FWn5wxoOPy/V9z/JZQ== X-Google-Smtp-Source: ABdhPJzSnBnKZyOmEQg1Mlk1J3k9vxKYbX0hKrYXjQBdDrHZwFo89gBvp5Cl9ryn+jRW8T0jKkHsp9O4DmV9/7gYf0I= X-Received: by 2002:ab0:2690:: with SMTP id t16mr4105093uao.9.1623328942641; Thu, 10 Jun 2021 05:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20210607144631.8717-1-jack@suse.cz> <20210607145236.31852-12-jack@suse.cz> In-Reply-To: <20210607145236.31852-12-jack@suse.cz> From: Miklos Szeredi Date: Thu, 10 Jun 2021 14:42:12 +0200 Message-ID: To: Jan Kara X-Headers-End: 1lrKv0-00054B-0M Subject: Re: [f2fs-dev] [PATCH 12/14] fuse: Convert to using invalidate_lock X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CIFS , Damien Le Moal , Ext4 , Ted Tso , "Darrick J. Wong" , Jeff Layton , Steve French , Dave Chinner , Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-mm , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , ceph-devel@vger.kernel.org, Johannes Thumshirn , linux-xfs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Miklos Szeredi > Signed-off-by: Jan Kara Reviewed-by: Miklos Szeredi Thanks, Miklos _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel