From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F20DC433FE for ; Fri, 4 Dec 2020 19:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E162122C9C for ; Fri, 4 Dec 2020 19:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730403AbgLDTVa (ORCPT ); Fri, 4 Dec 2020 14:21:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbgLDTV3 (ORCPT ); Fri, 4 Dec 2020 14:21:29 -0500 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 493E5C0613D1 for ; Fri, 4 Dec 2020 11:20:49 -0800 (PST) Received: by mail-vs1-xe43.google.com with SMTP id z16so3870512vsp.5 for ; Fri, 04 Dec 2020 11:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3RfmsOD4R8FThIOERGPH+DqSWdV2gOeuwbTDc0BCACk=; b=ED+Yl2tvlFfU7xMIOOS47zHVQLtV6INZZvh0HH4yw3SWBHzU4MNC4rXbzHM74kG9XR ZbMTZuU01dpnUQoaIPQ4jp4DxhYBqUy6YSa2lSiV5e7KaadOuv9DX5WExV5QLyD1+xVI t7pP0QhkyrRZgM0PgtgIA9asldGrwLJB3gyatruE0iDpoVWVyQWb4WpwEA6OpOjQ7r7W O8/doy3IHvTaswQkkK2DdJdjTY3MHBe7FBbhVTULX0yQuwmsP7d6Lbo/5hthSTlEYqKj eSz+5Qwdv8NWKzfHNTgp97QES+8Y9kdQd2+XsngGpRfAIK3Ac8j2BGZRCemAbfAll7HF NrCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3RfmsOD4R8FThIOERGPH+DqSWdV2gOeuwbTDc0BCACk=; b=TA8gwX22q+y713uTBslLrx/VslN70WLT2vvfd75xwaknsipr/fgAQTp+weNtAC1NOg 2l9rJc+LOyFlwwXMMa903yDRwPi9AQeI7PsSPUfC+suPF8Jr0iclbPylq/zRRpVMp81g tM8gMumAawQgmzqVnDRmaZmYoJbjPEhg0bU6Tuck6HfrWa0JfQwq+wKkLONg5pKqtOqU gZPeH9WV13pi61S/8XaA41XM52XD9cRs8kbnDxuyQpv1ChmFIxQJkih/2RfTBj3kJoqC c8JE8TxBfX3xFp+dgHnNq5COJwpRjmPClTRO+lzcu00jCk8vYbHXonHBuotMXRgvEck4 Ejlw== X-Gm-Message-State: AOAM532xqp80bYAqcky5AcDPxItdz2mQg3J93idFajnt+NigkBIE6WPQ 8Nxc2riD5TqGXNfSi4dOjrMbUBUa23m3hbOtbvY= X-Google-Smtp-Source: ABdhPJwqY8Cz8zt67T3BVJvNnRhGnl8wOKMvKKSfumPMETzn1knT8+JsYs3DxXmbQCcxhs6RK/0aE+HMmFZIhWrNP7o= X-Received: by 2002:a67:d204:: with SMTP id y4mr5725128vsi.60.1607109648459; Fri, 04 Dec 2020 11:20:48 -0800 (PST) MIME-Version: 1.0 References: <20201204035318.332419-1-jim.cromie@gmail.com> <20201204035318.332419-2-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Fri, 4 Dec 2020 12:20:21 -0700 Message-ID: Subject: Re: [RFC PATCH 1/2] drm: RFC add choice to use dynamic debug in drm-debug To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: dri-devel@lists.freedesktop.org, LKML , David Airlie , Jason Baron , Thomas Zimmermann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 8:42 AM Ville Syrj=C3=A4l=C3=A4 wrote: > > On Thu, Dec 03, 2020 at 08:53:17PM -0700, Jim Cromie wrote: > > drm's debug system uses distinct categories of debug messages, mapped > > to bits in drm.debug. Currently, code does a lot of unlikely bit-mask > > checks on drm.debug (in drm_debug_enabled), we can use dynamic debug > > instead, and get all that jump_label goodness. > > whatis jump_label? Sorry, I should have at least capitalized that, and spelled it differently kernel/Makefile 118:obj-$(CONFIG_JUMP_LABEL) +=3D jump_label.o it is the hot-patching substrate underneath it all. static-key, static-call, etc? dynamic-debug uses static-key directly. > > One thing that bugs me about the current drm_dbg() stuff is that > it's a function, and thus we pay the cost of setting up the > arguments even when debugs are not enabled. I played around a bit > with making it a macro again with the unlikely bit check moved > into the macro. That did seem to make some of the asm a bit nicer > where the debug stuff got shoved out the main codepath, but > it did result in a slight net increase in code size. What I didn't > have time to do is check if this has any measurable speed effect > on eg. TEST_ONLY commits. > > And while doing that I started to ponder if we could use something > like the alternate() instruction stuff to patch the code at runtime > in order to turn all those debug checks into nops when debugging > is not enabled. But I couldn't immediately find any generic > infrastructure for it. So now I wonder if this jump_label is something > like that? > this is the droid youre looking for ;-) > > > -- > Ville Syrj=C3=A4l=C3=A4 > Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE02C1B0D8 for ; Mon, 7 Dec 2020 08:57:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F9882312F for ; Mon, 7 Dec 2020 08:57:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F9882312F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80E5089DDF; Mon, 7 Dec 2020 08:56:50 +0000 (UTC) Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73C356E1F5 for ; Fri, 4 Dec 2020 19:20:49 +0000 (UTC) Received: by mail-vs1-xe43.google.com with SMTP id w18so3850797vsk.12 for ; Fri, 04 Dec 2020 11:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3RfmsOD4R8FThIOERGPH+DqSWdV2gOeuwbTDc0BCACk=; b=ED+Yl2tvlFfU7xMIOOS47zHVQLtV6INZZvh0HH4yw3SWBHzU4MNC4rXbzHM74kG9XR ZbMTZuU01dpnUQoaIPQ4jp4DxhYBqUy6YSa2lSiV5e7KaadOuv9DX5WExV5QLyD1+xVI t7pP0QhkyrRZgM0PgtgIA9asldGrwLJB3gyatruE0iDpoVWVyQWb4WpwEA6OpOjQ7r7W O8/doy3IHvTaswQkkK2DdJdjTY3MHBe7FBbhVTULX0yQuwmsP7d6Lbo/5hthSTlEYqKj eSz+5Qwdv8NWKzfHNTgp97QES+8Y9kdQd2+XsngGpRfAIK3Ac8j2BGZRCemAbfAll7HF NrCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3RfmsOD4R8FThIOERGPH+DqSWdV2gOeuwbTDc0BCACk=; b=C6e+FTWl+zYO2tFlJ+PJimJsDn3DK9y8SIVwn8y+DCvwyj/v6AyGZnjmj1ZgMMmn0m prnqi7rFB9HTqE8IotKwzwRnmpRNmotfwzJ8c9dIsvHnDyeezvvpkkPSKDey4XGNUPuK 278GEXfwgJ2JSi6st/g5Kt3hMaf18xNDHuGzOaL1ETkNEuqs4gA+rbjFgtjghpgEt3N0 cs9vn7Rv9nxooC3yJZT7eqRB8bM2MIAD/V5qGLoVY5bBboQfSpC2VeLP/eI0BCtd/TMd jxQ3FKUKDJQAgTdCe4hA5+nGWUwcaTk4FHCKDLEt/0mAH3c9tYKb32/nYWOkpU2HOeOZ wdFA== X-Gm-Message-State: AOAM532dmImwj4Mktbukgegb/eHig67wLgUUNlC8LWMH9vH9zX15Ux7j Cm81jzDn4UHkSTvyMW6rSup4CjVmpk6YOSQO80M= X-Google-Smtp-Source: ABdhPJwqY8Cz8zt67T3BVJvNnRhGnl8wOKMvKKSfumPMETzn1knT8+JsYs3DxXmbQCcxhs6RK/0aE+HMmFZIhWrNP7o= X-Received: by 2002:a67:d204:: with SMTP id y4mr5725128vsi.60.1607109648459; Fri, 04 Dec 2020 11:20:48 -0800 (PST) MIME-Version: 1.0 References: <20201204035318.332419-1-jim.cromie@gmail.com> <20201204035318.332419-2-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Fri, 4 Dec 2020 12:20:21 -0700 Message-ID: Subject: Re: [RFC PATCH 1/2] drm: RFC add choice to use dynamic debug in drm-debug To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= X-Mailman-Approved-At: Mon, 07 Dec 2020 08:56:49 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Thomas Zimmermann , Jason Baron , LKML , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBEZWMgNCwgMjAyMCBhdCA4OjQyIEFNIFZpbGxlIFN5cmrDpGzDpAo8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Cj4gT24gVGh1LCBEZWMgMDMsIDIwMjAgYXQg MDg6NTM6MTdQTSAtMDcwMCwgSmltIENyb21pZSB3cm90ZToKPiA+IGRybSdzIGRlYnVnIHN5c3Rl bSB1c2VzIGRpc3RpbmN0IGNhdGVnb3JpZXMgb2YgZGVidWcgbWVzc2FnZXMsIG1hcHBlZAo+ID4g dG8gYml0cyBpbiBkcm0uZGVidWcuICBDdXJyZW50bHksIGNvZGUgZG9lcyBhIGxvdCBvZiB1bmxp a2VseSBiaXQtbWFzawo+ID4gY2hlY2tzIG9uIGRybS5kZWJ1ZyAoaW4gZHJtX2RlYnVnX2VuYWJs ZWQpLCB3ZSBjYW4gdXNlIGR5bmFtaWMgZGVidWcKPiA+IGluc3RlYWQsIGFuZCBnZXQgYWxsIHRo YXQganVtcF9sYWJlbCBnb29kbmVzcy4KPgo+IHdoYXRpcyBqdW1wX2xhYmVsPwoKU29ycnksIEkg c2hvdWxkIGhhdmUgYXQgbGVhc3QgY2FwaXRhbGl6ZWQgdGhhdCwgYW5kIHNwZWxsZWQgaXQgZGlm ZmVyZW50bHkKCmtlcm5lbC9NYWtlZmlsZQoxMTg6b2JqLSQoQ09ORklHX0pVTVBfTEFCRUwpICs9 IGp1bXBfbGFiZWwubwoKaXQgaXMgdGhlIGhvdC1wYXRjaGluZyBzdWJzdHJhdGUgdW5kZXJuZWF0 aCBpdCBhbGwuCnN0YXRpYy1rZXksIHN0YXRpYy1jYWxsLCBldGM/CmR5bmFtaWMtZGVidWcgdXNl cyBzdGF0aWMta2V5IGRpcmVjdGx5LgoKCgo+Cj4gT25lIHRoaW5nIHRoYXQgYnVncyBtZSBhYm91 dCB0aGUgY3VycmVudCBkcm1fZGJnKCkgc3R1ZmYgaXMgdGhhdAo+IGl0J3MgYSBmdW5jdGlvbiwg YW5kIHRodXMgd2UgcGF5IHRoZSBjb3N0IG9mIHNldHRpbmcgdXAgdGhlCj4gYXJndW1lbnRzIGV2 ZW4gd2hlbiBkZWJ1Z3MgYXJlIG5vdCBlbmFibGVkLiBJIHBsYXllZCBhcm91bmQgYSBiaXQKPiB3 aXRoIG1ha2luZyBpdCBhIG1hY3JvIGFnYWluIHdpdGggdGhlIHVubGlrZWx5IGJpdCBjaGVjayBt b3ZlZAo+IGludG8gdGhlIG1hY3JvLiBUaGF0IGRpZCBzZWVtIHRvIG1ha2Ugc29tZSBvZiB0aGUg YXNtIGEgYml0IG5pY2VyCj4gd2hlcmUgdGhlIGRlYnVnIHN0dWZmIGdvdCBzaG92ZWQgb3V0IHRo ZSBtYWluIGNvZGVwYXRoLCBidXQKPiBpdCBkaWQgcmVzdWx0IGluIGEgc2xpZ2h0IG5ldCBpbmNy ZWFzZSBpbiBjb2RlIHNpemUuIFdoYXQgSSBkaWRuJ3QKPiBoYXZlIHRpbWUgdG8gZG8gaXMgY2hl Y2sgaWYgdGhpcyBoYXMgYW55IG1lYXN1cmFibGUgc3BlZWQgZWZmZWN0Cj4gb24gZWcuIFRFU1Rf T05MWSBjb21taXRzLgo+Cj4gQW5kIHdoaWxlIGRvaW5nIHRoYXQgSSBzdGFydGVkIHRvIHBvbmRl ciBpZiB3ZSBjb3VsZCB1c2Ugc29tZXRoaW5nCj4gbGlrZSB0aGUgYWx0ZXJuYXRlKCkgaW5zdHJ1 Y3Rpb24gc3R1ZmYgdG8gcGF0Y2ggdGhlIGNvZGUgYXQgcnVudGltZQo+IGluIG9yZGVyIHRvIHR1 cm4gYWxsIHRob3NlIGRlYnVnIGNoZWNrcyBpbnRvIG5vcHMgd2hlbiBkZWJ1Z2dpbmcKPiBpcyBu b3QgZW5hYmxlZC4gQnV0IEkgY291bGRuJ3QgaW1tZWRpYXRlbHkgZmluZCBhbnkgZ2VuZXJpYwo+ IGluZnJhc3RydWN0dXJlIGZvciBpdC4gU28gbm93IEkgd29uZGVyIGlmIHRoaXMganVtcF9sYWJl bCBpcyBzb21ldGhpbmcKPiBsaWtlIHRoYXQ/Cj4KCnRoaXMgaXMgdGhlIGRyb2lkIHlvdXJlIGxv b2tpbmcgZm9yIDstKQoKPiA+Cgo+IC0tCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==