All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tomasz Dziendzielski" <tomasz.dziendzielski@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source
Date: Tue, 19 Jan 2021 19:57:15 +0100	[thread overview]
Message-ID: <CAJkqNs0uwQBpRa2F9nMV9gioHP8thYWzem42uhXwgOPO7N+PQA@mail.gmail.com> (raw)
In-Reply-To: <75dd1f1859c454c2f3ddf14707292f5ab444a834.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

>Try checking if the "task" flag is set for "do_patch"
Good idea, thanks! It's working correctly. I can see both 'noexec' and
'task' flags can be set separately, so to make it more general (and make it
work for similar recipes without sources) I will check both 'noexec' and
'task' flags.
I will submit another patchset with suggested change  (see below) and with
another condition check to not affect kernel build.:

diff --git a/scripts/lib/devtool/standard.py
b/scripts/lib/devtool/standard.py
index 8b80fb8bfa..6f4cbbe219 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py

-                if 'noexec' in (d.getVarFlags(task, False) or []):
+                if 'noexec' in (d.getVarFlags(task, False) or []) or
'task' not in (d.getVarFlags(task, False) or []):
...
-        if 'noexec' in (d.getVarFlags('do_patch', False) or []):
+        if not is_kernel_yocto and ('noexec' in (d.getVarFlags('do_patch',
False) or []) or 'task' not in (d.getVarFlags('do_patch', False) or []):

Best regards,
Tomasz Dziendzielski

[-- Attachment #2: Type: text/html, Size: 1371 bytes --]

      reply	other threads:[~2021-01-19 18:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 15:53 [PATCH] devtool: Fix source extraction for gcc shared source Tomasz Dziendzielski
2021-01-19 15:54 ` [OE-core] " Paul Barker
2021-01-19 16:44   ` Tomasz Dziendzielski
2021-01-19 17:49 ` Richard Purdie
2021-01-19 18:05   ` Tomasz Dziendzielski
2021-01-19 18:11     ` Richard Purdie
2021-01-19 18:57       ` Tomasz Dziendzielski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJkqNs0uwQBpRa2F9nMV9gioHP8thYWzem42uhXwgOPO7N+PQA@mail.gmail.com \
    --to=tomasz.dziendzielski@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.