From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DD2C2B9F7 for ; Fri, 28 May 2021 17:56:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 059BD61184 for ; Fri, 28 May 2021 17:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbhE1R5Y (ORCPT ); Fri, 28 May 2021 13:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhE1R5X (ORCPT ); Fri, 28 May 2021 13:57:23 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A14CC061574 for ; Fri, 28 May 2021 10:55:48 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id q21so3028274ybg.8 for ; Fri, 28 May 2021 10:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hn1AVNc60k/8TwFObTTNkXfOUpUDTkTWiwTGW1kuIUU=; b=Ub16L2GhMdVLMZVtbHNALGfFnO7Y4qHNJ7G5VoVVyO7C048lQnw9sLgFKxXneD1pm4 3whHirjGs/rtyaLsNUiLmUQvwFAYx/HQ3o20MAEdEMH+pAEVc37fBHvNIVZHY+KeeMuk UKkTt2v1hd+6u37hBlZqFUdMhY7sl5jQBA40jot0m5zVIG53TZCyg2ROC4sS7FuPeRT+ a+7FoiPRtPHgt+evhmP1vxrJhBRPl+M8u5F6JeKkE1Ip0ZVvj5biJ37gmB+Si+BbRNRs GrRug4UQVv1em3U/1hqN1XwNIygyK9R105W9zozWUx0oNEWJgvcko+UYM4ddzKwOFVeQ Z76A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hn1AVNc60k/8TwFObTTNkXfOUpUDTkTWiwTGW1kuIUU=; b=Acn+B7bjFlWeBJip5dyYjyGpiSFv1tgIBc5DpMFhrys/jcGARk3cIRyjPyAxJhG0Pr pcLu1DFe2i1ugxy8fw74RT0EpZUgu2Ese9a/RazVOJJ4zcUY0j/XrSWGVWQSjMOngYbP tUHaNVIqI2hIcHDb3yYqcghPit51GDCBxT6fcyCAoy3qEh3Ngk7nHS5D3rUrSfhxSwDe Lih9hVvbDXCRXOQIo843XDPcqnU1Aspqf24PU5uHf4oK2OKy/o0PJdfbvWMDkEAyPcA7 4G6iFaK4MDAtZ8iAlo4955zaDka233juowuVL72ikcslc4kJRRbNjoF5NQUshkxeVfBX A+KQ== X-Gm-Message-State: AOAM532zLLo9bYZUcbFEsqA86aooXT59y6FK6YPNKesJNdenYbJLQAGs dK1CXpP5nGfa6/YHFuoNLcztgsh84nR9ghI6VioEkA== X-Google-Smtp-Source: ABdhPJz3AvOBpJ01ewszKXrziEAalSsR4mv0lp3oWBRj4tshjy1MFUSyVSRt8ZfewcieOksB1kvxl0Awj+6U0G+8K80= X-Received: by 2002:a5b:7c5:: with SMTP id t5mr14573508ybq.190.1622224547288; Fri, 28 May 2021 10:55:47 -0700 (PDT) MIME-Version: 1.0 References: <20210428153542.2814175-1-Liam.Howlett@Oracle.com> <20210428153542.2814175-24-Liam.Howlett@Oracle.com> In-Reply-To: <20210428153542.2814175-24-Liam.Howlett@Oracle.com> From: Suren Baghdasaryan Date: Fri, 28 May 2021 10:55:36 -0700 Message-ID: Subject: Re: [PATCH 23/94] radix tree test suite: Add support for kmem_cache_free_bulk To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 8:36 AM Liam Howlett wrote: > > Signed-off-by: Liam R. Howlett > --- > tools/testing/radix-tree/linux.c | 9 +++++++++ > tools/testing/radix-tree/linux/slab.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c > index 93f7de81fbe8..380bbc0a48d6 100644 > --- a/tools/testing/radix-tree/linux.c > +++ b/tools/testing/radix-tree/linux.c > @@ -91,6 +91,15 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp) > pthread_mutex_unlock(&cachep->lock); > } > > +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t size, void **list) > +{ > + if (kmalloc_verbose) > + printk("Bulk free %p[0-%lu]\n", list, size - 1); nit: Printing the address of the "list" is meaningless IMHO unless you output its value in kmem_cache_alloc_bulk, which you do not. I would also suggest combining the patch introducing kmem_cache_alloc_bulk with this one since they seem to be compementary. > + > + for (int i = 0; i < size; i++) > + kmem_cache_free(cachep, list[i]); > +} > + > void *kmalloc(size_t size, gfp_t gfp) > { > void *ret; > diff --git a/tools/testing/radix-tree/linux/slab.h b/tools/testing/radix-tree/linux/slab.h > index 2958830ce4d7..53b79c15b3a2 100644 > --- a/tools/testing/radix-tree/linux/slab.h > +++ b/tools/testing/radix-tree/linux/slab.h > @@ -24,4 +24,5 @@ struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > unsigned int align, unsigned int flags, > void (*ctor)(void *)); > > +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t, void **); > #endif /* SLAB_H */ > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85851C2B9F7 for ; Fri, 28 May 2021 17:55:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 155ED61184 for ; Fri, 28 May 2021 17:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 155ED61184 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31B256B006E; Fri, 28 May 2021 13:55:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1C06B0070; Fri, 28 May 2021 13:55:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 194ED6B0071; Fri, 28 May 2021 13:55:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id D81FA6B006E for ; Fri, 28 May 2021 13:55:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 714D2BBFF for ; Fri, 28 May 2021 17:55:48 +0000 (UTC) X-FDA: 78191392776.08.C324E4F Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf12.hostedemail.com (Postfix) with ESMTP id 00DB8562 for ; Fri, 28 May 2021 17:55:35 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id z38so6670178ybh.5 for ; Fri, 28 May 2021 10:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hn1AVNc60k/8TwFObTTNkXfOUpUDTkTWiwTGW1kuIUU=; b=Ub16L2GhMdVLMZVtbHNALGfFnO7Y4qHNJ7G5VoVVyO7C048lQnw9sLgFKxXneD1pm4 3whHirjGs/rtyaLsNUiLmUQvwFAYx/HQ3o20MAEdEMH+pAEVc37fBHvNIVZHY+KeeMuk UKkTt2v1hd+6u37hBlZqFUdMhY7sl5jQBA40jot0m5zVIG53TZCyg2ROC4sS7FuPeRT+ a+7FoiPRtPHgt+evhmP1vxrJhBRPl+M8u5F6JeKkE1Ip0ZVvj5biJ37gmB+Si+BbRNRs GrRug4UQVv1em3U/1hqN1XwNIygyK9R105W9zozWUx0oNEWJgvcko+UYM4ddzKwOFVeQ Z76A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hn1AVNc60k/8TwFObTTNkXfOUpUDTkTWiwTGW1kuIUU=; b=Fdcr7kXIuvRQZnQHZMV3M16vxNjhZ6firadSGC+vzy7KKwspgvZdjK+Xkn51+hlNiG KxKtlEp+CFRkL9OHIzWxqbu4XmTXQxMfeO7g3a9a8O82G77Z8Y76MnvBZZnYCOyRgN7N 5YsW6ihipOZAJb8OJMSV+OID98bnzqXokiQhzwvt0I0NpaoIlpRrvLez2I6mVYhwElWg Qi7GBk5oCtC6hIY0Iu5IEBrMIMm5QVxVxNgZAzqa/q4pr4YZReSOsE2c4JaoNMFL3w3Q sH+NDeCSgRsyT2N4qcK2M2/KiT7Ezg8ttvnTtML/CoAkHkD1VmZxttAyf3KnCtVgzzeu 0GTg== X-Gm-Message-State: AOAM531qp/ZvJydjnXDTRAStSpCDGNse4mx8TRahPlni+iNVYLqUPo7X duZduZ6iXyt6lUNfSpdAeVJuke1gaQdggTt8tVtfzg== X-Google-Smtp-Source: ABdhPJz3AvOBpJ01ewszKXrziEAalSsR4mv0lp3oWBRj4tshjy1MFUSyVSRt8ZfewcieOksB1kvxl0Awj+6U0G+8K80= X-Received: by 2002:a5b:7c5:: with SMTP id t5mr14573508ybq.190.1622224547288; Fri, 28 May 2021 10:55:47 -0700 (PDT) MIME-Version: 1.0 References: <20210428153542.2814175-1-Liam.Howlett@Oracle.com> <20210428153542.2814175-24-Liam.Howlett@Oracle.com> In-Reply-To: <20210428153542.2814175-24-Liam.Howlett@Oracle.com> From: Suren Baghdasaryan Date: Fri, 28 May 2021 10:55:36 -0700 Message-ID: Subject: Re: [PATCH 23/94] radix tree test suite: Add support for kmem_cache_free_bulk To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=Ub16L2Gh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of surenb@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=surenb@google.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 00DB8562 X-Stat-Signature: xw51xz3ycyptifsiez6o6exc8jy5bujz X-HE-Tag: 1622224535-347768 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 28, 2021 at 8:36 AM Liam Howlett wrote: > > Signed-off-by: Liam R. Howlett > --- > tools/testing/radix-tree/linux.c | 9 +++++++++ > tools/testing/radix-tree/linux/slab.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c > index 93f7de81fbe8..380bbc0a48d6 100644 > --- a/tools/testing/radix-tree/linux.c > +++ b/tools/testing/radix-tree/linux.c > @@ -91,6 +91,15 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp) > pthread_mutex_unlock(&cachep->lock); > } > > +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t size, void **list) > +{ > + if (kmalloc_verbose) > + printk("Bulk free %p[0-%lu]\n", list, size - 1); nit: Printing the address of the "list" is meaningless IMHO unless you output its value in kmem_cache_alloc_bulk, which you do not. I would also suggest combining the patch introducing kmem_cache_alloc_bulk with this one since they seem to be compementary. > + > + for (int i = 0; i < size; i++) > + kmem_cache_free(cachep, list[i]); > +} > + > void *kmalloc(size_t size, gfp_t gfp) > { > void *ret; > diff --git a/tools/testing/radix-tree/linux/slab.h b/tools/testing/radix-tree/linux/slab.h > index 2958830ce4d7..53b79c15b3a2 100644 > --- a/tools/testing/radix-tree/linux/slab.h > +++ b/tools/testing/radix-tree/linux/slab.h > @@ -24,4 +24,5 @@ struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > unsigned int align, unsigned int flags, > void (*ctor)(void *)); > > +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t, void **); > #endif /* SLAB_H */ > -- > 2.30.2 >