All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eddy Petrișor" <eddy.petrisor@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "common/memsize.c: Simplify RAM size detection"
Date: Wed, 10 Feb 2016 11:00:30 +0200	[thread overview]
Message-ID: <CAK0XTWdMAapU59CE=yUzwGDstE6-RzjmtXFXCRoR_VOdfQ=Rjg@mail.gmail.com> (raw)
In-Reply-To: <56BAF2B1.3040507@redhat.com>

2016-02-10 10:20 GMT+02:00 Hans de Goede <hdegoede@redhat.com>:
> Hi,
>
> On 10-02-16 07:11, Eddy Petri?or wrote:
>>
>> Hi Hans,
>>
>> I sent a fixup patch yesterday (I managed somehow to send an outdated
>> patch),
>
>
> Ah I did not notice that one.
>
>> did you try the fixup patch?
>
>
> I just did try it, same results as Hannes the hang is gone, but now
> the RAM size is misdedetected (it detects 2 GiB on a 1 GiB board).
>
> It seems this code was as it was for a reason and that a revert
> of your simplification is probably the best solution.

OK, agreed, that makes sense. My buggy HW (DDR unstable) doesn't help.

I will probably rework the patch and target the v2016.05 release.

  reply	other threads:[~2016-02-10  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 21:38 [U-Boot] [PATCH] Revert "common/memsize.c: Simplify RAM size detection" Hans de Goede
2016-02-10  6:11 ` Eddy Petrișor
2016-02-10  8:20   ` Hans de Goede
2016-02-10  9:00     ` Eddy Petrișor [this message]
2016-02-10  9:36     ` Wolfgang Denk
2016-02-10 13:35 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK0XTWdMAapU59CE=yUzwGDstE6-RzjmtXFXCRoR_VOdfQ=Rjg@mail.gmail.com' \
    --to=eddy.petrisor@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.