From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbbANWRa (ORCPT ); Wed, 14 Jan 2015 17:17:30 -0500 Received: from mail-qg0-f47.google.com ([209.85.192.47]:34915 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbANWR2 (ORCPT ); Wed, 14 Jan 2015 17:17:28 -0500 MIME-Version: 1.0 In-Reply-To: <1421272101-16847-1-git-send-email-dvlasenk@redhat.com> References: <1421272101-16847-1-git-send-email-dvlasenk@redhat.com> From: Denys Vlasenko Date: Wed, 14 Jan 2015 23:17:07 +0100 Message-ID: Subject: Re: [PATCH 01/11] x86: entry_64.S: always allocate complete "struct pt_regs" To: Andy Lutomirski Cc: Linus Torvalds , Oleg Nesterov , Borislav Petkov , "H. Peter Anvin" , Frederic Weisbecker , X86 ML , Will Drewry , Kees Cook , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 14, 2015 at 10:48 PM, Denys Vlasenko wrote: > Macros which manipulate "struct pt_regs" on stack are reworked: > ALLOC_PT_GPREGS_ON_STACK allocates the structure. > SAVE_C_REGS saves to it those registers which are clobbered by C code. > SAVE_EXTRA_REGS saves to it all other registers. > Corresponding RESTORE_* and REMOVE_PT_GPREGS_FROM_STACK macros reverse it. Andy, Please note that this patch set also needs the previously posted patch: [PATCH 3/4] x86: open-code register save/restore in trace_hardirqs thunks which is not present in your tree - otherwise arch/x86/lib/thunk_64.S will not compile (no SAVE_ARGS anymore). -- vda