From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com ([210.131.2.80]:44996 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbeIBV3l (ORCPT ); Sun, 2 Sep 2018 17:29:41 -0400 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (authenticated) by conssluserg-01.nifty.com with ESMTP id w82HD6ci002057 for ; Mon, 3 Sep 2018 02:13:07 +0900 Received: by mail-ua1-f47.google.com with SMTP id r15-v6so11615231uao.1 for ; Sun, 02 Sep 2018 10:13:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5B8563A702000078001E2A82@prv1-mh.provo.novell.com> References: <5B8563A702000078001E2A82@prv1-mh.provo.novell.com> From: Masahiro Yamada Date: Mon, 3 Sep 2018 02:12:25 +0900 Message-ID: Subject: Re: [PATCH] kallsyms: reduce size a little on 64-bit Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Jan Beulich Cc: Linux Kbuild mailing list , Michal Marek Hi. 2018-08-29 0:00 GMT+09:00 Jan Beulich : > Both kallsyms_num_syms and kallsyms_markers[] don't really need to use > unsigned long as their (base) types; unsigned int fully suffices. > > Signed-off-by: Jan Beulich > --- > --- 4.19-rc1/scripts/kallsyms.c > +++ 4.19-rc1-kallsyms-reduce-size/scripts/kallsyms.c > @@ -182,6 +182,8 @@ static int symbol_in_range(struct sym_en > for (i = 0; i < entries; ++i) { > ar = &ranges[i]; > > + if (!ar->end) > + continue; > if (s->addr >= ar->start && s->addr <= ar->end) > return 1; > } What is this hunk doing? At least, I cannot understand it from the patch description. -- Best Regards Masahiro Yamada