Re: [PATCH] checksyscalls: ignore -Wunused-macros

From: Masahiro Yamada <masahiroy@kernel.org>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	clang-built-linux <llvm@lists.linux.dev>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] checksyscalls: ignore -Wunused-macros
Date: Sat, 30 Apr 2022 02:02:24 +0900	[thread overview]
Message-ID: <CAK7LNARL+_amg-6RN9W+P9n8KuWqobpWrvo6gXxRphxj+=OU7Q@mail.gmail.com> (raw)
In-Reply-To: <20220422151725.1336997-1-mailhol.vincent@wanadoo.fr>

On Sat, Apr 23, 2022 at 12:18 AM Vincent Mailhol
<mailhol.vincent@wanadoo.fr> wrote:
>
> The macros defined in this file are for testing only and are purposely
> not used. When compiled with W=2, both gcc and clang yield some
> -Wunused-macros warnings. Ignore them.
>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---

Applied to linux-kbuild (only the second hunk)
Thanks.

The current check is not nice,
but this does not hurt.

>  scripts/checksyscalls.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index 9dbab13329fa..cde15f22ec98 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -255,6 +255,7 @@ cat << EOF
>  /* 64-bit ports never needed these, and new 32-bit ports can use statx */
>  #define __IGNORE_fstat64
>  #define __IGNORE_fstatat64
> +
>  EOF
>  }

Noise.
I dropped it.

>
> @@ -268,4 +269,4 @@ syscall_list() {
>  }
>
>  (ignore_list && syscall_list $(dirname $0)/../arch/x86/entry/syscalls/syscall_32.tbl) | \
> -$* -Wno-error -E -x c - > /dev/null
> +$* -Wno-error -Wno-unused-macros -E -x c - > /dev/null
> --
> 2.35.1
>

-- 
Best Regards
Masahiro Yamada