From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F89C4332E for ; Thu, 11 Mar 2021 09:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C2F164FB9 for ; Thu, 11 Mar 2021 09:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232003AbhCKJP2 (ORCPT ); Thu, 11 Mar 2021 04:15:28 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:36025 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbhCKJPM (ORCPT ); Thu, 11 Mar 2021 04:15:12 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MFbFW-1lWvnJ0PaY-00H7e9; Thu, 11 Mar 2021 10:15:07 +0100 Received: by mail-ot1-f53.google.com with SMTP id 75so854357otn.4; Thu, 11 Mar 2021 01:15:06 -0800 (PST) X-Gm-Message-State: AOAM530eVF7rVrpAp1XLvQIrseRQla+swzeBKntkJBil4am9F6BNaHgT /7lc/bi2WdFhGObsvTlTFukx3xklGp4XhWG4Fm0= X-Google-Smtp-Source: ABdhPJyn+biUFqeUpWbgYz+onSoY1lB5lZXnaVdOJ59ivfe6fWw6B/LYP9dm97k0WNF1I7ZVkGTZlALTwC9lFjwxZew= X-Received: by 2002:a05:6830:14c1:: with SMTP id t1mr6129948otq.305.1615454105254; Thu, 11 Mar 2021 01:15:05 -0800 (PST) MIME-Version: 1.0 References: <20210310083327.480837-1-krzysztof.kozlowski@canonical.com> <20210310083840.481615-1-krzysztof.kozlowski@canonical.com> <20210310094527.GA701493@dell> <35c39c81-08e4-24c8-f683-2fa7a7ea71de@redhat.com> <1c06cb74-f0b0-66e5-a594-ed1ee9bc876e@canonical.com> <52d0489f-0f77-76a2-3269-e3004c6b6c07@canonical.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 11 Mar 2021 10:14:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64 To: Krzysztof Kozlowski List-Id: Cc: Tom Rix , Lee Jones , Catalin Marinas , Will Deacon , Dinh Nguyen , Rob Herring , Michael Turquette , Stephen Boyd , Moritz Fischer , Linux ARM , "linux-kernel@vger.kernel.org" , DTML , linux-clk , linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, Networking , linux-stm32@st-md-mailman.stormreply.com, arm-soc , SoC Team , Olof Johansson Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:8zSo19FEMGDxyiVQDBPRPGNk7oUpBJKvj23wAA3LeoGeGTVaVDe tYcAtEWJuc6QF3xHchWKOFHw7SzdIyvsUGzwG5ZCAIbpfSiEs2I44sZv8Ig0uLr7MILLENl cggEdUK03qWlQ/08UCGbvsKoo6DI2tigOl0tTfxiLh2W3CnAAeAKnlFxyt1SxNWb91t9oNT f3uj0KvErM5ZZx+1XApng== X-UI-Out-Filterresults: notjunk:1;V03:K0:DHa3uyTr8Bg=:mYAf3HuyZSpvNDQzaYFPIa LQ8jH4G5xwF5IsG18LSCUNEXu4cXgmL7HkSnx6t4Odmq50eV26cIJzOSX95EuRoTU568WFmVF 6D6D2deAwUPjNAd5o/5141PGlP5tMgZPA3BihdFgV9Vw8oifzBng1y8RuPF4IX6cUvqY5NNbz en5TQeAfMSBlKae749fUXQxsregl6IgMbfo+qesr2t5g5x2bCVIUzGqMysf6XNbekDVasEP3g 6EXFmth3Dl/KzQzYt3UXUELR8LXIo7HFiARyafcLr85kuYQpClWDo5ZRL1uOd+ggzsJb/7YIE CGe/BYpm/a3+KFbtnRLNP15PnpWixRxwkjNUvGXUaeCU9viIXWzITSL9ZLlZatpM1k3BK4VZp gadboAk6GmkTmKrcXZfqvdunIX95jT0D0bli/LjuuMhmXSPV40LWZHonSaELFmzWfjcBHMIJ5 z3Fq8/5O8dgcvuQ3hGKZOMoL+YW/IWvOOEsxT4sU+CK9ihrHpjVf/eIrZ8h4RNFNvXWG6gPgJ M+CdNro9r1nbTqwf74QTm4hvH8nIJCY5WcW0ZvCL+Ii/J7pF2RXZfOlA/V0c0xtqA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski wrote: > On 10/03/2021 17:42, Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski > > wrote: > >> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: > >>> This edac Altera driver is very weird... it uses the same compatible > >>> differently depending whether this is 32-bit or 64-bit (e.g. Stratix > >>> 10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we > >>> have two. It's quite a new code (2019 from Intel), not some ancient > >>> legacy, so it should never have been accepted... > >> > >> Oh, it's not that horrible as it sounds. They actually have different > >> compatibles for edac driver with these differences (e.g. in interrupts). > >> They just do not use them and instead check for the basic (common?) > >> compatible and architecture... Anyway without testing I am not the > >> person to fix the edac driver. > > > > Ok, This should be fixed properly as you describe, but as a quick hack > > it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT > > instead of CONFIG_ARCH_STRATIX10 during the rename of the config > > symbol. > > This would work. The trouble with renaming ARCH_SOCFPGA into > ARCH_INTEL_SOCFPGA is that still SOCFPGA will appear in many other > Kconfig symbols or even directory paths. > > Let me use ARCH_INTEL_SOCFPGA for 64bit here and renaming of 32bit a > little bit later. Maybe you can introduce a hidden 'ARCH_INTEL_SOCFPGA' option first and select that from both the 32-bit and the 64-bit platforms in the first step. That should decouple the cleanups, so you can change the drivers to (only) 'depends on ARCH_INTEL_SOCFPGA' before removing the other names. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E591CC433DB for ; Thu, 11 Mar 2021 09:15:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 97E1B64FB8; Thu, 11 Mar 2021 09:15:12 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9966A64E69; Thu, 11 Mar 2021 09:15:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9966A64E69 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=arnd@arndb.de Received: from mail-ot1-f43.google.com ([209.85.210.43]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MrQN5-1m7vJ60vSB-00oVJ9; Thu, 11 Mar 2021 10:15:07 +0100 Received: by mail-ot1-f43.google.com with SMTP id t16so860419ott.3; Thu, 11 Mar 2021 01:15:06 -0800 (PST) X-Gm-Message-State: AOAM533I95g3qKnJGpU2/swNr0GTQHyFDxiytcfzUNPZSP3OEhwVL+jz e4tgxIFIkiaAIEJcQ6YuoB0efMjC+MzcQR1cDdw= X-Google-Smtp-Source: ABdhPJyn+biUFqeUpWbgYz+onSoY1lB5lZXnaVdOJ59ivfe6fWw6B/LYP9dm97k0WNF1I7ZVkGTZlALTwC9lFjwxZew= X-Received: by 2002:a05:6830:14c1:: with SMTP id t1mr6129948otq.305.1615454105254; Thu, 11 Mar 2021 01:15:05 -0800 (PST) MIME-Version: 1.0 References: <20210310083327.480837-1-krzysztof.kozlowski@canonical.com> <20210310083840.481615-1-krzysztof.kozlowski@canonical.com> <20210310094527.GA701493@dell> <35c39c81-08e4-24c8-f683-2fa7a7ea71de@redhat.com> <1c06cb74-f0b0-66e5-a594-ed1ee9bc876e@canonical.com> <52d0489f-0f77-76a2-3269-e3004c6b6c07@canonical.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 11 Mar 2021 10:14:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64 To: Krzysztof Kozlowski List-Id: Cc: Tom Rix , Lee Jones , Catalin Marinas , Will Deacon , Dinh Nguyen , Rob Herring , Michael Turquette , Stephen Boyd , Moritz Fischer , Linux ARM , "linux-kernel@vger.kernel.org" , DTML , linux-clk , linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, Networking , linux-stm32@st-md-mailman.stormreply.com, arm-soc , SoC Team , Olof Johansson Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:QJkSDiV1wbCmdeUEnO+jqRlmB3Yhbfg9R08Abx3GOrE3sc4Bi/e +hBiHQhr18xcfmxVrHwsk+HgtGDc5qS3QCqyl5bfgoIxkcyoT3RHPQKCNT7zXTA4+Hv3GS2 MqE6tnYVkUBQoSDsiDZhCBv8YVwzyMf+apBzx3cJ47igL6JPNCscgBHjbCkLjbSLzAots+s gUv423ZfVV2o3ecSfVQBg== X-UI-Out-Filterresults: notjunk:1;V03:K0:J4FEMRqtu/A=:GT/969kV8lASh5iPiCI1I6 QCSRcAcyALiu9vGrk3P8QXTKfaDJXVrG7NMsWVuiCwlmbbXy33OP9LI/BthKD4kZiuTqZbqZO EmggUQwwOhAsbK02EJ52+CFQPPMX4gS7JBhcioODUka4qxXYn6Z4rO8U1GhbsOvImNL//gwmC /PsKkJK9g5CqRH5bwld+ejrBps2d8SyFa54fLz2UzP+sOFVxdyWvkFNkoFV39kpz35ok4K1AI 19Z1a3lEsZKAN0Pmg0dEWsdEGn9oDN9g/fqTQ++hFFn52zc6Le7rPG1UbCGF0jw+bka6r6vj2 /Km8kyW6RXOLoI/+yArqutBcbl9cgX1JXqoS4NysXVpkC5UUJqZXVpOE7gifmfOUpl10Rrmu9 pRdVRyBj+38jI6Y/6HaCLnVI785nFClc7y2nMihEMF53/w9dBsKYKTg8ErcqiS1T5WfcubVe4 T9d6TjOvLqagXalplPlHkIYQj7elSGtEKWD224Ly1xIbkB1S1+fx1hdqyXUv8eRjsO5KRflIL TMLBtmV8iIbCReMC9E5pUWP30+GVtyOiI93MLShaEP0zx0VYRIcoCQXPsJT02ujKw== On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski wrote: > On 10/03/2021 17:42, Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski > > wrote: > >> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: > >>> This edac Altera driver is very weird... it uses the same compatible > >>> differently depending whether this is 32-bit or 64-bit (e.g. Stratix > >>> 10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we > >>> have two. It's quite a new code (2019 from Intel), not some ancient > >>> legacy, so it should never have been accepted... > >> > >> Oh, it's not that horrible as it sounds. They actually have different > >> compatibles for edac driver with these differences (e.g. in interrupts). > >> They just do not use them and instead check for the basic (common?) > >> compatible and architecture... Anyway without testing I am not the > >> person to fix the edac driver. > > > > Ok, This should be fixed properly as you describe, but as a quick hack > > it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT > > instead of CONFIG_ARCH_STRATIX10 during the rename of the config > > symbol. > > This would work. The trouble with renaming ARCH_SOCFPGA into > ARCH_INTEL_SOCFPGA is that still SOCFPGA will appear in many other > Kconfig symbols or even directory paths. > > Let me use ARCH_INTEL_SOCFPGA for 64bit here and renaming of 32bit a > little bit later. Maybe you can introduce a hidden 'ARCH_INTEL_SOCFPGA' option first and select that from both the 32-bit and the 64-bit platforms in the first step. That should decouple the cleanups, so you can change the drivers to (only) 'depends on ARCH_INTEL_SOCFPGA' before removing the other names. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 362C4C433DB for ; Thu, 11 Mar 2021 09:17:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E6CD64E69 for ; Thu, 11 Mar 2021 09:17:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E6CD64E69 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sFIvl21OJFRU2TbMOiPeBOUpN/503FN85iKrZ8i9TU4=; b=SvCSQSYlbQ4SvnU1hrkSqrG8g QR4uJU3ZsPFRvw+lQxbQui0EdHfTU0bf5WbqrxYwGdcGdA8izV+CVm1iRz66I2RRvJUp2gJCYdPwZ M3vBDaVTA8Po3rOw0W6diSCQqfUfTjFmARUzohQMUn1koZkS9zoHSkhbdsHNnm2qT9xS/j1VNC5q/ RLdladUnqlHox0lNG/mfGAUTw2kROC6YzEkuztat8fvODPzjjMnH3fe8DdAziazUS33h+FCaO6ifQ lF+xBAlnpk1kqe2GxQYn4sjtIvU+OkzcvpWzLxQfXJAWigoRmmkHZ0bwl2hUbH5hTzRgWmqwXPz+B 1QURfjKXA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKHPV-008jLp-9a; Thu, 11 Mar 2021 09:15:13 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKHPS-008jL7-An for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 09:15:12 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MKMIR-1l1lsz20ch-00Lqgg for ; Thu, 11 Mar 2021 10:15:06 +0100 Received: by mail-ot1-f52.google.com with SMTP id 75so854356otn.4 for ; Thu, 11 Mar 2021 01:15:06 -0800 (PST) X-Gm-Message-State: AOAM531A+VUW5SGohv2l6aIQaMC8b5X5nRTeRD/8XxA92mqy5Mycavl1 amD4sZtiJcETE+WbC99Yg9Fi7+EMtG64Np7fJFc= X-Google-Smtp-Source: ABdhPJyn+biUFqeUpWbgYz+onSoY1lB5lZXnaVdOJ59ivfe6fWw6B/LYP9dm97k0WNF1I7ZVkGTZlALTwC9lFjwxZew= X-Received: by 2002:a05:6830:14c1:: with SMTP id t1mr6129948otq.305.1615454105254; Thu, 11 Mar 2021 01:15:05 -0800 (PST) MIME-Version: 1.0 References: <20210310083327.480837-1-krzysztof.kozlowski@canonical.com> <20210310083840.481615-1-krzysztof.kozlowski@canonical.com> <20210310094527.GA701493@dell> <35c39c81-08e4-24c8-f683-2fa7a7ea71de@redhat.com> <1c06cb74-f0b0-66e5-a594-ed1ee9bc876e@canonical.com> <52d0489f-0f77-76a2-3269-e3004c6b6c07@canonical.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 11 Mar 2021 10:14:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64 To: Krzysztof Kozlowski List-Id: Cc: Tom Rix , Lee Jones , Catalin Marinas , Will Deacon , Dinh Nguyen , Rob Herring , Michael Turquette , Stephen Boyd , Moritz Fischer , Linux ARM , "linux-kernel@vger.kernel.org" , DTML , linux-clk , linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, Networking , linux-stm32@st-md-mailman.stormreply.com, arm-soc , SoC Team , Olof Johansson X-Provags-ID: V03:K1:D58NCdJIrb98WJTdix30Bi4AMyWPJCbXg2Jx6XAa/CjZcMzpD5i mptJUF59bie75XSEGNEuKdpaa2pVp+gKL1SrZisss2YY8sEhoOxGB5SpnooEZQ7VuVut7G5 ICgPfEUmle1JcPANIGje2rUejEt692R8cpws/dHcnjGdeTSjDX+Q3+ywnqp61jp7V9hdYlO PEoi2NGYITPzHniTVY7Vw== X-UI-Out-Filterresults: notjunk:1;V03:K0:9qNLf8FqpI8=:AwYfWNJz4XYQucgxDeyaDO RchblNtoeu+iau08MHLWY8tx86VcrOGB3UnJnNXXvPw9VhVsCSMfyrakonwyBhSnbRCJalzPj HxP8eyWzX8Ng7nhCfw1WJUPNm7WwyzsGds0PtEMfwJBRUx3raeKBY9hHaUp6uTsTdL9bm7Tcy ahyMyLclMmk4Khi0sR1WGMJHCRNlZBWp3wvnniUBFYO9Lj05SNkSW/HuKUeOvpY6BR9npQNnU SWpPXzc3jSwKifEbEC1KSdhInlxHYXcNBQ3eaXB6pJb6I66ids26JH4IhbV2M0U1zkksZTKlz g2FymqQZcsxKGoqiS4FeI8OQeVkP+AE83TSNNGblCiPOb5B2Ro8Tgus/JE7UVan+iAO/w1TS2 Orq/LsS2N6Y9kIIvFY3Dq2Vm8ECg/rguOJ2urtpU0RcBr+cBaKrOAX7XgNDTZDBemIOq9zCJt BKWvrqkM4+RCs1pOfMVWuNLOlPk5rWnIjLY+Veg/pxIxo4jKc0xy5bEFMLXF+Zz5pHwvQqr/q /A2skGe8bPRTvxAmVqio58X9OFqIneK8FyMF7/okgw8Jp2mHCsD+pksxXyLMJuX3A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_091510_508314_36A67F20 X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210311091449.2YNJ4HqOohQnovPYIJCYyws5vmd9wD0vvbo8yyaE9ow@z> On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski wrote: > On 10/03/2021 17:42, Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski > > wrote: > >> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: > >>> This edac Altera driver is very weird... it uses the same compatible > >>> differently depending whether this is 32-bit or 64-bit (e.g. Stratix > >>> 10)! On ARMv7 the compatible means for example one IRQ... On ARMv8, we > >>> have two. It's quite a new code (2019 from Intel), not some ancient > >>> legacy, so it should never have been accepted... > >> > >> Oh, it's not that horrible as it sounds. They actually have different > >> compatibles for edac driver with these differences (e.g. in interrupts). > >> They just do not use them and instead check for the basic (common?) > >> compatible and architecture... Anyway without testing I am not the > >> person to fix the edac driver. > > > > Ok, This should be fixed properly as you describe, but as a quick hack > > it wouldn't be hard to just change the #ifdef to check for CONFIG_64BIT > > instead of CONFIG_ARCH_STRATIX10 during the rename of the config > > symbol. > > This would work. The trouble with renaming ARCH_SOCFPGA into > ARCH_INTEL_SOCFPGA is that still SOCFPGA will appear in many other > Kconfig symbols or even directory paths. > > Let me use ARCH_INTEL_SOCFPGA for 64bit here and renaming of 32bit a > little bit later. Maybe you can introduce a hidden 'ARCH_INTEL_SOCFPGA' option first and select that from both the 32-bit and the 64-bit platforms in the first step. That should decouple the cleanups, so you can change the drivers to (only) 'depends on ARCH_INTEL_SOCFPGA' before removing the other names. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel