From: Arnd Bergmann <arnd@arndb.de>
To: Borislav Petkov <bp@suse.de>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
m.mizuma@jp.fujitsu.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baoquan He <bhe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-tip-commits@vger.kernel.org, lkft-triage@lists.linaro.org
Subject: Re: [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error
Date: Mon, 8 Oct 2018 15:48:28 +0200 [thread overview]
Message-ID: <CAK8P3a3Lek2NryUqFZGxSSG2PZD3McS7bezK9Ur3AAX2v6=mgQ@mail.gmail.com> (raw)
In-Reply-To: <20181008130106.GE6490@zn.tnic>
On Mon, Oct 8, 2018 at 3:01 PM Borislav Petkov <bp@suse.de> wrote:
>
> On Mon, Oct 08, 2018 at 04:33:29PM +0530, Naresh Kamboju wrote:
> > Linux next build for arm64 failed due to
> > numa.c:34:10: fatal error: asm/kaslr.h: No such file or directory
>
> Thanks for letting me know, I guess we could fix that with a weak
> function:
>
> +/* To be overridden by architectures */
> +void __init __weak kaslr_check_padding(void) { }
> +
> int __init acpi_numa_init(void)
> {
> int cnt = 0;
>
I think __weak functions are too fragile, when you do this and it
turns out that another architecture does need to do something,
you won't ever get any indication of it.
If we know that arm64 doesn't need to do anything here, just
add an arch/arm64/include/asm/kaslr.h with an empty function
there.
Arnd
next prev parent reply other threads:[~2018-10-08 13:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 14:08 [PATCH v5 0/3] Add a kernel parameter to change the padding size for KASLR Masayoshi Mizuma
2018-10-01 14:08 ` [PATCH v5 1/3] x86/mm: Add a kernel parameter to change the padding used for the physical memory mapping Masayoshi Mizuma
2018-10-02 10:18 ` [tip:x86/boot] " tip-bot for Masayoshi Mizuma
2018-10-01 14:08 ` [PATCH v5 2/3] ACPI / NUMA: Add warning message if the padding size for KASLR is not enough Masayoshi Mizuma
2018-10-02 10:18 ` [tip:x86/boot] ACPI/NUMA: " tip-bot for Masayoshi Mizuma
2018-10-02 15:05 ` Borislav Petkov
2018-10-02 21:19 ` Masayoshi Mizuma
2018-10-03 10:58 ` Masayoshi Mizuma
2018-10-03 12:34 ` Peter Zijlstra
2018-10-03 12:48 ` Borislav Petkov
2018-10-03 13:02 ` Masayoshi Mizuma
2018-10-03 14:21 ` [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error tip-bot for Peter Zijlstra (Intel)
2018-10-08 11:03 ` Naresh Kamboju
2018-10-08 13:01 ` Borislav Petkov
2018-10-08 13:48 ` Arnd Bergmann [this message]
2018-10-08 14:10 ` Borislav Petkov
2018-10-09 10:39 ` tip-bot for Peter Zijlstra (Intel)
2018-10-01 14:08 ` [PATCH v5 3/3] docs: kernel-parameters.txt: document rand_mem_physical_padding Masayoshi Mizuma
2018-10-02 10:19 ` [tip:x86/boot] Documentation/kernel-parameters.txt: Document rand_mem_physical_padding= tip-bot for Masayoshi Mizuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3Lek2NryUqFZGxSSG2PZD3McS7bezK9Ur3AAX2v6=mgQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mingo@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.