All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: SoC Team <soc@kernel.org>, arm-soc <arm@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: dir685: Drop spi-cpol from the display
Date: Mon, 16 Sep 2019 16:31:49 +0200	[thread overview]
Message-ID: <CAK8P3a3p7B3DP+yYrmGSAYORLESisPtawUruVQu0xpdBqY_n5A@mail.gmail.com> (raw)
In-Reply-To: <20190915135444.11066-1-linus.walleij@linaro.org>

On Sun, Sep 15, 2019 at 3:55 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> The D-Link DIR-685 had its clock polarity set as active
> low using the special SPI "spi-cpol" property.
>
> This is not correct: the datasheet clearly states:
> "Fix SCL to GND level when not in use" which is
> indicative that this line is active high.
>
> After a recent fix making the GPIO-based SPI driver
> force the clock line de-asserted at the beginning of
> each SPI transaction this reared its ugly head: now
> de-asserted was taken to mean the line should be
> driven high, but it should be driven low.
>
> Fix this up in the DTS file and the display works again.
>
> Cc: Mark Brown <broonie@kernel.org>
> Fixes: 2922d1cc1696 ("spi: gpio: Add SPI_MASTER_GPIO_SS flag")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: please apply this directly to fixes if
> you're OK with the patch.


As the merge window is now open, I just applied this to
the 'arm/late' branch.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-09-16 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-15 13:54 [PATCH] ARM: dts: dir685: Drop spi-cpol from the display Linus Walleij
2019-09-16 14:31 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3p7B3DP+yYrmGSAYORLESisPtawUruVQu0xpdBqY_n5A@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.