From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574EBC433EF for ; Wed, 25 May 2022 15:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245292AbiEYPqd (ORCPT ); Wed, 25 May 2022 11:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245258AbiEYPqa (ORCPT ); Wed, 25 May 2022 11:46:30 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8D7AF31F for ; Wed, 25 May 2022 08:46:27 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id p5-20020a1c2905000000b003970dd5404dso3610590wmp.0 for ; Wed, 25 May 2022 08:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UrTCiIB5+imBAeHHe5Yk2P2e1nFNoP+klKZAhqbPDdA=; b=MqPIurhFVqpa+pBM1vNQS6bUBZWcTHP2YxERwDnH+bQfrSJK2/72G3Xj7gT+UEioGy thWYm7nOuZQUFNxIv2huTTw/x+VekSpTufiYFUFRGkawxOrxefVaDTY1BSz5YzKXNb3N N68WwPk1+UqgTIjKN5dveLZ8D1OuV7Beewa2kxUojacU7Bp2iSArTdwBToEwZEZGd4Vj mNe2f/owRoeJLfYJRHYnmYyxZRT+hFbQiGMJHYcMVz4o5iqcWa+fTys9HDmTxnnRF79m YZdblvApQE3X8Sz+8/wuOXm/kqKvRy3tyjhXPvV2Tr51KqrC0DPWM7HLycywFd//eT++ 8jkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UrTCiIB5+imBAeHHe5Yk2P2e1nFNoP+klKZAhqbPDdA=; b=diPmBZowykfAsN4M1yAw4qGV/58DeuTB1fd/LR7SBV4Z/3UlUEblbwPKP+zQRyKVpy 7StK3QW74ErSKQC4z+jLJAOSezkuhdO6yEeBCCqJPXuACeBeXNFbvXIdyn/fu21SDG5f 4NsRgv0Ld2xjto+Rdh2rX8PC61rKr6F7ZKogzjXMopEyjKrPK4V/66gqLF7J5azG+Iv3 XDN9RWN8MW7pgoTHqRUbqBvSsAuAwXjc8nMlMDssgg1V93qz3C8DTBx9wsAwKnn+OntQ wEcjk+b6EBxiWXy+v1Isg/yJL2DIqftnVVQ9JExJiXEKCTsx9UcGhKsNLZb3ZZ6lGzf0 WvcA== X-Gm-Message-State: AOAM531MqCHr/ehD+9CDnOins10i0CClMphQ/OFt60HvpiXza0+FYESx 5N/OwRu5YcvYB0/pO4vsq5Er8eP/CUhJeVzQMf/jfA== X-Google-Smtp-Source: ABdhPJwMCeE2M2oBeMoCYDG8p7UZtY8gBrM+hDCF+s5vsXn/s+B7NoTCVj2dK00lSgGxLjxe2HR3aykRV/KV+QWzz/s= X-Received: by 2002:a1c:e903:0:b0:397:36b8:795a with SMTP id q3-20020a1ce903000000b0039736b8795amr9116951wmc.98.1653493586128; Wed, 25 May 2022 08:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-4-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Wed, 25 May 2022 08:46:15 -0700 Message-ID: Subject: Re: [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding To: Arnd Bergmann Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Arnd, On Wed, Apr 6, 2022 at 11:31 PM Arnd Bergmann wrote: > > On Thu, Apr 7, 2022 at 1:36 AM Brad Larson wrote: > > > > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > @@ -19,10 +19,12 @@ properties: > > - enum: > > - microchip,mpfs-sd4hc > > - socionext,uniphier-sd4hc > > + - pensando,elba-sd4hc > > - const: cdns,sd4hc > > > > reg: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 > > > > Shouldn't the binding describe what the register areas are? If there > is only one of them, it is fairly clear, but when you have the choice > between one and two, it gets ambiguous, and there is a risk that > another SoC might have a different register area in the second entry, > making it incompatible. Thanks for the review. Changing this to allOf:if:then in updated patchset. The second item is particular to Elba SoC. Regards, Brad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83FD8C433F5 for ; Wed, 25 May 2022 15:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pVoXjlv6jV5BHTJyJnYtpIUqFWD8ZGer8WjidLfzfzE=; b=GeSUVrJCW/4OID FXYzRW/iN/yj/cNy6cmLcja11poFTLcvSdplq5axqKx7sD9/36QmMgiZvlG98WDMjNJ8EnHM2XA+A st6nP/OJU2AvErWNZ3yPDuTXCEw2cyLmGuP3+fLcJnOTkhHcSumP2njq8fqKlZGBwlG4Z7WSvDT4Y Xu7VsAyvkRK4D6gmWUllJYxGDbJdRxcEUAGfC1HNmjZlAynmAgbEsJZgZahLY79QfZkGlZgPSGpAe Rmm1i5KpMgWbYo/WyoAnaa1fcFnL7lmCjEH+UgDpQKNLUnY6x8cQrFxbMyFUFvhOMChibK6KPDWP/ ngAgaxHo3HYYJ6Cc+JwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nttDV-00BeXe-CY; Wed, 25 May 2022 15:46:33 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nttDS-00BeV7-2Q for linux-arm-kernel@lists.infradead.org; Wed, 25 May 2022 15:46:31 +0000 Received: by mail-wm1-x329.google.com with SMTP id o29-20020a05600c511d00b00397697f172dso1299117wms.0 for ; Wed, 25 May 2022 08:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UrTCiIB5+imBAeHHe5Yk2P2e1nFNoP+klKZAhqbPDdA=; b=MqPIurhFVqpa+pBM1vNQS6bUBZWcTHP2YxERwDnH+bQfrSJK2/72G3Xj7gT+UEioGy thWYm7nOuZQUFNxIv2huTTw/x+VekSpTufiYFUFRGkawxOrxefVaDTY1BSz5YzKXNb3N N68WwPk1+UqgTIjKN5dveLZ8D1OuV7Beewa2kxUojacU7Bp2iSArTdwBToEwZEZGd4Vj mNe2f/owRoeJLfYJRHYnmYyxZRT+hFbQiGMJHYcMVz4o5iqcWa+fTys9HDmTxnnRF79m YZdblvApQE3X8Sz+8/wuOXm/kqKvRy3tyjhXPvV2Tr51KqrC0DPWM7HLycywFd//eT++ 8jkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UrTCiIB5+imBAeHHe5Yk2P2e1nFNoP+klKZAhqbPDdA=; b=SOnYpWJVrHAkU2t+D3w2Ltn8gvRff/v5RLfiFnsRMZEBsr5ut/2lDCYl9c8JYcFh6V l4UVBRrXrsQF+Z7Q51gUAqUI1wnydjIJe8L+BGxEDwWwLT8+kpZCr4ARjj2eSoZvCpmM ynA0PYGfFTQPVlZpkMCKmB2feLC7A0DQRqhBGZaF5/OQ7MJ/0iezigGmV9CtA0nSnUtn YqwGruOY3RqDDrBdH5yEohHFXVztuDSzBN2dTIMcO4TA6WFUDEhfnJaIltU+qV0l17Xs N1BKIxYFXHt/74Qm9FlXlxgay+87MOc+/YdmsZoQJPO6Pw/0NhG/3sG0aDN4gQhxsnzA pp6A== X-Gm-Message-State: AOAM532G7sCwHwLQG0+s5mQ3ZNC6SL+TY4Ac8WVSwPWR0zr2O+T6hlxu qr9RQGWQLaRI1of6XLfzwRrT6hfQKJ+AEtU+yqfQpQ== X-Google-Smtp-Source: ABdhPJwMCeE2M2oBeMoCYDG8p7UZtY8gBrM+hDCF+s5vsXn/s+B7NoTCVj2dK00lSgGxLjxe2HR3aykRV/KV+QWzz/s= X-Received: by 2002:a1c:e903:0:b0:397:36b8:795a with SMTP id q3-20020a1ce903000000b0039736b8795amr9116951wmc.98.1653493586128; Wed, 25 May 2022 08:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-4-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Wed, 25 May 2022 08:46:15 -0700 Message-ID: Subject: Re: [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding To: Arnd Bergmann Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_084630_170268_5D582BB0 X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Wed, Apr 6, 2022 at 11:31 PM Arnd Bergmann wrote: > > On Thu, Apr 7, 2022 at 1:36 AM Brad Larson wrote: > > > > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > > @@ -19,10 +19,12 @@ properties: > > - enum: > > - microchip,mpfs-sd4hc > > - socionext,uniphier-sd4hc > > + - pensando,elba-sd4hc > > - const: cdns,sd4hc > > > > reg: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 > > > > Shouldn't the binding describe what the register areas are? If there > is only one of them, it is fairly clear, but when you have the choice > between one and two, it gets ambiguous, and there is a risk that > another SoC might have a different register area in the second entry, > making it incompatible. Thanks for the review. Changing this to allOf:if:then in updated patchset. The second item is particular to Elba SoC. Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel