From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621CFC2D0A3 for ; Thu, 29 Oct 2020 09:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFD5820790 for ; Thu, 29 Oct 2020 09:25:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="RAZGAbKd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbgJ2JZ3 (ORCPT ); Thu, 29 Oct 2020 05:25:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbgJ2JZ2 (ORCPT ); Thu, 29 Oct 2020 05:25:28 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBF0C0613D5 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id o14so1683193otj.6 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=RAZGAbKdB4XcnSD0wp1Kz5dBTHMEAkPA/y5Q5zBFcm5ek6TOqOD+2MjSuNA7CsSuFv QdasXZzvzm82On3eSCMCjzvEPeFEdeSGCKm4fjXr/Z2Mh9xwUtFmVb6ioAaMFNhmVvnm LvNYGo6oa8r1Gs3CbA9euLgw6UBFM7BcU9IdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=NTPPcTIvp42Ce6Bp4vHJVLP2r55oMjlwM699GGN1QhaFQ6xgUJe58zEIiXbKKU84QS pPUWDG2atGI6pJo0/vgvevIEjU/rY55GQRQNz+p1EizzCf/Asvq+qNYIh3RiLLHwYIQY kTbx9kmj/pJt9isT4CJbwBrir5mgRkPIFMWaM7p6tprKhUPLis5u4JdK1gCDSGoVl/09 BZaQoDgbV629xrrHtcF9Ahr1mZDc+mgi3zxY0Ti3ma9akM7eMIpccCgGEUppMEfkFlLZ Yqboeli+uZKZhwfCTSGio+ye3iCNYl2xVJOpjMo7qNVkE+NK03ByI8BHV2QQAyLMuyc+ VKzA== X-Gm-Message-State: AOAM533XgCjlLiNpm0hT5YXcyTxTkI7+asns0hYXRQ00pLsE1nf742+6 L19KcQJAx/ovRijScmn+4322y1tXCzHhkAAAXVCvwA== X-Google-Smtp-Source: ABdhPJz3d3GbocYLOWK17PC84OSTKCpC1P9Cp1Gqiuhg8zJB6kTRUJIIoeLruWIEtxgmiFM3IrJbR1M7sDMXTefUSTI= X-Received: by 2002:a05:6830:1c3c:: with SMTP id f28mr2685703ote.188.1603963527533; Thu, 29 Oct 2020 02:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> In-Reply-To: <20201029085749.GB25658@infradead.org> From: Daniel Vetter Date: Thu, 29 Oct 2020 10:25:16 +0100 Message-ID: Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races To: Christoph Hellwig Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig wrote: > > Maybe I'm missing something, but shouldn't follow_pfn be unexported > at the end of the series? kvm is a legit user and modular afaict. But since you can't use this without an mmu_notifier anyway (or digging around in pagetable locking), maybe it should be EXPORT_SYMBOL_GPL now at least? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgJ2JZ2 (ORCPT ); Thu, 29 Oct 2020 05:25:28 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A9DEC0613D4 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id n15so1664167otl.8 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) MIME-Version: 1.0 References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> In-Reply-To: <20201029085749.GB25658@infradead.org> From: Daniel Vetter Date: Thu, 29 Oct 2020 10:25:16 +0100 Message-ID: Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races Content-Type: text/plain; charset="UTF-8" List-ID: To: Christoph Hellwig Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig wrote: > > Maybe I'm missing something, but shouldn't follow_pfn be unexported > at the end of the series? kvm is a legit user and modular afaict. But since you can't use this without an mmu_notifier anyway (or digging around in pagetable locking), maybe it should be EXPORT_SYMBOL_GPL now at least? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545BDC55179 for ; Thu, 29 Oct 2020 09:25:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC5342192A for ; Thu, 29 Oct 2020 09:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="RAZGAbKd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC5342192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCA3C6B0062; Thu, 29 Oct 2020 05:25:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7ACF6B0068; Thu, 29 Oct 2020 05:25:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A692E6B006C; Thu, 29 Oct 2020 05:25:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 777316B0062 for ; Thu, 29 Oct 2020 05:25:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2231C180AD815 for ; Thu, 29 Oct 2020 09:25:29 +0000 (UTC) X-FDA: 77424429978.22.touch49_4603d112728c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 02CC618038E68 for ; Thu, 29 Oct 2020 09:25:28 +0000 (UTC) X-HE-Tag: touch49_4603d112728c X-Filterd-Recvd-Size: 3174 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 09:25:28 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id m22so1697965ots.4 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=RAZGAbKdB4XcnSD0wp1Kz5dBTHMEAkPA/y5Q5zBFcm5ek6TOqOD+2MjSuNA7CsSuFv QdasXZzvzm82On3eSCMCjzvEPeFEdeSGCKm4fjXr/Z2Mh9xwUtFmVb6ioAaMFNhmVvnm LvNYGo6oa8r1Gs3CbA9euLgw6UBFM7BcU9IdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=DZJ/F/WJqRUsPkdG6zGGZrvuVVJTQPU3enUqrBvhpFMRqsdxR4786Nfw+Sp3/Zx82K CPQbBtTTh3N7X9Txf/m0Ky5+0kpCs6y2W3KiL31U2uFTxcM73sOWmbiRk4r8GEPnSE0R 3JdD2+0Ixx1XseWH+c966QpOm9byl6DIubeUY11opL0PYu3uqsb8z8yJAPmQQmouO7VZ /X80SAWr4l+JGL70tCZx+FRadbitzACeIF/xrTnRfODSfAS1s4GljLMBHFzAaz40Um/Z 5yPvanup+P9ugNJVJGYD2NdvtpmL5VMRUWMPG2Hr2SsXLukVuFibFpntm+vDsTEZBclC L1OQ== X-Gm-Message-State: AOAM533T2egnWNksZ2agIv84aj8mVhx7M2sa+MHwI1MqAMj9+AjdZJnD z5wF8phT+bunH4tyzJwCyVT95gtx7BIwnWSTOz00uQ== X-Google-Smtp-Source: ABdhPJz3d3GbocYLOWK17PC84OSTKCpC1P9Cp1Gqiuhg8zJB6kTRUJIIoeLruWIEtxgmiFM3IrJbR1M7sDMXTefUSTI= X-Received: by 2002:a05:6830:1c3c:: with SMTP id f28mr2685703ote.188.1603963527533; Thu, 29 Oct 2020 02:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> In-Reply-To: <20201029085749.GB25658@infradead.org> From: Daniel Vetter Date: Thu, 29 Oct 2020 10:25:16 +0100 Message-ID: Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races To: Christoph Hellwig Cc: DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig wrote: > > Maybe I'm missing something, but shouldn't follow_pfn be unexported > at the end of the series? kvm is a legit user and modular afaict. But since you can't use this without an mmu_notifier anyway (or digging around in pagetable locking), maybe it should be EXPORT_SYMBOL_GPL now at least? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02E3C2D0A3 for ; Thu, 29 Oct 2020 09:26:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74E4C2076B for ; Thu, 29 Oct 2020 09:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nz/ElL6K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="RAZGAbKd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74E4C2076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7QrytV9j7NpYE1NR85SX8TGWWF/UkNVk1p5uxcF6uBg=; b=Nz/ElL6KNpzjQqRswxAIpRyG4 hH/mt9Qc5JKoulbRA4zVVN7zfZmR0WKH1Aix+h2wl1h8Nj2auP4A+OXhX5NCh/Cs2ta4e6Au3v9Y9 gaXMttwZSfazPA5BT6rTCsVO+EHrGPsHtMzRobZHoCvjKaIuyqLLICDk7WD1uGki0RRy62tita7yo NPAPz/1fOipbp4xl8GzJddpY9fTEx91M5LSAslhyk5NRsQFhiydN/0XlKdK/zxpQoGkQHZUIiKmqh MctpClboWMOUn9QuO/Hfr/Q1Kkne526ufjCio+UzBIroZsgW3SagI8+sfLqN1IEkzJEOUDXAVD5wZ hR6v2zAnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY4BZ-00070l-72; Thu, 29 Oct 2020 09:25:33 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY4BV-0006yD-Dr for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 09:25:30 +0000 Received: by mail-ot1-x343.google.com with SMTP id 32so1700514otm.3 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=RAZGAbKdB4XcnSD0wp1Kz5dBTHMEAkPA/y5Q5zBFcm5ek6TOqOD+2MjSuNA7CsSuFv QdasXZzvzm82On3eSCMCjzvEPeFEdeSGCKm4fjXr/Z2Mh9xwUtFmVb6ioAaMFNhmVvnm LvNYGo6oa8r1Gs3CbA9euLgw6UBFM7BcU9IdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=H8Gf6Dr/I05cDBnu/kgj9YRUkTN/73WW25BRsZ5DVNeIAV8k4VGJs5tZis/F8ylz+x VdcuhpnbiOmGbxopPsCuPZiNLV/vsBCFVzAe0w0NqX3QcpHRlhtEqCW/HbD8ng6d1/LT Wmb1TOK9MIyhlEuAk0hp7ttcM4jAV9R0Q4FN2Bn4nb9cBPOBiPZ+Kqqrh0zE298JrBs8 mpSFdczBajSh5UozZVluvovPp1fUODHrHTae3ZmovAWtxQaAoZ0k2Z8qR9JpT30tZvIU H+MdsQuHFqgkC5D2+Yo02M9rTwwGwD5eFaHqnKr2VRBZooyGmlCX+KFDuRe5dye4RN8e iQHw== X-Gm-Message-State: AOAM531yrl2BaC1ibE4Qfd2f1hbLchsAg2HL2bth7s+SZUXNhWeTrM0l SY6o2kvD9Jo7XvItVRkgPW4x4PW+T3a5sXSfMxLyew== X-Google-Smtp-Source: ABdhPJz3d3GbocYLOWK17PC84OSTKCpC1P9Cp1Gqiuhg8zJB6kTRUJIIoeLruWIEtxgmiFM3IrJbR1M7sDMXTefUSTI= X-Received: by 2002:a05:6830:1c3c:: with SMTP id f28mr2685703ote.188.1603963527533; Thu, 29 Oct 2020 02:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> In-Reply-To: <20201029085749.GB25658@infradead.org> From: Daniel Vetter Date: Thu, 29 Oct 2020 10:25:16 +0100 Message-ID: Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races To: Christoph Hellwig X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_052529_517247_7525D6A1 X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , linux-samsung-soc , KVM list , LKML , DRI Development , Linux MM , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig wrote: > > Maybe I'm missing something, but shouldn't follow_pfn be unexported > at the end of the series? kvm is a legit user and modular afaict. But since you can't use this without an mmu_notifier anyway (or digging around in pagetable locking), maybe it should be EXPORT_SYMBOL_GPL now at least? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEA3C5517A for ; Thu, 29 Oct 2020 09:25:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A25720790 for ; Thu, 29 Oct 2020 09:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="RAZGAbKd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A25720790 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B34116E8BD; Thu, 29 Oct 2020 09:25:29 +0000 (UTC) Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id A06EB6E8BD for ; Thu, 29 Oct 2020 09:25:28 +0000 (UTC) Received: by mail-ot1-x344.google.com with SMTP id k3so1703736otp.1 for ; Thu, 29 Oct 2020 02:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=RAZGAbKdB4XcnSD0wp1Kz5dBTHMEAkPA/y5Q5zBFcm5ek6TOqOD+2MjSuNA7CsSuFv QdasXZzvzm82On3eSCMCjzvEPeFEdeSGCKm4fjXr/Z2Mh9xwUtFmVb6ioAaMFNhmVvnm LvNYGo6oa8r1Gs3CbA9euLgw6UBFM7BcU9IdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXd5L3340dzHPl4D7TSnIVGFAYIoQ/W+pLHz6LYz95I=; b=D81lrg4nMsBMyLbtEjCc8Vezf+LYhvwNhSNwwR0Ke3fdcRKTbmxpEsc7lNauEQzL9Y baHMlMLCuEvl+LfvPqOZtrnS1YINqUrt68TYZ3WtvUpOXtXnPmmpvwHcbjv539TQ5cEf oCTb/m0TX5NbMCRdyfQzoHJDwbxdOAlU9ESfMbBSk38RCunDGafQnMaXx/8+/Vy6AyYN G8blRcBmfZWKAwxazBBDEnzGJXOlDorWFnFi1wsCSdbhymvch1n2FJP7MEnGRjEgqx7z RAsypofGPTAj1onXqHOI4juD7wip2erM/hyidZrOYlxIIqsAsjyEyc7+HY5Vy0IVkVwH dhzg== X-Gm-Message-State: AOAM531ISLG06SBOMccCSKJsDKeNFCO9+RWZQ0kHFQ6/UcebRJF7L0qx pikxc78BgV67nNI0auvliErnTK0/fsxwiY7OcB2GVw== X-Google-Smtp-Source: ABdhPJz3d3GbocYLOWK17PC84OSTKCpC1P9Cp1Gqiuhg8zJB6kTRUJIIoeLruWIEtxgmiFM3IrJbR1M7sDMXTefUSTI= X-Received: by 2002:a05:6830:1c3c:: with SMTP id f28mr2685703ote.188.1603963527533; Thu, 29 Oct 2020 02:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> In-Reply-To: <20201029085749.GB25658@infradead.org> From: Daniel Vetter Date: Thu, 29 Oct 2020 10:25:16 +0100 Message-ID: Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races To: Christoph Hellwig X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , linux-samsung-soc , KVM list , LKML , DRI Development , Linux MM , Linux ARM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Oct 29, 2020 at 9:57 AM Christoph Hellwig wrote: > > Maybe I'm missing something, but shouldn't follow_pfn be unexported > at the end of the series? kvm is a legit user and modular afaict. But since you can't use this without an mmu_notifier anyway (or digging around in pagetable locking), maybe it should be EXPORT_SYMBOL_GPL now at least? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel