From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523D6C12002 for ; Mon, 19 Jul 2021 08:29:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14D6F611BF for ; Mon, 19 Jul 2021 08:29:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14D6F611BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90ECE89D02; Mon, 19 Jul 2021 08:29:46 +0000 (UTC) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4CEE89D02 for ; Mon, 19 Jul 2021 08:29:45 +0000 (UTC) Received: by mail-oi1-x235.google.com with SMTP id c197so19846764oib.11 for ; Mon, 19 Jul 2021 01:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I/U/F/FoGCwikPSNTinZDpXksxDgDl9adfNXfGBR7OU=; b=YVyQBerlcnS/dwMrvzX8Gq5MysLT3Xw3iYV7nQS4rqqlzb2FOXeTnYSBDIw3SMTI7T jjTWaOkXo+ELz+3bSKjJu0SgAtoc+UYOrowpJfgegK5m8NW7CRF5fw3fZ0Ab7FRSNX7r plg1mf/f0ji9u38M9LbWK3UhxiTW8mtPSXORs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/U/F/FoGCwikPSNTinZDpXksxDgDl9adfNXfGBR7OU=; b=Byk+KGEfmHwx1oSRKv31yZZsU6kzx3L3ASKFlwUg7wjleGVNfLnL7k7vHn8YaYCed1 H3Ij2qOmUUZEGQTBSfEw4nrdpNO6UokC8rwhxlDc0YDJkIAYhdj5Oxfm3fAxvP6RI76S 5odPAsZQR+Rr8mbKtav3w0/KG9hwIFBQH2CmS3gVKfHLBZhuyipLXqY+SQAIMRUCo8fF /iomA+nrFnRuxRxIlkFHOsKFy1UFCM/hSEaUVguQUvo8ML2BXE3F/S2LzxV5kU4EHNNz Qe6HMKNiGPQimJar+PLLDSFKgvOr0jA/IOGZ2RTpjSMg2b06Rk6wst207LcnawwLUGgy fHpw== X-Gm-Message-State: AOAM531HmMoSOA0UbUelwMVbERZ7IT3wCV24vSA4+pQVmBnytRQSlDGh f6M3ABHUFjJXSQN0axVASFsH+mmtNP/J9My/bEMR4g== X-Google-Smtp-Source: ABdhPJyDF2Zvihqlfib/G24hn8FKftpUajDO9Q2bpEudI0iDTQNgjSSYYhxBFgUqbK5fizWFUC1/K+G2TLSLMNE60oU= X-Received: by 2002:aca:3085:: with SMTP id w127mr20468682oiw.101.1626683385258; Mon, 19 Jul 2021 01:29:45 -0700 (PDT) MIME-Version: 1.0 References: <20210716224758.2162003-1-jason@jlekstrand.net> In-Reply-To: <20210716224758.2162003-1-jason@jlekstrand.net> From: Daniel Vetter Date: Mon, 19 Jul 2021 10:29:34 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() To: Jason Ekstrand Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand wrote: > > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") > Cc: Daniel Vetter Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7C7C636C9 for ; Mon, 19 Jul 2021 08:29:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B24E0611BE for ; Mon, 19 Jul 2021 08:29:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B24E0611BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41D7A89E9E; Mon, 19 Jul 2021 08:29:47 +0000 (UTC) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id E953B89D61 for ; Mon, 19 Jul 2021 08:29:45 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id h9so19912675oih.4 for ; Mon, 19 Jul 2021 01:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I/U/F/FoGCwikPSNTinZDpXksxDgDl9adfNXfGBR7OU=; b=YVyQBerlcnS/dwMrvzX8Gq5MysLT3Xw3iYV7nQS4rqqlzb2FOXeTnYSBDIw3SMTI7T jjTWaOkXo+ELz+3bSKjJu0SgAtoc+UYOrowpJfgegK5m8NW7CRF5fw3fZ0Ab7FRSNX7r plg1mf/f0ji9u38M9LbWK3UhxiTW8mtPSXORs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/U/F/FoGCwikPSNTinZDpXksxDgDl9adfNXfGBR7OU=; b=SJg0XgF6YfNEKJ3zgFTqUo/lrwgBAWg+qPCQ2EMJOh84tb2GKdl2sy8KcYlX2K7f0+ RfGlmTZh88VUlg00rPbvfOniKVXiYudX0/NNdaDy45TZ8KIxM9Jgpzq0KwwytT1HzTuz F8wxLl8YRLAAlFiANOetiLoPrz0rEQQNpKeoQJvFMFRfkAAI80fQvFEQMSi6UWZMhx2k yf2NmnFXgoNb7u5QUXCRgrOQoIXz15DvqQjrc8Bu8UV5uUojmJiCXN52l/ej1NF/hPic GvzVSuw+BIaeO4KYQdrP38ZB25OUYfki2pfUT62A27ZcynuYmb5y4dL4RuKLj4pH+UBp jvFw== X-Gm-Message-State: AOAM532xOFOJEVX4Jts4zczuDfVioQTwGU3Pz6i+DqaqthGZodFFYDhU fkMYX9iKA65jfmBAWJvvB9UQlBrrj+OLQ3A+tfEdxg== X-Google-Smtp-Source: ABdhPJyDF2Zvihqlfib/G24hn8FKftpUajDO9Q2bpEudI0iDTQNgjSSYYhxBFgUqbK5fizWFUC1/K+G2TLSLMNE60oU= X-Received: by 2002:aca:3085:: with SMTP id w127mr20468682oiw.101.1626683385258; Mon, 19 Jul 2021 01:29:45 -0700 (PDT) MIME-Version: 1.0 References: <20210716224758.2162003-1-jason@jlekstrand.net> In-Reply-To: <20210716224758.2162003-1-jason@jlekstrand.net> From: Daniel Vetter Date: Mon, 19 Jul 2021 10:29:34 +0200 Message-ID: To: Jason Ekstrand Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand wrote: > > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") > Cc: Daniel Vetter Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx