From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68305CA9ED9 for ; Tue, 5 Nov 2019 07:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36E2820717 for ; Tue, 5 Nov 2019 07:42:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dBAoHlIf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387898AbfKEHmg (ORCPT ); Tue, 5 Nov 2019 02:42:36 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37356 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387678AbfKEHmf (ORCPT ); Tue, 5 Nov 2019 02:42:35 -0500 Received: by mail-ed1-f68.google.com with SMTP id k14so6452135eds.4; Mon, 04 Nov 2019 23:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bq/oMc1w9CZddX2/C9nXQ3BMFHPgQLCdmRfeuuGrMCk=; b=dBAoHlIfAFubuAAkCQ1bOLzFinxVvIQv3YIsEA8WSu/W6D4AoT2tuQVVEsHCGIZbrs L7/dVxXRnZHC20Fjy6lhXs4P14zhLRHeNR+eDHhQtc22epbXPYPkEETJI1ubRAxcxsg3 D3OArLLX68Wt7NZ7KTH/1rl1c7RttEOCrBfppGBS5sAkgelzbVa933Scmpp+h+pKP9/M 4Qhhw6fW5xjDrYzBQtZ+NYhxo6hFz7JIE9Kt1uSyDt6zuxsWS8aOcWB2kRdemZ/GqijK GuIJt4n8PA49nr/V3XzIPmpXaAoWcvWOHqwPTmUVgDph2tBWFmY3d0in9KDo/jIKf/R2 3fjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bq/oMc1w9CZddX2/C9nXQ3BMFHPgQLCdmRfeuuGrMCk=; b=pD7kq2m1kjGXONEX4lrWICnifyvoLJOR3blF/dih0K/nxJv38yGsPDfv3ooNWaEyul iMV9fMeOR5BvIersRTSYDBdTMFNhVF1Jqz4rRfc2QqYcdwW0Vp6+B3J61InCxa48m/BC T0aA0/fA0AnJUYeYeHnhFqvqTL1IWBDXDHn/vCJY9aWudXvIrxB1TuZZuknN1ERqyugn YaFWBhpvsWLnMNqESPB4x73GuBYWcCLHZ4YesXa5ov1nXFZuOG7ZEo0ELJb6QLoiXgVb 4L1eVR8GEw9d1SqVIxMWUhTJg1XBKwmEJg1/pnLnskfR++obSdFmAEAzwGbxgMUDJXRL sltw== X-Gm-Message-State: APjAAAUWW9HuAoVK8u/DOMGHnr4h07Sd5m0TLOUBXrzVBCKKlgj1rJI0 HjBbqRuAimaHy+OMEAaNR5gkgCE78SAj0L8iOQ4= X-Google-Smtp-Source: APXvYqxHxoo2BcLosgwrlvaNTgVtaxbho2YuMgoaxCXaCLIGhgwth9sUWzs89I66sMY4WMTPxx22c3XCPdwtZ1DX830= X-Received: by 2002:a17:906:780e:: with SMTP id u14mr27332804ejm.97.1572939754050; Mon, 04 Nov 2019 23:42:34 -0800 (PST) MIME-Version: 1.0 References: <20190219012447.5900-1-sxauwsk@163.com> In-Reply-To: <20190219012447.5900-1-sxauwsk@163.com> From: Shubhrajyoti Datta Date: Tue, 5 Nov 2019 13:12:22 +0530 Message-ID: Subject: Re: [PATCH v2] i2c: cadence: try reset when master receive arbitration lost To: Shikai Wang Cc: Michal Simek , Shubhrajyoti Datta , Wolfram Sang , linux-arm-kernel , linux-i2c , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shikai, On Tue, Feb 19, 2019 at 8:19 AM Shikai Wang wrote: > > When the adapter receive arbitration lost error interrupts, > cdns_i2c_master_xfer return to the caller directly instead of resetting > the adapter which resulted in the adapter being out of control. > > So when driver detect err_status such as arbitration lost, > then try to repair and fix it. > I am missing the issue that you are facing. You are having a multimaster scenario and getting arbitration lost. the current code would attempt a retry did that lead to any issues? Can you explain the issue that you are facing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E81CA9EDB for ; Tue, 5 Nov 2019 07:42:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E28F20663 for ; Tue, 5 Nov 2019 07:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kMBIB8ZC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dBAoHlIf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E28F20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xl7P/VBN1mVN/Tq4ldJ+4GbufB0XYk3ahKkN8PHByOY=; b=kMBIB8ZCwRdA/z 29HQ0o9CFMZ17vnZGsS0mWrRkQFUfUr0c1SgJkw7KgCuDnoPAMHhv3IAOgKKAjRRd2BLLZjkOAwf6 25vAHAinCisU3FqYSQ5B6v8PxH9Y/HqrucTxzqtxlKNePgTnts3W5R372YrX/agrT04aKKKCkCp3Q 5MQjPNBEPAeLAhDACKCjRx3tJ2Jm/DeK6ESFEdukNXa+eUrEIosYXpvco1AF7/5uNXS/tpj7+fKHu VMnSKa0paRZKwQe/BmfEKI8eCcNF1DGGdQ3nYXA8anjdIgDHEeOKU/HQ9SsFEfrVDP1/OM6HORn/h 7nnzReEOdI4WZpzA6yNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRtU6-0002p8-K1; Tue, 05 Nov 2019 07:42:38 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRtU4-0002od-0e for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 07:42:37 +0000 Received: by mail-ed1-x541.google.com with SMTP id r16so555917edq.2 for ; Mon, 04 Nov 2019 23:42:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bq/oMc1w9CZddX2/C9nXQ3BMFHPgQLCdmRfeuuGrMCk=; b=dBAoHlIfAFubuAAkCQ1bOLzFinxVvIQv3YIsEA8WSu/W6D4AoT2tuQVVEsHCGIZbrs L7/dVxXRnZHC20Fjy6lhXs4P14zhLRHeNR+eDHhQtc22epbXPYPkEETJI1ubRAxcxsg3 D3OArLLX68Wt7NZ7KTH/1rl1c7RttEOCrBfppGBS5sAkgelzbVa933Scmpp+h+pKP9/M 4Qhhw6fW5xjDrYzBQtZ+NYhxo6hFz7JIE9Kt1uSyDt6zuxsWS8aOcWB2kRdemZ/GqijK GuIJt4n8PA49nr/V3XzIPmpXaAoWcvWOHqwPTmUVgDph2tBWFmY3d0in9KDo/jIKf/R2 3fjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bq/oMc1w9CZddX2/C9nXQ3BMFHPgQLCdmRfeuuGrMCk=; b=CRlPA8BMOW7dIoFHDIGBn/LWALk6kvxY4TVdhC29/P8xZu5JKgE+7Q5geGi/3bHEgg Lh/wkXxq63N46FDT7P1mastL3MNyH/Uu3NpxEpap/sndljD9hOWi3fwsYwpsH0k39V/z qEbedEET4/mzaDlh2saD2ijQRWhDaaQuyulshPonH6a6ZgA/2Wc1IAe0Ao7Kq4JNDPIU 195nGwGr0Wd1N/zXO9HI2TGqqGp0mh77aaOfWWOdgJeNxaWRWVNqXjXBTxVUiz4EWjJb wLxaSAYdtSQvnU4TNrBEiEcxy5RscYe25tVhEfEczff47EooMKZG4y4tl+BXRoE7SouE FaGw== X-Gm-Message-State: APjAAAVzLtdylOB6PgGP6pxb8PgA5ut/L6s7mw+HvSXyfoU5Yo7YPvJG 9yPMINNN5caTbUvBRN+7L6ndCiD3IwYfDxo1eSo= X-Google-Smtp-Source: APXvYqxHxoo2BcLosgwrlvaNTgVtaxbho2YuMgoaxCXaCLIGhgwth9sUWzs89I66sMY4WMTPxx22c3XCPdwtZ1DX830= X-Received: by 2002:a17:906:780e:: with SMTP id u14mr27332804ejm.97.1572939754050; Mon, 04 Nov 2019 23:42:34 -0800 (PST) MIME-Version: 1.0 References: <20190219012447.5900-1-sxauwsk@163.com> In-Reply-To: <20190219012447.5900-1-sxauwsk@163.com> From: Shubhrajyoti Datta Date: Tue, 5 Nov 2019 13:12:22 +0530 Message-ID: Subject: Re: [PATCH v2] i2c: cadence: try reset when master receive arbitration lost To: Shikai Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_234236_055910_E40016F5 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wolfram Sang , Shubhrajyoti Datta , linux-kernel , Michal Simek , linux-i2c , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shikai, On Tue, Feb 19, 2019 at 8:19 AM Shikai Wang wrote: > > When the adapter receive arbitration lost error interrupts, > cdns_i2c_master_xfer return to the caller directly instead of resetting > the adapter which resulted in the adapter being out of control. > > So when driver detect err_status such as arbitration lost, > then try to repair and fix it. > I am missing the issue that you are facing. You are having a multimaster scenario and getting arbitration lost. the current code would attempt a retry did that lead to any issues? Can you explain the issue that you are facing? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel