From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: ganeshgr@chelsio.com, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxgb4: Use proper enum in cxgb4_dcb_handle_fw_update
Date: Tue, 2 Oct 2018 15:54:27 -0700 [thread overview]
Message-ID: <CAKwvOdknwESEUK2UTZoTfC9U8vXcVrmpx_1=4jpMxQ25hM=vKA@mail.gmail.com> (raw)
In-Reply-To: <20181001035143.30670-1-natechancellor@gmail.com>
On Sun, Sep 30, 2018 at 8:54 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:303:7: warning: implicit
> conversion from enumeration type 'enum cxgb4_dcb_state' to different
> enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion]
> ? CXGB4_DCB_STATE_FW_ALLSYNCED
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:304:7: warning: implicit
> conversion from enumeration type 'enum cxgb4_dcb_state' to different
> enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion]
> : CXGB4_DCB_STATE_FW_INCOMPLETE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 warnings generated.
>
> Use the equivalent value of the expected type to silence Clang while
> resulting in no functional change.
>
> CXGB4_DCB_STATE_FW_INCOMPLETE = CXGB4_DCB_INPUT_FW_INCOMPLETE = 2
> CXGB4_DCB_STATE_FW_ALLSYNCED = CXGB4_DCB_INPUT_FW_ALLSYNCED = 3
Yep looks good. There's not too many users of cxgb4_dcb_state_input
in the kernel. I wonder if it could even be replaced entirely with
cxgb4_dcb_state? But for now this patch fixes the warning correctly.
Thanks for sending it.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Looks like this was the second case of this warning in this code (I
thought I was having Deja Vu; that I had already reviewed this patch
earlier): https://lkml.org/lkml/2018/10/1/255 Probably could have been
a single patch, but that's ok.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> index 6ba3104ff7eb..9bd5f755a0e0 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
> @@ -300,8 +300,8 @@ void cxgb4_dcb_handle_fw_update(struct adapter *adap,
> enum cxgb4_dcb_state_input input =
> ((pcmd->u.dcb.control.all_syncd_pkd &
> FW_PORT_CMD_ALL_SYNCD_F)
> - ? CXGB4_DCB_STATE_FW_ALLSYNCED
> - : CXGB4_DCB_STATE_FW_INCOMPLETE);
> + ? CXGB4_DCB_INPUT_FW_ALLSYNCED
> + : CXGB4_DCB_INPUT_FW_INCOMPLETE);
>
> if (dcb->dcb_version != FW_PORT_DCB_VER_UNKNOWN) {
> dcb_running_version = FW_PORT_CMD_DCB_VERSION_G(
> --
> 2.19.0
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-10-02 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 3:51 [PATCH] cxgb4: Use proper enum in cxgb4_dcb_handle_fw_update Nathan Chancellor
2018-10-02 22:54 ` Nick Desaulniers [this message]
2018-10-03 5:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdknwESEUK2UTZoTfC9U8vXcVrmpx_1=4jpMxQ25hM=vKA@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.