From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398A2C432BE for ; Mon, 26 Jul 2021 20:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146DC60FC2 for ; Mon, 26 Jul 2021 20:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232392AbhGZT6n (ORCPT ); Mon, 26 Jul 2021 15:58:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:56098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232169AbhGZT6n (ORCPT ); Mon, 26 Jul 2021 15:58:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D5C6A60F93; Mon, 26 Jul 2021 20:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627331951; bh=jwo7kjnHqUbR60c5VoxUCqCoqYO9MoJQlrQi+4fW4nw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IM1Cyw+uHcMqpcFwB5U40N1+xhiaMW+QGgy8y88TD4v54U/cYQTjnicq9o5a2t5qd Huqtohyx1ES7ADhbV+hXCmpd2FfwEUf7nnqYi2eKd1v00GtAWuBe6WFhTSp71Hngz4 Ac5P7NQRd0mEY6CmBbbDl2U0Z5r7DGJuQhnGADH65RKX1Vl74teoVJXMGtykOJtQEY 4eMJ3dvlQjMssn2PBx6NIApqmS0j7amH6ipSdLgYNBgaVYcBxt3qHG2TeQpsF1Yx11 DxBf/ov8CcLuJC062sr5/xJkxB258vf6ezv4ab/J9hmxmf5SfEDSTQ6BH1C28I4IKs +ptqSeBkla+xg== Received: by mail-ej1-f52.google.com with SMTP id gt31so18307817ejc.12; Mon, 26 Jul 2021 13:39:11 -0700 (PDT) X-Gm-Message-State: AOAM531u5mn9+q8Rbhr1marjXeY7Wthzo72S5Sdj05vfaNavpxXEYE/C +bNhCkUra9LJ6zR040hL3e817bBK1kRA3udE4g== X-Google-Smtp-Source: ABdhPJyDv+fNM15O8FW0ikww+Gu4xZZSpQZ6R3qbgI+h6Cc4kEmc6zdHsuCgR+UDTohh/3hVsE7ncmERZ84okNEPzy0= X-Received: by 2002:a17:906:4917:: with SMTP id b23mr35654ejq.468.1627331950408; Mon, 26 Jul 2021 13:39:10 -0700 (PDT) MIME-Version: 1.0 References: <889aae1b88f120cb6281919d27164a959fbe69d0.1626948070.git.baruch@tkos.co.il> <70f0522a9394e9da2f31871442d47f6ad0ff41aa.1626948070.git.baruch@tkos.co.il> In-Reply-To: From: Rob Herring Date: Mon, 26 Jul 2021 14:38:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding To: Bjorn Andersson Cc: Baruch Siach , Thierry Reding , "Uwe Kleine-K?nig" , Lee Jones , Andy Gross , Balaji Prakash J , Robert Marko , Kathiravan T , Linux PWM List , devicetree@vger.kernel.org, linux-arm-msm , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, Jul 25, 2021 at 12:27 PM Bjorn Andersson wrote: > > On Thu 22 Jul 05:01 CDT 2021, Baruch Siach wrote: > > > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > > > Signed-off-by: Baruch Siach > > --- > > v6: > > > > Device node is child of TCSR; remove phandle (Rob Herring) > > > > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-K=C3=B6nig) > > > > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn > > Andersson, Kathiravan T) > > > > v4: Update the binding example node as well (Rob Herring's bot) > > > > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) > > > > v2: Make #pwm-cells const (Rob Herring) > > --- > > .../devicetree/bindings/pwm/ipq-pwm.yaml | 69 +++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Docum= entation/devicetree/bindings/pwm/ipq-pwm.yaml > > new file mode 100644 > > index 000000000000..ee2bb03a1223 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ6018 PWM controller > > + > > +maintainers: > > + - Baruch Siach > > + > > +properties: > > + "#pwm-cells": > > + const: 2 > > + > > + compatible: > > + const: qcom,ipq6018-pwm > > + > > + offset: > > + description: | > > '|' maintains the formatting of the text, you don't need that. > > > + Offset of PWM register in the TCSR block. > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: core > > With a single clock, it's nice to skip the -names. > > > + > > + assigned-clocks: > > + maxItems: 1 > > + > > + assigned-clock-rates: > > + maxItems: 1 > > These (assigned-*) are generic properties that may be used on a lot of > nodes, should they really be part of the individual binding, Rob? They are allowed on any node with 'clocks', so you don't need them. However, if you know there's 1 entry only, then I'd keep that. Or was 'maxItems: 1' just copied because I see that alot. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB35C4338F for ; Mon, 26 Jul 2021 20:41:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C06B460F51 for ; Mon, 26 Jul 2021 20:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C06B460F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ViVj67dPinMCYe10UusZc2XPK/wM+u5PVcw4U2AXF2s=; b=riKiianRLkMsfg ArYQrrys5WQUZVtWk+GRuDb1MW0r3TaHTNSJqeZjvDUSuyFExiqtwPohXaxN6EQxuOYKb/Kce20yO 25nNW0JcMy9gIWs6XiLJU+kKEqOoE13cEdAfApZZ+CCjdfHJR585LldyDIYixFkK2+q48qthGiG3C btHy0o4I8W6jU9/oIuzIfRioA8mkeW637PAbymCR0NjeGX9Z5Op1qwJ3Fw+K5aC+KOyYGSGkVg3Q4 gCvDvZaG2Daq9/72gUJqIVLMN09FvzG19KjzkCpd66l72Yvu5P3W3LwlIlyfUzVl/OGuM/mQFU4e8 oNBppDTQjfu2+2tqPEiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m87Nb-00CRFz-Nv; Mon, 26 Jul 2021 20:39:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m87NY-00CRFC-5x for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 20:39:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D1AC160F94 for ; Mon, 26 Jul 2021 20:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627331951; bh=jwo7kjnHqUbR60c5VoxUCqCoqYO9MoJQlrQi+4fW4nw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IM1Cyw+uHcMqpcFwB5U40N1+xhiaMW+QGgy8y88TD4v54U/cYQTjnicq9o5a2t5qd Huqtohyx1ES7ADhbV+hXCmpd2FfwEUf7nnqYi2eKd1v00GtAWuBe6WFhTSp71Hngz4 Ac5P7NQRd0mEY6CmBbbDl2U0Z5r7DGJuQhnGADH65RKX1Vl74teoVJXMGtykOJtQEY 4eMJ3dvlQjMssn2PBx6NIApqmS0j7amH6ipSdLgYNBgaVYcBxt3qHG2TeQpsF1Yx11 DxBf/ov8CcLuJC062sr5/xJkxB258vf6ezv4ab/J9hmxmf5SfEDSTQ6BH1C28I4IKs +ptqSeBkla+xg== Received: by mail-ej1-f54.google.com with SMTP id oz16so9934052ejc.7 for ; Mon, 26 Jul 2021 13:39:11 -0700 (PDT) X-Gm-Message-State: AOAM532Y1IyAmwqYyI28XI1IcdC0KWCDQNR1VorR9Pe3ZRAVTQ4z2dDj vW6R97vwXlMVEBhXS28EjYo1fAivu8x8N4NmbQ== X-Google-Smtp-Source: ABdhPJyDv+fNM15O8FW0ikww+Gu4xZZSpQZ6R3qbgI+h6Cc4kEmc6zdHsuCgR+UDTohh/3hVsE7ncmERZ84okNEPzy0= X-Received: by 2002:a17:906:4917:: with SMTP id b23mr35654ejq.468.1627331950408; Mon, 26 Jul 2021 13:39:10 -0700 (PDT) MIME-Version: 1.0 References: <889aae1b88f120cb6281919d27164a959fbe69d0.1626948070.git.baruch@tkos.co.il> <70f0522a9394e9da2f31871442d47f6ad0ff41aa.1626948070.git.baruch@tkos.co.il> In-Reply-To: From: Rob Herring Date: Mon, 26 Jul 2021 14:38:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding To: Bjorn Andersson Cc: Baruch Siach , Thierry Reding , "Uwe Kleine-K?nig" , Lee Jones , Andy Gross , Balaji Prakash J , Robert Marko , Kathiravan T , Linux PWM List , devicetree@vger.kernel.org, linux-arm-msm , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_133912_299114_6756F83C X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBKdWwgMjUsIDIwMjEgYXQgMTI6MjcgUE0gQmpvcm4gQW5kZXJzc29uCjxiam9ybi5h bmRlcnNzb25AbGluYXJvLm9yZz4gd3JvdGU6Cj4KPiBPbiBUaHUgMjIgSnVsIDA1OjAxIENEVCAy MDIxLCBCYXJ1Y2ggU2lhY2ggd3JvdGU6Cj4KPiA+IERUIGJpbmRpbmcgZm9yIHRoZSBQV00gYmxv Y2sgaW4gUXVhbGNvbW0gSVBRNjAxOCBTb0MuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQmFydWNo IFNpYWNoIDxiYXJ1Y2hAdGtvcy5jby5pbD4KPiA+IC0tLQo+ID4gdjY6Cj4gPgo+ID4gICBEZXZp Y2Ugbm9kZSBpcyBjaGlsZCBvZiBUQ1NSOyByZW1vdmUgcGhhbmRsZSAoUm9iIEhlcnJpbmcpCj4g Pgo+ID4gICBBZGQgYXNzaWduZWQtY2xvY2tzL2Fzc2lnbmVkLWNsb2NrLXJhdGVzIChVd2UgS2xl aW5lLUvDtm5pZykKPiA+Cj4gPiB2NTogVXNlIHFjb20scHdtLXJlZ3MgZm9yIHBoYW5kbGUgaW5z dGVhZCBvZiBkaXJlY3QgcmVncyAoQmpvcm4KPiA+ICAgICBBbmRlcnNzb24sIEthdGhpcmF2YW4g VCkKPiA+Cj4gPiB2NDogVXBkYXRlIHRoZSBiaW5kaW5nIGV4YW1wbGUgbm9kZSBhcyB3ZWxsIChS b2IgSGVycmluZydzIGJvdCkKPiA+Cj4gPiB2Mzogcy9xY29tLHB3bS1pcHE2MDE4L3Fjb20saXBx NjAxOC1wd20vIChSb2IgSGVycmluZykKPiA+Cj4gPiB2MjogTWFrZSAjcHdtLWNlbGxzIGNvbnN0 IChSb2IgSGVycmluZykKPiA+IC0tLQo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9p cHEtcHdtLnlhbWwgICAgICB8IDY5ICsrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hh bmdlZCwgNjkgaW5zZXJ0aW9ucygrKQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL2lwcS1wd20ueWFtbAo+ID4KPiA+IGRpZmYgLS1n aXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL2lwcS1wd20ueWFtbCBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vaXBxLXB3bS55YW1sCj4gPiBu ZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi5lZTJiYjAzYTEyMjMK PiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9wd20vaXBxLXB3bS55YW1sCj4gPiBAQCAtMCwwICsxLDY5IEBACj4gPiArIyBTUERYLUxp Y2Vuc2UtSWRlbnRpZmllcjogKEdQTC0yLjAtb25seSBPUiBCU0QtMi1DbGF1c2UpCj4gPiArJVlB TUwgMS4yCj4gPiArLS0tCj4gPiArJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9w d20vaXBxLXB3bS55YW1sIwo+ID4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRh LXNjaGVtYXMvY29yZS55YW1sIwo+ID4gKwo+ID4gK3RpdGxlOiBRdWFsY29tbSBJUFE2MDE4IFBX TSBjb250cm9sbGVyCj4gPiArCj4gPiArbWFpbnRhaW5lcnM6Cj4gPiArICAtIEJhcnVjaCBTaWFj aCA8YmFydWNoQHRrb3MuY28uaWw+Cj4gPiArCj4gPiArcHJvcGVydGllczoKPiA+ICsgICIjcHdt LWNlbGxzIjoKPiA+ICsgICAgY29uc3Q6IDIKPiA+ICsKPiA+ICsgIGNvbXBhdGlibGU6Cj4gPiAr ICAgIGNvbnN0OiBxY29tLGlwcTYwMTgtcHdtCj4gPiArCj4gPiArICBvZmZzZXQ6Cj4gPiArICAg IGRlc2NyaXB0aW9uOiB8Cj4KPiAnfCcgbWFpbnRhaW5zIHRoZSBmb3JtYXR0aW5nIG9mIHRoZSB0 ZXh0LCB5b3UgZG9uJ3QgbmVlZCB0aGF0Lgo+Cj4gPiArICAgICAgT2Zmc2V0IG9mIFBXTSByZWdp c3RlciBpbiB0aGUgVENTUiBibG9jay4KPiA+ICsgICAgbWF4SXRlbXM6IDEKPiA+ICsKPiA+ICsg IGNsb2NrczoKPiA+ICsgICAgbWF4SXRlbXM6IDEKPiA+ICsKPiA+ICsgIGNsb2NrLW5hbWVzOgo+ ID4gKyAgICBjb25zdDogY29yZQo+Cj4gV2l0aCBhIHNpbmdsZSBjbG9jaywgaXQncyBuaWNlIHRv IHNraXAgdGhlIC1uYW1lcy4KPgo+ID4gKwo+ID4gKyAgYXNzaWduZWQtY2xvY2tzOgo+ID4gKyAg ICBtYXhJdGVtczogMQo+ID4gKwo+ID4gKyAgYXNzaWduZWQtY2xvY2stcmF0ZXM6Cj4gPiArICAg IG1heEl0ZW1zOiAxCj4KPiBUaGVzZSAoYXNzaWduZWQtKikgYXJlIGdlbmVyaWMgcHJvcGVydGll cyB0aGF0IG1heSBiZSB1c2VkIG9uIGEgbG90IG9mCj4gbm9kZXMsIHNob3VsZCB0aGV5IHJlYWxs eSBiZSBwYXJ0IG9mIHRoZSBpbmRpdmlkdWFsIGJpbmRpbmcsIFJvYj8KClRoZXkgYXJlIGFsbG93 ZWQgb24gYW55IG5vZGUgd2l0aCAnY2xvY2tzJywgc28geW91IGRvbid0IG5lZWQgdGhlbS4KSG93 ZXZlciwgaWYgeW91IGtub3cgdGhlcmUncyAxIGVudHJ5IG9ubHksIHRoZW4gSSdkIGtlZXAgdGhh dC4gT3Igd2FzCidtYXhJdGVtczogMScganVzdCBjb3BpZWQgYmVjYXVzZSBJIHNlZSB0aGF0IGFs b3QuCgpSb2IKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK