From: Rob Herring <robh+dt@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Andreas Kemnade <andreas@kemnade.info>,
Arnd Bergmann <arnd@arndb.de>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Pavel Machek <pavel@ucw.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 6/7] dt-bindings: gnss: add sirfstar binding
Date: Wed, 25 Apr 2018 13:25:26 -0500 [thread overview]
Message-ID: <CAL_Jsq+nj9P5z=Ao=UbS-AKy+qeM98EFJiHmYgoniD_4N3Hr4w@mail.gmail.com> (raw)
In-Reply-To: <20180424163458.11947-7-johan@kernel.org>
On Tue, Apr 24, 2018 at 11:34 AM, Johan Hovold <johan@kernel.org> wrote:
> Add binding for SiRFstar-based GNSS receivers.
>
> Note that while four compatible-strings are initially added representing
> devices which differ in which I/O interfaces they support, they
> otherwise essentially share the same feature set.
>
> Pin and supply names (and some recommended timings) vary slightly, but
> the binding recommends using a common set of names.
>
> Note that the wakeup gpio is not intended to be as a wakeup source, but
> rather to detect the current power state of the device (active or
> hibernate).
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> .../devicetree/bindings/gnss/sirfstar.txt | 38 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 3 ++
> 2 files changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gnss/sirfstar.txt
One nit below, otherwise:
Reviewed-by: Rob Herring <robh@kernel.org>
> diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.txt b/Documentation/devicetree/bindings/gnss/sirfstar.txt
> new file mode 100644
> index 000000000000..5e6a02aec49a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/sirfstar.txt
> @@ -0,0 +1,38 @@
> +SiRFstar-based GNSS Receiver DT binding
> +
> +SiRFstar chipsets are used in GNSS-receiver modules produced by several
> +vendors and can use UART, SPI or I2C interfaces.
> +
> +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
> +properties.
> +
> +Required Properties:
> +
> +- compatible : Must be one of
> +
> + "fastrax,uc430"
> + "linx,r4"
> + "wi2wi,w2sg0008i"
> + "wi2wi,w2sg0084i"
> +
> +- vcc-supply : Main voltage regulator (3V3_IN, VDD, VCC)
> +
> +Optional Properties:
> +
> +- enable-gpios : GPIO used to power on and off device (ON_OFF)
> +- wakeup-gpios : GPIO used to determine device power state (WAKEUP, RFPWRUP)
> +- timepulse-gpios : Timepulse (e.g 1PPS) GPIO (1PPS, TM)
> +
> +Example:
> +
> +serial@1234 {
> + compatible = "ns16550a";
> +
> + gnss {
> + compatible = "wi2wi,w2sg0084i";
> +
> + vcc-supply = <&gnss_reg>;
> + enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> + wakeup-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>;
> + };
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2128dfdf73f1..ddd81c82082d 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -120,6 +120,7 @@ excito Excito
> ezchip EZchip Semiconductor
> fairphone Fairphone B.V.
> faraday Faraday Technology Corporation
> +fastrax Fastrax Oy
> fcs Fairchild Semiconductor
> firefly Firefly
> focaltech FocalTech Systems Co.,Ltd
> @@ -197,6 +198,7 @@ licheepi Lichee Pi
> linaro Linaro Limited
> linksys Belkin International, Inc. (Linksys)
> linux Linux-specific binding
> +linx Linx Technologies
> lltc Linear Technology Corporation
> lsi LSI Corp. (LSI Logic)
> lwn Liebherr-Werk Nenzing GmbH
> @@ -390,6 +392,7 @@ vivante Vivante Corporation
> vocore VoCore Studio
> voipac Voipac Technologies s.r.o.
> vot Vision Optical Technology Co., Ltd.
> +wi2wi Wi2Wi
Wrong spot.
> wd Western Digital Corp.
> wetek WeTek Electronics, limited.
> wexler Wexler
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-04-25 18:25 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 16:34 [PATCH 0/7] gnss: add new GNSS subsystem Johan Hovold
2018-04-24 16:34 ` [PATCH 1/7] gnss: add GNSS receiver subsystem Johan Hovold
2018-04-25 8:56 ` Greg Kroah-Hartman
2018-04-25 10:56 ` Johan Hovold
2018-04-25 12:23 ` Johan Hovold
2018-04-29 13:35 ` Greg Kroah-Hartman
2018-05-02 7:57 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 2/7] dt-bindings: add generic gnss binding Johan Hovold
2018-04-25 18:26 ` Rob Herring
2018-04-24 16:34 ` [PATCH 3/7] gnss: add generic serial driver Johan Hovold
2018-04-25 8:57 ` Greg Kroah-Hartman
2018-04-25 10:58 ` Johan Hovold
2018-04-25 9:00 ` Greg Kroah-Hartman
2018-04-25 11:05 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Johan Hovold
2018-04-25 18:16 ` Rob Herring
2018-04-26 9:10 ` Johan Hovold
2018-05-01 14:05 ` Rob Herring
2018-05-02 8:16 ` Johan Hovold
2018-05-02 13:16 ` Rob Herring
2018-05-07 9:06 ` Johan Hovold
2018-05-03 9:35 ` H. Nikolaus Schaller
2018-05-03 18:50 ` Andreas Kemnade
2018-05-04 5:16 ` H. Nikolaus Schaller
2018-05-04 11:42 ` Sebastian Reichel
2018-05-04 12:04 ` H. Nikolaus Schaller
2018-05-04 13:37 ` Sebastian Reichel
2018-05-04 14:29 ` Tony Lindgren
2018-05-07 10:07 ` Johan Hovold
2018-05-07 10:01 ` Johan Hovold
2018-05-07 15:45 ` Tony Lindgren
2018-05-07 16:34 ` Johan Hovold
2018-05-07 17:50 ` Tony Lindgren
2018-05-08 6:58 ` Johan Hovold
2018-05-08 15:22 ` Tony Lindgren
2018-05-08 15:47 ` Tony Lindgren
2018-05-08 15:54 ` Tony Lindgren
2018-05-08 16:49 ` Tony Lindgren
2018-05-09 13:10 ` OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding)) Johan Hovold
2018-05-09 13:57 ` Tony Lindgren
2018-05-17 10:09 ` Johan Hovold
2018-05-17 17:10 ` Tony Lindgren
2018-05-21 13:48 ` Johan Hovold
2018-05-21 15:48 ` Tony Lindgren
2018-05-24 9:17 ` Johan Hovold
2018-05-24 13:32 ` Tony Lindgren
2018-05-25 14:02 ` Johan Hovold
2018-05-08 15:56 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Sebastian Reichel
2018-05-09 9:18 ` Serdev runtime PM (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding) Johan Hovold
2018-05-09 9:49 ` Johan Hovold
2018-05-09 14:05 ` Tony Lindgren
2018-05-17 10:25 ` Johan Hovold
2018-05-07 9:47 ` [PATCH 4/7] dt-bindings: gnss: add u-blox binding Johan Hovold
2018-04-24 16:34 ` [PATCH 5/7] gnss: add driver for u-blox receivers Johan Hovold
2018-04-24 16:34 ` [PATCH 6/7] dt-bindings: gnss: add sirfstar binding Johan Hovold
2018-04-25 18:25 ` Rob Herring [this message]
2018-04-26 9:12 ` Johan Hovold
2018-04-24 16:34 ` [PATCH 7/7] gnss: add driver for sirfstar-based receivers Johan Hovold
2018-04-24 17:40 ` [PATCH 0/7] gnss: add new GNSS subsystem H. Nikolaus Schaller
2018-04-24 17:50 ` Johan Hovold
2018-04-24 19:44 ` H. Nikolaus Schaller
2018-04-25 8:11 ` Johan Hovold
2018-04-26 10:10 ` H. Nikolaus Schaller
2018-04-26 18:21 ` Johan Hovold
2018-04-24 20:13 ` Pavel Machek
2018-04-24 20:59 ` Andreas Kemnade
2018-04-25 7:32 ` Johan Hovold
2018-04-25 6:49 ` Marcel Holtmann
2018-04-25 7:24 ` Johan Hovold
2018-04-24 20:38 ` Pavel Machek
2018-04-25 6:26 ` Pavel Machek
2018-04-25 6:51 ` Johan Hovold
2018-04-25 8:48 ` Greg Kroah-Hartman
2018-04-25 10:31 ` Johan Hovold
2018-05-04 13:27 ` Sebastian Reichel
2018-05-04 20:03 ` Pavel Machek
2018-05-05 17:28 ` Sebastian Reichel
2018-05-05 21:11 ` Pavel Machek
2018-05-06 6:47 ` Marcel Holtmann
2018-05-07 10:20 ` Johan Hovold
2018-05-07 19:06 ` Marcel Holtmann
2018-05-08 7:01 ` Johan Hovold
2018-05-08 7:49 ` Marcel Holtmann
2018-05-08 12:48 ` Johan Hovold
2018-05-08 20:03 ` Marcel Holtmann
2018-05-30 10:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+nj9P5z=Ao=UbS-AKy+qeM98EFJiHmYgoniD_4N3Hr4w@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.