From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932E6C433EF for ; Mon, 27 Sep 2021 19:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7256360FED for ; Mon, 27 Sep 2021 19:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230015AbhI0TeA (ORCPT ); Mon, 27 Sep 2021 15:34:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhI0Td7 (ORCPT ); Mon, 27 Sep 2021 15:33:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52F2560FED; Mon, 27 Sep 2021 19:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632771141; bh=jIkeeH/D0+ndj+aMT/vg1wyVHZaKFaSNfGF3n68P8fw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ODcAKe5KZbR/hPTYuDzzxaIAtPbeWJga+8Ry+Ts/A7c5/K7Qpr8U3exQN+Ce+PMJI xPjmWmcbJOfcPCNv3xsX+Kietfb1TObXIV5VP+ncVUt/nqadBvOIVMajPG0HnjxhOD hUml3NfCSeSF2wxmAJ82q0BSA8/I/RCyNorbTSGft34gm1jopah/cjG1lup3LsreO9 CNLX5lzySc65o9jKMt+M6FoBvnuP16rOMA1ptwVCA/gD67Ypm91BIoijxNWmF1GFYx z0qDEGcOpaIDAgHaF3GQBojAehxvMX2Z0M2uYMTmxVOmnie+y8MHOv1LQ5DvhLUjIl iBJOR5BNxYTFA== Received: by mail-ed1-f50.google.com with SMTP id l8so26007780edw.2; Mon, 27 Sep 2021 12:32:21 -0700 (PDT) X-Gm-Message-State: AOAM531sdJX2+uY5xYCyYXT681O7dLXW/7QhLAijKZEIUKLsyobdN+3z imRq1HRGOdrfRxGin0KbWCD1imxxWCckNLvYVg== X-Google-Smtp-Source: ABdhPJy6Z59t66ELIvnrIT/bFIr4I3crn2zTrXliPgOM8IX1ESIPu3+rZon0Po+vg9STlpSYfOdW2P2RVnlLZHDV2uc= X-Received: by 2002:a17:906:7145:: with SMTP id z5mr1942466ejj.363.1632771139871; Mon, 27 Sep 2021 12:32:19 -0700 (PDT) MIME-Version: 1.0 References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-2-f.fainelli@gmail.com> In-Reply-To: <20210924170546.805663-2-f.fainelli@gmail.com> From: Rob Herring Date: Mon, 27 Sep 2021 14:32:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/11] arch: Export cpu_logical_map to modules To: Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Thomas Gleixner , Marc Zyngier , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Fri, Sep 24, 2021 at 12:06 PM Florian Fainelli wrote: > > In order to allow drivers/irqchip/irq-bcm7038-l1.c to be built as a > module and usable in GKI, export cpu_logical_map or __cpu_logical_map > towards the modules. This is the usage: #ifdef CONFIG_SMP cpu = intc->cpus[cpu_logical_map(smp_processor_id())]; #else cpu = intc->cpus[0]; #endif This is totally broken! cpu_logical_map() takes the logical cpu number, 0-N, and returns the MPIDR which you then use as an array index. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8D5C433F5 for ; Mon, 27 Sep 2021 19:34:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23037608FB for ; Mon, 27 Sep 2021 19:34:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 23037608FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UB15QP+jcAoUE+uqrKMoLf+Vhk8ejt9W+PCYqupDDXE=; b=aXbMfLIfAtwMa+ vQ0a/Gtvf2w7j8O5gGcaZXAh1JUcs+lxVUO72bm9koPHXEKxUHSaZiW6+mjAQxhBmWz2B7FFe4EoR VVVO7MOj8EjbvG4XBkcwZw/ZmSmP4OrA6wH5vyuYPEVrLlX/CWxqKADDj6SObwfijEDZDg5z8OVyc Nh2RFljPYzLW4NUjC0ge2wu+LSsRSm80N4uPIJlZ7wNnmx3XOx2+ZOv77dBm0DqYzFpYALJbluX1s a/FLlQE1x0BXY5IyuHlhltud3SUBUc3LkQEiP34N+m2tEFT24imoNpAFnlTaVJ21AhPgDEcBYjJ3j qzfWpa4HWZjoesKYT+/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUwMU-00403S-0s; Mon, 27 Sep 2021 19:32:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUwMP-00402L-R6 for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 19:32:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F47A6113A for ; Mon, 27 Sep 2021 19:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632771141; bh=jIkeeH/D0+ndj+aMT/vg1wyVHZaKFaSNfGF3n68P8fw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ODcAKe5KZbR/hPTYuDzzxaIAtPbeWJga+8Ry+Ts/A7c5/K7Qpr8U3exQN+Ce+PMJI xPjmWmcbJOfcPCNv3xsX+Kietfb1TObXIV5VP+ncVUt/nqadBvOIVMajPG0HnjxhOD hUml3NfCSeSF2wxmAJ82q0BSA8/I/RCyNorbTSGft34gm1jopah/cjG1lup3LsreO9 CNLX5lzySc65o9jKMt+M6FoBvnuP16rOMA1ptwVCA/gD67Ypm91BIoijxNWmF1GFYx z0qDEGcOpaIDAgHaF3GQBojAehxvMX2Z0M2uYMTmxVOmnie+y8MHOv1LQ5DvhLUjIl iBJOR5BNxYTFA== Received: by mail-ed1-f45.google.com with SMTP id o23so1646138edt.12 for ; Mon, 27 Sep 2021 12:32:21 -0700 (PDT) X-Gm-Message-State: AOAM533v+ijdUrSMA8wQSnLq3z9XhoFxEH+TJrGLiUP/t8v/+67tF68u FFq1NF55zOxrajLrDEv2faFjE6SGEM/NY2hNSw== X-Google-Smtp-Source: ABdhPJy6Z59t66ELIvnrIT/bFIr4I3crn2zTrXliPgOM8IX1ESIPu3+rZon0Po+vg9STlpSYfOdW2P2RVnlLZHDV2uc= X-Received: by 2002:a17:906:7145:: with SMTP id z5mr1942466ejj.363.1632771139871; Mon, 27 Sep 2021 12:32:19 -0700 (PDT) MIME-Version: 1.0 References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-2-f.fainelli@gmail.com> In-Reply-To: <20210924170546.805663-2-f.fainelli@gmail.com> From: Rob Herring Date: Mon, 27 Sep 2021 14:32:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/11] arch: Export cpu_logical_map to modules To: Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Thomas Gleixner , Marc Zyngier , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_123221_915416_D19C852B X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 12:06 PM Florian Fainelli wrote: > > In order to allow drivers/irqchip/irq-bcm7038-l1.c to be built as a > module and usable in GKI, export cpu_logical_map or __cpu_logical_map > towards the modules. This is the usage: #ifdef CONFIG_SMP cpu = intc->cpus[cpu_logical_map(smp_processor_id())]; #else cpu = intc->cpus[0]; #endif This is totally broken! cpu_logical_map() takes the logical cpu number, 0-N, and returns the MPIDR which you then use as an array index. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel