From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 030D8C43460 for ; Tue, 13 Apr 2021 13:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBF23611C9 for ; Tue, 13 Apr 2021 13:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344260AbhDMNNa (ORCPT ); Tue, 13 Apr 2021 09:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbhDMNN1 (ORCPT ); Tue, 13 Apr 2021 09:13:27 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3961C061574 for ; Tue, 13 Apr 2021 06:13:07 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id l22so11925579ljc.9 for ; Tue, 13 Apr 2021 06:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uvM1xLNFtbjboqLjbQwMRXz9XirPXm1IZpwvJNf/xI4=; b=lQZzbGEfuKkQNZ0EyqnQ+GDHJ632xxU1Ko4KVYLh7r2DgevxDm8Ixs5cgBJbOY11bY aKSQD78mYWqTJYDhDZH7ZXQMqQHl/OPQX1o/RRH8ez+cRwjDu9Air/9t29L4nsiCx4H8 WBH9B89PlSK0j8MzsWkjcc3Yd2niQQ/+m1GyopJpOLu57BDCqUgftJ5Ofvdge8xQCsPR 2ZYiyBTIZgviLzV+oPn8mE8FXD0d5am7aTV7b3j6tcQ/HYI1efje9k2T96dLQJ75xPo/ KJx1g1MdRXU85Mrmd+C6idriGcclZaSthpPTMiKS0NzTntPodW8U1ID8rmI6KvcV70Gd V2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uvM1xLNFtbjboqLjbQwMRXz9XirPXm1IZpwvJNf/xI4=; b=gwsXCORY+qCWeUIiPNjcFIibHEVy7NaZhPLwBczThDE/YiEtgr21hDSMy9k8uhRE37 7a4xpEoYYDm920FMKKy8wERqEtLHRgE66oDOy9t54P6MZ+QQ3lNL6Z0rRRScvQ/yi/Qx ZZT74V2dVkvauBx9pR7H5yrEcVmCbjEQuxqtRYHIX/G+QA7EMG2LdzHU1UUI037nc0Jg OjlYmwUUJOVKWP8M/odSjHfWKWjrSw/+qamIaitxbTP42eJQhQSQpSHBWGS63ZYaQzHv WRgB1j8pthNsNAmnEq/MA0oYOtlTm4l8CeXIl7ELVdjo6FUQ/f8id6fhsp93d4oxCQmB 088Q== X-Gm-Message-State: AOAM530lFKe2k20tXpRg6EdAkcnUILaSACjdJQXIWTD/CmpfBO+tvGP5 aQsf2ebowQBD4+Qj1FlFUGG1g9cM+pfOHB4J8I3XwA== X-Google-Smtp-Source: ABdhPJxwz8N7PrvB9rmwq4vzGOdn7BiHIWYtOzqHgwkSiT0s1Tl3lnWu5UIgLuha/if0KcD8ZJreMYmnUKvNQyKkA7k= X-Received: by 2002:a2e:968a:: with SMTP id q10mr10830963lji.0.1618319585941; Tue, 13 Apr 2021 06:13:05 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-4-songmuchun@bytedance.com> In-Reply-To: <20210413065153.63431-4-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 13 Apr 2021 06:12:54 -0700 Message-ID: Subject: Re: [PATCH 3/7] mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 11:57 PM Muchun Song wrote: > > All the callers of mem_cgroup_page_lruvec() just pass page_pgdat(page) > as the 2nd parameter to it (except isolate_migratepages_block()). But > for isolate_migratepages_block(), the page_pgdat(page) is also equal > to the local variable of @pgdat. So mem_cgroup_page_lruvec() do not > need the pgdat parameter. Just remove it to simplify the code. > > Signed-off-by: Muchun Song > Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC32C433B4 for ; Tue, 13 Apr 2021 13:13:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 516CA6124B for ; Tue, 13 Apr 2021 13:13:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 516CA6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A08296B0036; Tue, 13 Apr 2021 09:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8C36B006E; Tue, 13 Apr 2021 09:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8588D6B0070; Tue, 13 Apr 2021 09:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 6541D6B0036 for ; Tue, 13 Apr 2021 09:13:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2140DA4A46 for ; Tue, 13 Apr 2021 13:13:08 +0000 (UTC) X-FDA: 78027384456.30.FA930B3 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf17.hostedemail.com (Postfix) with ESMTP id 9373440002CF for ; Tue, 13 Apr 2021 13:13:05 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id l14so16389269ljb.1 for ; Tue, 13 Apr 2021 06:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uvM1xLNFtbjboqLjbQwMRXz9XirPXm1IZpwvJNf/xI4=; b=lQZzbGEfuKkQNZ0EyqnQ+GDHJ632xxU1Ko4KVYLh7r2DgevxDm8Ixs5cgBJbOY11bY aKSQD78mYWqTJYDhDZH7ZXQMqQHl/OPQX1o/RRH8ez+cRwjDu9Air/9t29L4nsiCx4H8 WBH9B89PlSK0j8MzsWkjcc3Yd2niQQ/+m1GyopJpOLu57BDCqUgftJ5Ofvdge8xQCsPR 2ZYiyBTIZgviLzV+oPn8mE8FXD0d5am7aTV7b3j6tcQ/HYI1efje9k2T96dLQJ75xPo/ KJx1g1MdRXU85Mrmd+C6idriGcclZaSthpPTMiKS0NzTntPodW8U1ID8rmI6KvcV70Gd V2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uvM1xLNFtbjboqLjbQwMRXz9XirPXm1IZpwvJNf/xI4=; b=prnwNgifO7nPJDm5qVzxCpUSgJFpDCeqIVN3YZdkd07mO8pffkMVYVrMa7dgjtno4q 8m+Phg7mj8yS2o7BMEB945zAyvb8HUh1D/hki0iR8WCI36JLSGUKU+kyHtBnPifPGP+8 W4TVek2NLqUUZJ7bmjrHgaslm2vqbSU9HTENJDi199VSQJl9IMhGicb4sQ6JHPrMfD7K TWs8NSWL7tWQ3/PBO673EU7yBrNphxSuAkCJ41RCzMltoJGX5ssm7sTP0E6OY6IB2OcV yAooxChWNbzdaoDXbdfg27aYx4yRztFn35unkNvVx7zDHWBPfYgM3vVnnMaivQiHSaRC 3n1Q== X-Gm-Message-State: AOAM530eycXE/MMBtvc62PQSb4WdbCFRCGxEPZFuW3Exyf/AB8oM+XIU lbhjVP+BYPZcBj9DJwX1xiYyuQdbSiRl6CBMz2KcDA== X-Google-Smtp-Source: ABdhPJxwz8N7PrvB9rmwq4vzGOdn7BiHIWYtOzqHgwkSiT0s1Tl3lnWu5UIgLuha/if0KcD8ZJreMYmnUKvNQyKkA7k= X-Received: by 2002:a2e:968a:: with SMTP id q10mr10830963lji.0.1618319585941; Tue, 13 Apr 2021 06:13:05 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-4-songmuchun@bytedance.com> In-Reply-To: <20210413065153.63431-4-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 13 Apr 2021 06:12:54 -0700 Message-ID: Subject: Re: [PATCH 3/7] mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9373440002CF X-Stat-Signature: 5tnoyej8i6c98tpfc9n985zd8eqjt7if X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-lj1-f171.google.com; client-ip=209.85.208.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618319585-969340 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 11:57 PM Muchun Song wrote: > > All the callers of mem_cgroup_page_lruvec() just pass page_pgdat(page) > as the 2nd parameter to it (except isolate_migratepages_block()). But > for isolate_migratepages_block(), the page_pgdat(page) is also equal > to the local variable of @pgdat. So mem_cgroup_page_lruvec() do not > need the pgdat parameter. Just remove it to simplify the code. > > Signed-off-by: Muchun Song > Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt