From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753B5C636CB for ; Fri, 16 Jul 2021 19:24:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D106613F8 for ; Fri, 16 Jul 2021 19:24:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D106613F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD5DC6E9D1; Fri, 16 Jul 2021 19:24:19 +0000 (UTC) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D28A6E9CF; Fri, 16 Jul 2021 19:24:18 +0000 (UTC) Received: by mail-qv1-xf2c.google.com with SMTP id i4so5111297qvq.10; Fri, 16 Jul 2021 12:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8Tlcfwlh61VvBfUuFwx0JAkGhthlhwqsds2zjxw3FFc=; b=nyCHzGNzvyIOfv/0FnBGg2DfPyQdxi/zLxb5Pr85zPf25qE6ER/dCG0Lx3RloP9lbZ F1loKvZHTgFw3KWOy0nEoPT+gMnMKsxTTFT7zD2CB7g9nFaM9O+WZoaGAaKQkUM5CSFF RrMhHgoHEYJapxHOcrxwItpPs6LMLEj1m8Tro4wTT3DlNj3jJ/ix4umOgzl4VxO8CG/e ZutPBOQkuV91Qb2YIChP/mX5DNAPddgNjnWu9duOjTjqBY5FgkM2hG/tP+ViB6EMIBSW tjibZXcUqRqMuxh617i/gP/elp7xt7TZbm+GOlHbWLq7oQo+mgWBfxaO2QVLVoDRFpJQ u+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8Tlcfwlh61VvBfUuFwx0JAkGhthlhwqsds2zjxw3FFc=; b=NgAAUPvBdSLdV7VVea1WWL7Jqdv/fXViMNpxyHHSYmVOeeifEH5Dau1m+AMP0M66zA qjbTh5m4DrOv8jWihPLxuJobsyhuwCPPdTjRb4AGuNIWFwi0J678SRLUAlOXZngc0Ypt 4DQywBiISQrlJwYOCg5UZRfTXkxISeHitapiK2zH5sRjVerwrlpvEdbApkYfLLFxLTm8 P15f8frK2WR4wAxCDJzijj1EWMaQlz4ufM2DsNMBN0beAgLFvODZ47ft+4q54mIZ3/iN Rdmv071kkBlYS+R3zpyqa8n4NLLrzA4ePVd60wDBAD0qukdmh9/jnzRMwOJKzok4clpi FWyQ== X-Gm-Message-State: AOAM530IaL59h4Im9ADMGaqUzFLjbdqEslgvbP+3UVgsSpuf+zT1W3UX SL5jSLSVGqjM1vWBQUxXlJHFAWD22XdSCVGe1/o= X-Google-Smtp-Source: ABdhPJzR39No7NPmXgI1WMgWZlGXlv0Mfvg3s23OIIdqdq0v8oksApsGB/29vPHAU51Hvr6VjC4l/IytetqtYG4Tjkw= X-Received: by 2002:a0c:f6c6:: with SMTP id d6mr11898323qvo.30.1626463457392; Fri, 16 Jul 2021 12:24:17 -0700 (PDT) MIME-Version: 1.0 References: <20210716141426.1904528-1-jason@jlekstrand.net> <20210716141426.1904528-6-jason@jlekstrand.net> In-Reply-To: <20210716141426.1904528-6-jason@jlekstrand.net> From: Matthew Auld Date: Fri, 16 Jul 2021 20:23:51 +0100 Message-ID: Subject: Re: [Intel-gfx] [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj To: Jason Ekstrand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Intel Graphics Development , Matthew Auld , ML dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand wrote: > > Whenever we had a user object (n_placements > 0), we were ignoring > obj->mm.region and always putting obj->placements[0] as the requested > region. For LMEM+SMEM objects, this was causing them to get shoved into > LMEM on every i915_ttm_get_pages() even when SMEM was requested by, say, > i915_gem_object_migrate(). > > Signed-off-by: Jason Ekstrand > Cc: Thomas Hellstr=C3=B6m > Cc: Matthew Auld > Cc: Maarten Lankhorst AFAIK makes sense, just a question of properly understanding that weird migration issue first. Assuming CI is happy, Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i9= 15/gem/i915_gem_ttm.c > index 6589411396d3f..8eeb73c7c401c 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c > @@ -150,8 +150,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem= _object *obj, > unsigned int i; > > placement->num_placement =3D 1; > - i915_ttm_place_from_region(num_allowed ? obj->mm.placements[0] : > - obj->mm.region, requested, flags); > + i915_ttm_place_from_region(obj->mm.region, requested, flags); > > /* Cache this on object? */ > placement->num_busy_placement =3D num_allowed; > -- > 2.31.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46AF5C12002 for ; Fri, 16 Jul 2021 19:24:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A7AB613FB for ; Fri, 16 Jul 2021 19:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A7AB613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A01456E9CF; Fri, 16 Jul 2021 19:24:19 +0000 (UTC) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D28A6E9CF; Fri, 16 Jul 2021 19:24:18 +0000 (UTC) Received: by mail-qv1-xf2c.google.com with SMTP id i4so5111297qvq.10; Fri, 16 Jul 2021 12:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8Tlcfwlh61VvBfUuFwx0JAkGhthlhwqsds2zjxw3FFc=; b=nyCHzGNzvyIOfv/0FnBGg2DfPyQdxi/zLxb5Pr85zPf25qE6ER/dCG0Lx3RloP9lbZ F1loKvZHTgFw3KWOy0nEoPT+gMnMKsxTTFT7zD2CB7g9nFaM9O+WZoaGAaKQkUM5CSFF RrMhHgoHEYJapxHOcrxwItpPs6LMLEj1m8Tro4wTT3DlNj3jJ/ix4umOgzl4VxO8CG/e ZutPBOQkuV91Qb2YIChP/mX5DNAPddgNjnWu9duOjTjqBY5FgkM2hG/tP+ViB6EMIBSW tjibZXcUqRqMuxh617i/gP/elp7xt7TZbm+GOlHbWLq7oQo+mgWBfxaO2QVLVoDRFpJQ u+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8Tlcfwlh61VvBfUuFwx0JAkGhthlhwqsds2zjxw3FFc=; b=NgAAUPvBdSLdV7VVea1WWL7Jqdv/fXViMNpxyHHSYmVOeeifEH5Dau1m+AMP0M66zA qjbTh5m4DrOv8jWihPLxuJobsyhuwCPPdTjRb4AGuNIWFwi0J678SRLUAlOXZngc0Ypt 4DQywBiISQrlJwYOCg5UZRfTXkxISeHitapiK2zH5sRjVerwrlpvEdbApkYfLLFxLTm8 P15f8frK2WR4wAxCDJzijj1EWMaQlz4ufM2DsNMBN0beAgLFvODZ47ft+4q54mIZ3/iN Rdmv071kkBlYS+R3zpyqa8n4NLLrzA4ePVd60wDBAD0qukdmh9/jnzRMwOJKzok4clpi FWyQ== X-Gm-Message-State: AOAM530IaL59h4Im9ADMGaqUzFLjbdqEslgvbP+3UVgsSpuf+zT1W3UX SL5jSLSVGqjM1vWBQUxXlJHFAWD22XdSCVGe1/o= X-Google-Smtp-Source: ABdhPJzR39No7NPmXgI1WMgWZlGXlv0Mfvg3s23OIIdqdq0v8oksApsGB/29vPHAU51Hvr6VjC4l/IytetqtYG4Tjkw= X-Received: by 2002:a0c:f6c6:: with SMTP id d6mr11898323qvo.30.1626463457392; Fri, 16 Jul 2021 12:24:17 -0700 (PDT) MIME-Version: 1.0 References: <20210716141426.1904528-1-jason@jlekstrand.net> <20210716141426.1904528-6-jason@jlekstrand.net> In-Reply-To: <20210716141426.1904528-6-jason@jlekstrand.net> From: Matthew Auld Date: Fri, 16 Jul 2021 20:23:51 +0100 Message-ID: To: Jason Ekstrand Subject: Re: [Intel-gfx] [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Intel Graphics Development , Matthew Auld , ML dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCAxNiBKdWwgMjAyMSBhdCAxNToxNCwgSmFzb24gRWtzdHJhbmQgPGphc29uQGpsZWtz dHJhbmQubmV0PiB3cm90ZToKPgo+IFdoZW5ldmVyIHdlIGhhZCBhIHVzZXIgb2JqZWN0IChuX3Bs YWNlbWVudHMgPiAwKSwgd2Ugd2VyZSBpZ25vcmluZwo+IG9iai0+bW0ucmVnaW9uIGFuZCBhbHdh eXMgcHV0dGluZyBvYmotPnBsYWNlbWVudHNbMF0gYXMgdGhlIHJlcXVlc3RlZAo+IHJlZ2lvbi4g IEZvciBMTUVNK1NNRU0gb2JqZWN0cywgdGhpcyB3YXMgY2F1c2luZyB0aGVtIHRvIGdldCBzaG92 ZWQgaW50bwo+IExNRU0gb24gZXZlcnkgaTkxNV90dG1fZ2V0X3BhZ2VzKCkgZXZlbiB3aGVuIFNN RU0gd2FzIHJlcXVlc3RlZCBieSwgc2F5LAo+IGk5MTVfZ2VtX29iamVjdF9taWdyYXRlKCkuCj4K PiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxla3N0cmFuZC5uZXQ+Cj4g Q2M6IFRob21hcyBIZWxsc3Ryw7ZtIDx0aG9tYXMuaGVsbHN0cm9tQGxpbnV4LmludGVsLmNvbT4K PiBDYzogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgo+IENjOiBNYWFydGVu IExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKQUZBSUsgbWFr ZXMgc2Vuc2UsIGp1c3QgYSBxdWVzdGlvbiBvZiBwcm9wZXJseSB1bmRlcnN0YW5kaW5nIHRoYXQK d2VpcmQgbWlncmF0aW9uIGlzc3VlIGZpcnN0LgoKQXNzdW1pbmcgQ0kgaXMgaGFwcHksClJldmll d2VkLWJ5OiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRlbC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fdHRtLmMgfCAzICstLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX3R0bS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZ2VtL2k5MTVfZ2VtX3R0bS5jCj4gaW5kZXggNjU4OTQxMTM5NmQzZi4uOGVlYjczYzdj NDAxYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fdHRt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fdHRtLmMKPiBAQCAt MTUwLDggKzE1MCw3IEBAIGk5MTVfdHRtX3BsYWNlbWVudF9mcm9tX29iaihjb25zdCBzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgICAgICAgdW5zaWduZWQgaW50IGk7Cj4KPiAg ICAgICAgIHBsYWNlbWVudC0+bnVtX3BsYWNlbWVudCA9IDE7Cj4gLSAgICAgICBpOTE1X3R0bV9w bGFjZV9mcm9tX3JlZ2lvbihudW1fYWxsb3dlZCA/IG9iai0+bW0ucGxhY2VtZW50c1swXSA6Cj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvYmotPm1tLnJlZ2lvbiwgcmVxdWVz dGVkLCBmbGFncyk7Cj4gKyAgICAgICBpOTE1X3R0bV9wbGFjZV9mcm9tX3JlZ2lvbihvYmotPm1t LnJlZ2lvbiwgcmVxdWVzdGVkLCBmbGFncyk7Cj4KPiAgICAgICAgIC8qIENhY2hlIHRoaXMgb24g b2JqZWN0PyAqLwo+ICAgICAgICAgcGxhY2VtZW50LT5udW1fYnVzeV9wbGFjZW1lbnQgPSBudW1f YWxsb3dlZDsKPiAtLQo+IDIuMzEuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=