From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04966C433EF for ; Tue, 8 Feb 2022 19:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385924AbiBHTRG (ORCPT ); Tue, 8 Feb 2022 14:17:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385912AbiBHTRE (ORCPT ); Tue, 8 Feb 2022 14:17:04 -0500 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A76AC0613CB; Tue, 8 Feb 2022 11:17:02 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id z19so35140644lfq.13; Tue, 08 Feb 2022 11:17:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JaoHziOwSYqy0wTWrxCWrGSPLMiaVVe/sOp7KuqGagE=; b=zsIr9cx19AHQ8dFaCgZ88p3rlVikFD7aeqSYIKMNSBzN9H6K3xUdW+7KlAVTetfomA k0kg4lGsiTWPN9FvTHbpkQeknXlQF41SezZaPOlgAuFRnxJOBn/pvS6LCT94FemSPDQo xQ2lhAqYWZ1ixbw31glOyXt86VTDBqYlaLiczwoU8soloc90oeE7gV8L+O1rfgeTmuzu GhY5ZaRXpOED04giIEvftsdNO4fXprx13FJky6zZq1jgBzghLXMd4oj7C6sqMcIKjSYq /QWU8l4f/0GfkyM7N/nnHSPreszpWF6Hv3UxwE51lGNHUev984Qj/+5yjLgaRywgemHp VvpA== X-Gm-Message-State: AOAM531VHby/Mz0s/7Ka6Rgh90bBztz0MTxhr8GbkL77MSDWwrmax1ov czoefASXl291TeBxIZOGofh+Ew9xWfpw97Xt824= X-Google-Smtp-Source: ABdhPJzTXJ6stf2QPxiYffdaSUv6Lqs25/4OYa4M2UmF8wSE+vpSmPNxe/r1A2PGislK43syDvGXv6LsFpoFWy6yOrI= X-Received: by 2002:ac2:46ed:: with SMTP id q13mr3843084lfo.99.1644347817769; Tue, 08 Feb 2022 11:16:57 -0800 (PST) MIME-Version: 1.0 References: <20220208184208.79303-1-namhyung@kernel.org> <20220208184208.79303-3-namhyung@kernel.org> In-Reply-To: From: Namhyung Kim Date: Tue, 8 Feb 2022 11:16:46 -0800 Message-ID: Subject: Re: [PATCH 02/12] cgroup: rstat: Make cgroup_rstat_cpu_lock name readable To: Tejun Heo Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , LKML , Thomas Gleixner , Steven Rostedt , Byungchul Park , Mathieu Desnoyers , Radoslaw Burny , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, paulmck@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Tue, Feb 8, 2022 at 10:46 AM Tejun Heo wrote: > > On Tue, Feb 08, 2022 at 10:41:58AM -0800, Namhyung Kim wrote: > > The raw_spin_lock_init() uses the argument to name its lockdep map. > > But passing per_cpu_ptr() macro directly makes it a very very long > > name as it expanded like below: > > > > ({ do { const void *__vpp_verify = (typeof((&cgroup_rstat_cpu_lock) ... > > > > Let's fix it by passing a local variable instead. With this change, > > the name now looks like: > > > > cgrp_rstat_cpu_lock > > > > Cc: Tejun Heo > > Cc: Zefan Li > > Cc: Johannes Weiner > > Cc: cgroups@vger.kernel.org > > Signed-off-by: Namhyung Kim > > Acked-by: Tejun Heo Thanks! > > but maybe add a comment explaining what's going on? Sure, I'll add the comment. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namhyung Kim Subject: Re: [PATCH 02/12] cgroup: rstat: Make cgroup_rstat_cpu_lock name readable Date: Tue, 8 Feb 2022 11:16:46 -0800 Message-ID: References: <20220208184208.79303-1-namhyung@kernel.org> <20220208184208.79303-3-namhyung@kernel.org> Mime-Version: 1.0 Return-path: In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , LKML , Thomas Gleixner , Steven Rostedt , Byungchul Park , Mathieu Desnoyers , Radoslaw Burny , Zefan Li , Johannes Weiner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paulmck-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Hi Tejun, On Tue, Feb 8, 2022 at 10:46 AM Tejun Heo wrote: > > On Tue, Feb 08, 2022 at 10:41:58AM -0800, Namhyung Kim wrote: > > The raw_spin_lock_init() uses the argument to name its lockdep map. > > But passing per_cpu_ptr() macro directly makes it a very very long > > name as it expanded like below: > > > > ({ do { const void *__vpp_verify = (typeof((&cgroup_rstat_cpu_lock) ... > > > > Let's fix it by passing a local variable instead. With this change, > > the name now looks like: > > > > cgrp_rstat_cpu_lock > > > > Cc: Tejun Heo > > Cc: Zefan Li > > Cc: Johannes Weiner > > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Signed-off-by: Namhyung Kim > > Acked-by: Tejun Heo Thanks! > > but maybe add a comment explaining what's going on? Sure, I'll add the comment.