From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CBCC4727C for ; Thu, 1 Oct 2020 09:45:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBA742087D for ; Thu, 1 Oct 2020 09:45:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="GzaYPDdc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731757AbgJAJph (ORCPT ); Thu, 1 Oct 2020 05:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726992AbgJAJpg (ORCPT ); Thu, 1 Oct 2020 05:45:36 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ACC9C0613E2 for ; Thu, 1 Oct 2020 02:45:34 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id md26so1419018ejb.10 for ; Thu, 01 Oct 2020 02:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZDdA2zY8D0de7pamktpQczyQ0hFmRGKGBWlU1/8ZIU=; b=GzaYPDdcHi7fM0Xb/kj1vWF/5NtJ3RfOuBsBs0TYwYGWmC2hF27bO/JVp+QoXI07Nv 3wUVGBNHIMoAwly774K6sTazqDNKSOe22PcM4ilkykogaT4RRTvcpEnayrF6CHCMtOlE ixBTSnRZpIkfgQS5zzKXFjnO6aHUJdE9e86esmBNZ7RMajhTDNBwPBpUne+mOLfVdbzN zzMv5Cmjvnu/WqdWPmqzF9XQUmaG5ekpi3z4LS+3xUsVKJv8+VsigpU/dQ9uL1b6hsES XimI3RHnPb02uwh0EnTayw2n7b9mxWlyFywK7UEtV2GeYssOCJ6sxf3Rv6K1e3A82LYo q8mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZDdA2zY8D0de7pamktpQczyQ0hFmRGKGBWlU1/8ZIU=; b=KWRIPXUVgFczPSeYtCGLfTbAk7Z6kFiz7LVGGBydlxAT8f1tmuBFbdIEEYGiYwFAD0 5iIy5Jq7MHPxTvqGgEWQ3QyGgYONMU8LPpqBx0iW9A9fSJAR4OgamLD7E38BWHIqR/Xf 83q2LTI9ESHo4mATvJmw8+r7ydkfCmnFGqu91I1Cc+4sb9DZlbalQA0Afyf/KTwERqbh l+vzj87yBmeYJFfhi+oqx6rEP9iuKfinYCwOsslAXRVq3qokoAWOkDbo7q5wHpNZI6YF jPylFgDFfLil3EKhw4FAmG62AjnJQPhUj1ivaM9898HKzer2YFTTEfvhL3CHfY8f4bih 1gYQ== X-Gm-Message-State: AOAM533KaRWLyE2G53874/qw+t3ZQ+81fqSd3379wf4tBFCnahNcZKlh zlICiBX9ou74ivHFIBK17YDQ2msnuP3BAChwGnJv5A== X-Google-Smtp-Source: ABdhPJxzHjAb6ADjhe+rmmZGGPZFt3ViF0VwPxP2wF4EZ7eISGKdHfVNhtMH0g9LAbWAQhBJuAnvWjTdotqtXVaiQN4= X-Received: by 2002:a17:906:9588:: with SMTP id r8mr6986248ejx.389.1601545532768; Thu, 01 Oct 2020 02:45:32 -0700 (PDT) MIME-Version: 1.0 References: <20201001072703.16256-1-gi-oh.kim@clous.ionos.com> In-Reply-To: <20201001072703.16256-1-gi-oh.kim@clous.ionos.com> From: Jinpu Wang Date: Thu, 1 Oct 2020 11:45:21 +0200 Message-ID: Subject: Re: [PATCH 2/2] RDMA/rtrs: check before free To: Gioh Kim Cc: Danil Kipnis , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Oct 1, 2020 at 9:27 AM Gioh Kim wrote: > > From: Gioh Kim > > If rtrs_iu_alloc failed to allocate buffer or map dma, > there are some allocated addresses and some NULL addresses > in the array. rtrs_iu_free should check data before free. > > Signed-off-by: Gioh Kim > --- > drivers/infiniband/ulp/rtrs/rtrs.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c > index 5163e662f86f..ca2d2d3e4192 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs.c > @@ -61,8 +61,12 @@ void rtrs_iu_free(struct rtrs_iu *ius, struct ib_device *ibdev, u32 queue_size) > > for (i = 0; i < queue_size; i++) { > iu = &ius[i]; > - ib_dma_unmap_single(ibdev, iu->dma_addr, iu->size, iu->direction); > - kfree(iu->buf); > + if (iu->dma_addr) { > + ib_dma_unmap_single(ibdev, iu->dma_addr, iu->size, iu->direction); > + } No need for bracket > + if (iu->buf) { > + kfree(iu->buf); > + } kfree checks NULL already. > } > kfree(ius); > } > -- > 2.20.1 >