From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82365C33CA2 for ; Wed, 8 Jan 2020 16:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 579172067D for ; Wed, 8 Jan 2020 16:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="bmjouH+x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgAHQdi (ORCPT ); Wed, 8 Jan 2020 11:33:38 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:45043 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbgAHQdi (ORCPT ); Wed, 8 Jan 2020 11:33:38 -0500 Received: by mail-io1-f67.google.com with SMTP id b10so3809994iof.11 for ; Wed, 08 Jan 2020 08:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O0qG6NRLqy7mvD6qvWnV9Y3yuCIMjNVmVlZXp2JZhAg=; b=bmjouH+xaoy8MBqnIfs6g7C1DwZUA7d0d++MibQVEEoiiyWq99Uo/+kCUoto589/6y Z8XWkR6sO7ZWkeS+aqqN47VO7fJr+exu1n0wuwVKOu72SkPrpNrpUQTL+BUh/XGcOkdo oV/+3LuT3Q77467cm59wy8p0ZkIP3mo6xlnMRwHzopwbwxlQiSQXwc5HH1y5h85BIBpP PVf6pEQ+A1XrjxU6MHi1vAdCgcNS56qedejnBZ5otMqZ7IZp0HjzGBANf/5MdEBblORj 6BFra9Uj5HGAH0zuIf9MZTeC/77mBlNAwNCQimFr0229Z1h7iUuD7k3MgH8OiQSt2Ygm gUuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O0qG6NRLqy7mvD6qvWnV9Y3yuCIMjNVmVlZXp2JZhAg=; b=jfoHhSey6AqDBxs+EegLCSQI1wWrY8dHQwUYwyiFe05QoJaPcZozkwKrTDIRUYTnoU iw59tDqwvkGlMEVv5JPYNvco4TQfMCMAsoqbXsQBpXJynRmWxq/RUwOkmDHbTfFYkbQg YIUXEepsMM2ISUQkiHAw3VYQYzP7ZvWYvFHLQGlcYYsBrWBIThI0QycnolKpb/21l9o8 JSR9VJTh/wRGIcWT6QSRVPt5s+1ajN/gegPJTsASiRys4iTAQssIcL7WbQh+yzEA6ATA Yi9GRj5Fok0p4eqv44+Ju1cpsXq3qhnhPr/6wcyYST+WiRzg9CtQgoQN7SKR2pZwhkLa PMLA== X-Gm-Message-State: APjAAAXKbJB9t/BT9UkrwnTFcQNFUukrijF9APOgC4G/eqsPms3y33f0 httnaV/QDEqruufr4Sulr2cYK0lfOfpeGO+wEVhqqg== X-Google-Smtp-Source: APXvYqxX4un718qenN/+gUObZZrZSck3SyOJJE+AABa0Mp+35gS4S1Ma/zLzbeA56VzoIOm6J/Oa9lz02gLwFXcTk8Q= X-Received: by 2002:a6b:6e02:: with SMTP id d2mr4124290ioh.22.1578501217592; Wed, 08 Jan 2020 08:33:37 -0800 (PST) MIME-Version: 1.0 References: <20191230102942.18395-1-jinpuwang@gmail.com> <20191230102942.18395-10-jinpuwang@gmail.com> <848cdafd-60c5-b656-1569-81644b7fc5df@acm.org> In-Reply-To: <848cdafd-60c5-b656-1569-81644b7fc5df@acm.org> From: Jinpu Wang Date: Wed, 8 Jan 2020 17:33:26 +0100 Message-ID: Subject: Re: [PATCH v6 09/25] rtrs: server: private header with server structs and functions To: Bart Van Assche Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Danil Kipnis , rpenyaev@suse.de Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jan 2, 2020 at 10:24 PM Bart Van Assche wrote: > > On 12/30/19 2:29 AM, Jack Wang wrote: > > +struct rtrs_stats_wc_comp { > > + atomic64_t calls; > > + atomic64_t total_wc_cnt; > > +}; > > Please document the meaning of the members of this data structure. will do. > > > +struct rtrs_srv_stats_rdma_stats { > > + struct { > > + atomic64_t cnt; > > + atomic64_t size_total; > > + } dir[2]; > > +}; > > Please document the meaning of the members of this data structure and > also which index (0, 1) corresponds to which direction (read, write). yes, will do. > > > +struct rtrs_srv_op { > > + struct rtrs_srv_con *con; > > + u32 msg_id; > > + u8 dir; > > + struct rtrs_msg_rdma_read *rd_msg; > > + struct ib_rdma_wr *tx_wr; > > + struct ib_sge *tx_sg; > > +}; > > Please document the role of this data structure. ok. > > > +struct rtrs_srv_mr { > > + struct ib_mr *mr; > > + struct sg_table sgt; > > + struct ib_cqe inv_cqe; /* only for always_invalidate=true */ > > + u32 msg_id; /* only for always_invalidate=true */ > > + u32 msg_off; /* only for always_invalidate=true */ > > + struct rtrs_iu *iu; /* send buffer for new rkey msg */ > > +}; > > Please document the role of this data structure. ok > > > +extern struct class *rtrs_dev_class; > > Please make sure that the static 'rtrs_dev_class' variable in rtrs-clt.c > and in this header file have different names. ok > > Thanks, > > Bart. Thanks