From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5F4C2D0C2 for ; Fri, 3 Jan 2020 14:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 131C721835 for ; Fri, 3 Jan 2020 14:39:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="F5lh6fAL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbgACOjp (ORCPT ); Fri, 3 Jan 2020 09:39:45 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:35964 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbgACOjp (ORCPT ); Fri, 3 Jan 2020 09:39:45 -0500 Received: by mail-io1-f66.google.com with SMTP id r13so31461950ioa.3 for ; Fri, 03 Jan 2020 06:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5RN9HFVC8/4wrj1xZ018jyfw28e2mD+SWO6pvdC3TeY=; b=F5lh6fALXVB6JryMbs6j1wFTsL3dfMRKZPyzu9ebay/+oey6DVPD0+rPS4cSzMHGKa io6VWPtzfdqgJwvPCdKQxNQqDwNnBwZpIPKEd1xfGVBqrko8Ek7SdHCQEb9uO3N4S162 hcDT1AmnIjNuTjxS5jaNJHP0S4O2jAtLrP4wORPEGuTcSxfay/kW04NWlhjl8QtL8q2B WcwDLkzRIoKcy0f+3ESBM0QCqGPnOUIZZIiueWhKbh98kNGUJifm3fsFXpJzkjmphzb1 zWgVHGqWZeA/jceOfDNRAfscjDNqaXoNoMDDvKK5VBfhRcVP/qM8Ox8XgaWW94QGZXbs Fciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5RN9HFVC8/4wrj1xZ018jyfw28e2mD+SWO6pvdC3TeY=; b=HfAuoD7gPXI5f4TQxlLlSbkLndTjMhlR/kfK3G/qGWSJOaMGSmMqNRzmEYCuGR2i/s D7ob9SvkOF8gMrLJCh+hlU70HijWlEvjKVY4srNueQt+wo6PA4OEJMxKerTmeGdW6Mht CjvXoIt6OPm8L142EoQuoIEvK5a7+B5cyEA8023r1cdjDplC3641qBYnXcM01Ob/EKhi zI7Sp122EqMS7Z8usYGxbzbW02M+bmj2OEkBvlVYv/4/24PSQl9ZguhXi6SBH7PMoNPV U1s6UowHOR1wBMbrumWuKkcXjuj4j2HrwL11zdO1rA5plb5VbTM0wCAeO8py6X01V+lh c/dQ== X-Gm-Message-State: APjAAAUuYAs8F9Kmk3g848QpjaZrYI0pA+L5Byj9mde7zH7RLqaJ6iTl y/l7tqvuo0ZhYd6Y5+nZbp6Kv75mXuXpcCi6HyMBgDM+ X-Google-Smtp-Source: APXvYqwREroFheKRCPoBTx3GS/vRMEQRWhH66/SrZi370tBE90y7g9QKiwO0SgXi9HyiUH2cAN4Vvv2pAdufbHOLn/o= X-Received: by 2002:a02:a610:: with SMTP id c16mr68588683jam.13.1578062384700; Fri, 03 Jan 2020 06:39:44 -0800 (PST) MIME-Version: 1.0 References: <20191230102942.18395-1-jinpuwang@gmail.com> <20191230102942.18395-8-jinpuwang@gmail.com> In-Reply-To: From: Jinpu Wang Date: Fri, 3 Jan 2020 15:39:34 +0100 Message-ID: Subject: Re: [PATCH v6 07/25] rtrs: client: statistics functions To: Bart Van Assche Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Danil Kipnis , rpenyaev@suse.de Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jan 2, 2020 at 10:07 PM Bart Van Assche wrote: > > On 12/30/19 2:29 AM, Jack Wang wrote: > > From: Jack Wang > > > > This introduces set of functions used on client side to account > > statistics of RDMA data sent/received, amount of IOs inflight, > > latency, cpu migrations, etc. Almost all statistics is collected > ^^ > are? will fix. > > using percpu variables. > > [ ... ] > > +static inline int rtrs_clt_ms_to_id(unsigned long ms) > > +{ > > + int id = ms ? ilog2(ms) - MIN_LOG_LAT + 1 : 0; > > + > > + return clamp(id, 0, LOG_LAT_SZ - 1); > > +} > > I think it is unusual to call the returned value an "id" in this > context. How about changing "id" into "bin" or "bucket"? See also > https://en.wikipedia.org/wiki/Histogram. will rename id to bin > > Thanks, > > Bart. Thanks