From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C334BC433B4 for ; Thu, 15 Apr 2021 03:15:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9833C61158 for ; Thu, 15 Apr 2021 03:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbhDODOS (ORCPT ); Wed, 14 Apr 2021 23:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229467AbhDODOR (ORCPT ); Wed, 14 Apr 2021 23:14:17 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08D17C061574 for ; Wed, 14 Apr 2021 20:13:55 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d124so15084412pfa.13 for ; Wed, 14 Apr 2021 20:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Fmh4liS79Et/TiMhWSk7GeZ0Io6rybbiYkaLqbUOfg=; b=WPvI4faUCBMBDYwBdUQ1ea7lAY2O/HpTKORWELEWhp7s9skrAJ30T7iC9gXud+u+sO bytUQgsqxDlYHWQtTaCbzzCRUPmCpGnknKOE9pydf7liyY5quX1rXMeJ8RD9QcHpMwla qvspoElyrNWNejQDLi9hh1w1uVilmciRcO0U7UobXbr6IOdtTL7vh1yNMELOStsQwRCg RtUtPaQLSKpIY7lsPN+nQudCZH/rxGt1TznF0fXNi7ioZnxbstHjITbbKsd90ESxPvMg FMAVCcQxtJ9XUbIFtJRvlLfqIfx/zuHC12+dnYhaqw6MlD153ZQxi00mzf5UhvUs+1B7 uHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Fmh4liS79Et/TiMhWSk7GeZ0Io6rybbiYkaLqbUOfg=; b=DjyabccgKPooyf6DRafSJaJG6f0rJL9qfgQDc5dWnr+dVCYsU+Q4lDIBgi9Tnpy8/0 fFDyVx9u5h/FpHlnVjFWH3Fy/tUvKzF6YFr1np1wqQvJHyuqlqyaKsAHLFzJQCNhGXuD WMaCnk5LIdBQfe+5WeJDlz1hvQ0e6ccALspgwAdCs9y7LFSs3BDzdUUyHDnKyDyPzFKT hzyUPLYXM57BMHvpYTai7RVdAElxUpKdAI6XiTUyytYKs9BUmMCFum8vvCjRyqL+UBM3 5nRIxb4UGmG298PNNs+RroOgh20wPvdacue1a2m1L1rdPmPw8AWWTVqipIYs7KngXhaX 942w== X-Gm-Message-State: AOAM532LoX654vBgbepZBfjHotKE9x8pYfgwqFX4aiL62v1EGfn2IZ8A rYTxOY7EtIC1n0Ehp2fkA78+mXtX2nwxgT2lY0m0Kw== X-Google-Smtp-Source: ABdhPJwPDd8ibKe1hHYudB4GXH9XEvmHZJhxqiFbMrk7qzbeN0F7LOU8HEdco9pn8nGRqmohF3gmyM11nLDVx4e2bxY= X-Received: by 2002:a63:1665:: with SMTP id 37mr1526545pgw.31.1618456434129; Wed, 14 Apr 2021 20:13:54 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Thu, 15 Apr 2021 11:13:16 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 2/7] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm To: Michal Hocko Cc: guro@fb.com, hannes@cmpxchg.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 6:15 PM Michal Hocko wrote: > > On Wed 14-04-21 18:04:35, Muchun Song wrote: > > On Wed, Apr 14, 2021 at 5:24 PM Michal Hocko wrote: > > > > > > On Tue 13-04-21 14:51:48, Muchun Song wrote: > > > > When mm is NULL, we do not need to hold rcu lock and call css_tryget for > > > > the root memcg. And we also do not need to check !mm in every loop of > > > > while. So bail out early when !mm. > > > > > > mem_cgroup_charge and other callers unconditionally drop the reference > > > so how come this does not underflow reference count? > > > > For the root memcg, the CSS_NO_REF flag is set, so css_get > > and css_put do not get or put reference. > > Ohh, right you are. I must have forgot about that special case. I am > pretty sure I (and likely few more) will stumble over that in the future > again. A small comment explaining that the reference can be safely > ignore would be helpful. OK. Will do. > > Anyway > Acked-by: Michal Hocko Thanks. > > Thanks! > > -- > Michal Hocko > SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08280C433ED for ; Thu, 15 Apr 2021 03:14:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6921461158 for ; Thu, 15 Apr 2021 03:13:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6921461158 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D810B6B0036; Wed, 14 Apr 2021 23:13:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D48736B006C; Wed, 14 Apr 2021 23:13:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D846B0070; Wed, 14 Apr 2021 23:13:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id A1F006B0036 for ; Wed, 14 Apr 2021 23:13:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 540105825 for ; Thu, 15 Apr 2021 03:13:58 +0000 (UTC) X-FDA: 78033132156.09.8F4BF0C Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf24.hostedemail.com (Postfix) with ESMTP id 35C84A00038D for ; Thu, 15 Apr 2021 03:13:49 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id 31so459149pgn.13 for ; Wed, 14 Apr 2021 20:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Fmh4liS79Et/TiMhWSk7GeZ0Io6rybbiYkaLqbUOfg=; b=WPvI4faUCBMBDYwBdUQ1ea7lAY2O/HpTKORWELEWhp7s9skrAJ30T7iC9gXud+u+sO bytUQgsqxDlYHWQtTaCbzzCRUPmCpGnknKOE9pydf7liyY5quX1rXMeJ8RD9QcHpMwla qvspoElyrNWNejQDLi9hh1w1uVilmciRcO0U7UobXbr6IOdtTL7vh1yNMELOStsQwRCg RtUtPaQLSKpIY7lsPN+nQudCZH/rxGt1TznF0fXNi7ioZnxbstHjITbbKsd90ESxPvMg FMAVCcQxtJ9XUbIFtJRvlLfqIfx/zuHC12+dnYhaqw6MlD153ZQxi00mzf5UhvUs+1B7 uHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Fmh4liS79Et/TiMhWSk7GeZ0Io6rybbiYkaLqbUOfg=; b=n8IwX8aTWmCrQnaA8OjtpRjs2VfICkqNHlcvUuyt1RoZ5aY7/hbowOQTCBL2P0m6N5 PgW5bL7SLzEFeDysA8J57LPuww4cWPMWKZAcVXTlliNb6kGkixGE7Cigt/gyLCD7naCJ F/Gpkx6RlRHe9wTyD45ijHoJiJ+w28EW3xxlqmndwNnU2pAzjhVfTqHs4s+dxwS0RtCv za4O0qr1d/qG5ktmfCz8BJDmFz9/vU+oMSJuH5h9zRWZYm0gLTyvVEVzjV4WKgrQkmOP eUX19Ykm/RRvb2W6flbrXx8fAE1X09Q5797wtVW3fcw1laUOR1hgAl4RpoVZMr5/JUk1 6e4A== X-Gm-Message-State: AOAM5306iRZQMbD1SKcnk/qdEdKoPiKGGM0eHe86toZl9LsrN1NLPC6x vTzxKFAW9K3LxYoN7hast7BBbviZrEZT1bxfjCbRpw== X-Google-Smtp-Source: ABdhPJwPDd8ibKe1hHYudB4GXH9XEvmHZJhxqiFbMrk7qzbeN0F7LOU8HEdco9pn8nGRqmohF3gmyM11nLDVx4e2bxY= X-Received: by 2002:a63:1665:: with SMTP id 37mr1526545pgw.31.1618456434129; Wed, 14 Apr 2021 20:13:54 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Thu, 15 Apr 2021 11:13:16 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 2/7] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm To: Michal Hocko Cc: guro@fb.com, hannes@cmpxchg.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: phfmzya58i53irsyiz4et35dhdphxu3j X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 35C84A00038D Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pg1-f180.google.com; client-ip=209.85.215.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618456429-42648 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 14, 2021 at 6:15 PM Michal Hocko wrote: > > On Wed 14-04-21 18:04:35, Muchun Song wrote: > > On Wed, Apr 14, 2021 at 5:24 PM Michal Hocko wrote: > > > > > > On Tue 13-04-21 14:51:48, Muchun Song wrote: > > > > When mm is NULL, we do not need to hold rcu lock and call css_tryget for > > > > the root memcg. And we also do not need to check !mm in every loop of > > > > while. So bail out early when !mm. > > > > > > mem_cgroup_charge and other callers unconditionally drop the reference > > > so how come this does not underflow reference count? > > > > For the root memcg, the CSS_NO_REF flag is set, so css_get > > and css_put do not get or put reference. > > Ohh, right you are. I must have forgot about that special case. I am > pretty sure I (and likely few more) will stumble over that in the future > again. A small comment explaining that the reference can be safely > ignore would be helpful. OK. Will do. > > Anyway > Acked-by: Michal Hocko Thanks. > > Thanks! > > -- > Michal Hocko > SUSE Labs