From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A067C63777 for ; Fri, 20 Nov 2020 08:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7E5722256 for ; Fri, 20 Nov 2020 08:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="T4Bxv0Lz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbgKTIyV (ORCPT ); Fri, 20 Nov 2020 03:54:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbgKTIyV (ORCPT ); Fri, 20 Nov 2020 03:54:21 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEFB1C0617A7 for ; Fri, 20 Nov 2020 00:54:20 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id m9so6749378pgb.4 for ; Fri, 20 Nov 2020 00:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+/obyKwhLmELIOTNjIjMVdmJhk74zSgJefv372u+mWk=; b=T4Bxv0LzpQqYFqnbeoS5z/ymTAG70N5QauApvRu4qkPvG7VYaK9AXKbvZlE86tp5yk fcPnYwapwHzMDp+jEDGBEvDwx6spPXhDfJyf8sgWfTNABV200qxPHXrK3Rit6Oce0j5l wLfS+XEwnskhpBt15tIZ6iOu4IDS00Khmp5i6lhieuw8Y8iAT+u/rx3Fo8BvBaASOEi/ iba04pd7eKQjZL9vCbNICUU4idRDKUOEEYQUOoAheAntgu6yoGk5inGNaVsx+E6lDiTT 2SCFgLs6lj3X/wvtIGkcFFI3BPo4tKQjVr1niCgGn1jiSixtv99mnKU0DJFAui7wSVSB bcNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+/obyKwhLmELIOTNjIjMVdmJhk74zSgJefv372u+mWk=; b=PTxkPtkUetPR2yuh4VT/uhXeB/MR9RKCIzHND/vPc5fmJG4tf8nk5bNlbx6KMSVYJw B3Wb+5dBinBNusYISnBKf1AKydTw3eBUSw6awB763a5DdO4OQKwjptfmTgjv43K0yEZl fvjRrfniiW4qdbOSp+BaaMT/PUr1WcQyUCBctDUUzLWitJcHRQBd5MmFgFEkwo2w6HSB XOHaEyTsOFrgzOKHlUv+1Y2GZbnuxQWFx0WXvAHYkB3Bil8TFV2S/sIkrawP/eb1Gu3F i84Ir50k2Y/ukmAqq/BBu+2ViZjOgBel6MBVyDlYOtwnhGnSwBENSRhbB34n3VKEdZiR 49MA== X-Gm-Message-State: AOAM533UpIj9RhfqJrdkskgSZYqh31bK35ah4+UVrPWZ6XXrtkv1GS8p OXvK++iwwA1qbuk/dw89ps6iPOI7Lo7d9d9eswh47w== X-Google-Smtp-Source: ABdhPJy1+LfEuD8o9GFskPkG8bpoSM/jlOhzy1Ph5ajz7lZTeqmYNK0X1dfui/R4WQbABZDeaxI2ByEigdWN7vPUj54= X-Received: by 2002:a17:90a:ae14:: with SMTP id t20mr9193687pjq.13.1605862460402; Fri, 20 Nov 2020 00:54:20 -0800 (PST) MIME-Version: 1.0 References: <20201120064325.34492-1-songmuchun@bytedance.com> <20201120064325.34492-4-songmuchun@bytedance.com> <20201120074950.GB3200@dhcp22.suse.cz> <20201120084750.GK3200@dhcp22.suse.cz> In-Reply-To: <20201120084750.GK3200@dhcp22.suse.cz> From: Muchun Song Date: Fri, 20 Nov 2020 16:53:37 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 4:47 PM Michal Hocko wrote: > > On Fri 20-11-20 16:35:16, Muchun Song wrote: > [...] > > > That being said, unless there are huge advantages to introduce a > > > config option I would rather not add it because our config space is huge > > > already and the more we add the more future code maintainance that will > > > add. If you want the config just for dependency checks then fine by me. > > > > Yeah, it is only for dependency checks :) > > OK, I must have misread the definition to think that it requires user to > enable explicitly. > > Anyway this feature cannot be really on by default due to overhead. So > the command line option default has to be flipped. Got it. Thanks for your suggestion. > > -- > Michal Hocko > SUSE Labs -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389D5C6379D for ; Fri, 20 Nov 2020 08:54:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E4AD22253 for ; Fri, 20 Nov 2020 08:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="T4Bxv0Lz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E4AD22253 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 14E626B0072; Fri, 20 Nov 2020 03:54:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 125516B0073; Fri, 20 Nov 2020 03:54:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03C906B0074; Fri, 20 Nov 2020 03:54:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id BFFC86B0072 for ; Fri, 20 Nov 2020 03:54:22 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 529678249980 for ; Fri, 20 Nov 2020 08:54:22 +0000 (UTC) X-FDA: 77504185164.25.bird34_1d03a652734a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 3364D180AAA73 for ; Fri, 20 Nov 2020 08:54:22 +0000 (UTC) X-HE-Tag: bird34_1d03a652734a X-Filterd-Recvd-Size: 4553 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Nov 2020 08:54:21 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id q28so6753941pgk.1 for ; Fri, 20 Nov 2020 00:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+/obyKwhLmELIOTNjIjMVdmJhk74zSgJefv372u+mWk=; b=T4Bxv0LzpQqYFqnbeoS5z/ymTAG70N5QauApvRu4qkPvG7VYaK9AXKbvZlE86tp5yk fcPnYwapwHzMDp+jEDGBEvDwx6spPXhDfJyf8sgWfTNABV200qxPHXrK3Rit6Oce0j5l wLfS+XEwnskhpBt15tIZ6iOu4IDS00Khmp5i6lhieuw8Y8iAT+u/rx3Fo8BvBaASOEi/ iba04pd7eKQjZL9vCbNICUU4idRDKUOEEYQUOoAheAntgu6yoGk5inGNaVsx+E6lDiTT 2SCFgLs6lj3X/wvtIGkcFFI3BPo4tKQjVr1niCgGn1jiSixtv99mnKU0DJFAui7wSVSB bcNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+/obyKwhLmELIOTNjIjMVdmJhk74zSgJefv372u+mWk=; b=lFdt3R3qGQQK6jfLJ0rClFeceiMEfODZG1FJ233W/IELL+g0uX8Qa1h4E6gaexoD6D dVSrGlP/Ny1tVFM3lJvDxs8PRqxRrcVYUpqtftVg3fOxtTHzErLf867gdydb+sg2shDY 91WeNI4eUh0iUX5zJzCfCG3Jp6NpAukkbK35qtyRGV2rvV3Bt/SqlyIGYUALp58rdaCX j5VHGjk1wdgBA/OHJQz/RSXTmJs6ZgmlwOsNhE5SfbTzljpV9cD5YLnfw6kuIiGz/Z2o NUdRdsCOoPOIHYCgW5MGGwga3Twww/qoDqUjZRVVw/p+Kmmprx0y7KjGNCCYKgJZUYso +/zA== X-Gm-Message-State: AOAM530BD2Q2VAVInIdmrIkYfhUnKp7bMmJ4cAJC/WGg9aWNM2LICIcz nT4aevYs78CP2JNM5ucuF9+wtYNqAQqDPYiqTkaiKQ== X-Google-Smtp-Source: ABdhPJy1+LfEuD8o9GFskPkG8bpoSM/jlOhzy1Ph5ajz7lZTeqmYNK0X1dfui/R4WQbABZDeaxI2ByEigdWN7vPUj54= X-Received: by 2002:a17:90a:ae14:: with SMTP id t20mr9193687pjq.13.1605862460402; Fri, 20 Nov 2020 00:54:20 -0800 (PST) MIME-Version: 1.0 References: <20201120064325.34492-1-songmuchun@bytedance.com> <20201120064325.34492-4-songmuchun@bytedance.com> <20201120074950.GB3200@dhcp22.suse.cz> <20201120084750.GK3200@dhcp22.suse.cz> In-Reply-To: <20201120084750.GK3200@dhcp22.suse.cz> From: Muchun Song Date: Fri, 20 Nov 2020 16:53:37 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v5 03/21] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 20, 2020 at 4:47 PM Michal Hocko wrote: > > On Fri 20-11-20 16:35:16, Muchun Song wrote: > [...] > > > That being said, unless there are huge advantages to introduce a > > > config option I would rather not add it because our config space is huge > > > already and the more we add the more future code maintainance that will > > > add. If you want the config just for dependency checks then fine by me. > > > > Yeah, it is only for dependency checks :) > > OK, I must have misread the definition to think that it requires user to > enable explicitly. > > Anyway this feature cannot be really on by default due to overhead. So > the command line option default has to be flipped. Got it. Thanks for your suggestion. > > -- > Michal Hocko > SUSE Labs -- Yours, Muchun