From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF65C4338F for ; Fri, 30 Jul 2021 02:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 344286069E for ; Fri, 30 Jul 2021 02:43:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236182AbhG3CnQ (ORCPT ); Thu, 29 Jul 2021 22:43:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhG3CnP (ORCPT ); Thu, 29 Jul 2021 22:43:15 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599D3C0613C1 for ; Thu, 29 Jul 2021 19:43:10 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id a20so9363776plm.0 for ; Thu, 29 Jul 2021 19:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=JgClgnU9EdwSANU8A5FerpxJDoCmKESOX5v+FZM6r2TrDY8Hsmgx4fSSGUaIChBFJW nJ4E/ZBbz1I3MA/8EDBPDxWMF5E3u1sHgvJuQ0NooOw3kwGeUDjcHTC+SoVHq9wRE0PY V4+8QyMzbmoBDl3xFidcOKambkn17SDAQFg8woP+NP1uNpxlfm+hNQguFbWO9M9rTIVj MwfqoK+BfnglDvvyR3no3rQ73c+0mKGVgwByOa85doAmoI1ui4CnZ0yfBRS+cazSq3l2 5gkMKx8CC8QVd/AoL8jHejUm2ApZHIr/tSINLrhVkby6HYZ5KngrD4z7/lZ6WSX0Me4t aXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=uhLiIwRUeY+mloLaJ2VUKEyzQj23FPntwrdHLx982zTpU6CsmIbiWbwP7rtRFusLdD DpuNjvvteLeQcVSL6IOZcNe8tlNQZFYiHEbYPpzh4Nvc7GNoaOFmCjX5fZozrr6jIbmR PlEpEHmOh/9MpEC/JMZNdXrS5WKFuyUM+QHD1qwvYM7dc0AHk0m4tHnPjbJNh3xRIu9u xR1qHayn1NKIohAqQ71vrb3VA1g280WjNOZ/WqkphY4FnATNXOF/a+xdN/lp7Kn2m/h2 IMNYTbuKOFWuCdpMxEfzfXXCMck3Zv4M7rxUN7oz2Qn4yMNe47RnPdPKqmWjATHLK2Tq DanQ== X-Gm-Message-State: AOAM532qdyL539N9ySHEaUAud9/S5QHOBF8pP4XYKG4Pi5b6pEXExsif hyBecvWAZa1XAFckd/B7bIpj2rnRKyVLHN1p5cztTw== X-Google-Smtp-Source: ABdhPJyKMjwJtks3kZrAExse5sOaTz+Y2l4NgrwbHMWIdimiFgom2e4JKhi5i2WQTiXiZnf08teTGdgENzry63QbeGo= X-Received: by 2002:a17:902:6ac9:b029:12c:3bac:8d78 with SMTP id i9-20020a1709026ac9b029012c3bac8d78mr348102plt.34.1627612989962; Thu, 29 Jul 2021 19:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-3-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-3-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 30 Jul 2021 10:42:29 +0800 Message-ID: Subject: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 8:58 PM Miaohe Lin wrote: > > Since percpu_charge_mutex is only used inside drain_all_stock(), we can > narrow the scope of percpu_charge_mutex by moving it here. > > Signed-off-by: Miaohe Lin LGTM. Reviewed-by: Muchun Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24ECBC432BE for ; Fri, 30 Jul 2021 02:43:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9AA661019 for ; Fri, 30 Jul 2021 02:43:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9AA661019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EF1438D0001; Thu, 29 Jul 2021 22:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA1DB6B005D; Thu, 29 Jul 2021 22:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8F658D0001; Thu, 29 Jul 2021 22:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id C1E936B0036 for ; Thu, 29 Jul 2021 22:43:11 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 70EEB8249980 for ; Fri, 30 Jul 2021 02:43:11 +0000 (UTC) X-FDA: 78417707382.26.09B0474 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf25.hostedemail.com (Postfix) with ESMTP id D5767B00C767 for ; Fri, 30 Jul 2021 02:43:10 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id n10so9310870plf.4 for ; Thu, 29 Jul 2021 19:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=JgClgnU9EdwSANU8A5FerpxJDoCmKESOX5v+FZM6r2TrDY8Hsmgx4fSSGUaIChBFJW nJ4E/ZBbz1I3MA/8EDBPDxWMF5E3u1sHgvJuQ0NooOw3kwGeUDjcHTC+SoVHq9wRE0PY V4+8QyMzbmoBDl3xFidcOKambkn17SDAQFg8woP+NP1uNpxlfm+hNQguFbWO9M9rTIVj MwfqoK+BfnglDvvyR3no3rQ73c+0mKGVgwByOa85doAmoI1ui4CnZ0yfBRS+cazSq3l2 5gkMKx8CC8QVd/AoL8jHejUm2ApZHIr/tSINLrhVkby6HYZ5KngrD4z7/lZ6WSX0Me4t aXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=hW1nOAPIqiOttMyk9QS6opaXos7zyoKlE7z10xFdTK45Y3ki68k8OkzTQBd2XGjJoJ kpMx08E3jUYr3/huDYP/u+UKhN2X9o/pzh4Ro58ozV7PeRw8zsIWgxM4yA8dC6/XIEYx JJHAAVqT6zNQU5qcpYIAXnOp/Iri5SI4Ug1BrwjnjDE17iqWEgQ72qDErlDYY4ylhPk0 Zpv+kchrkfci2Ia9KKsex1PgVEnLvH8YGindpQ803A10S4iaadgwfye+vgORYKmUMha1 Gz1voXeEuTYKmAIUW7ftLiIZgGn0PEUhc15+wYl/b1lEBnX1sRPwHxIcE9mZWYlP3PbA gGwA== X-Gm-Message-State: AOAM533U02dvs3wha7NparodjVCciPWvHuZ8CbXaOQ2FTBExPiH8Ad73 xAO6+utdH0JrQFQ3VYdlTPiNDc28iirFxSWwU+/15g== X-Google-Smtp-Source: ABdhPJyKMjwJtks3kZrAExse5sOaTz+Y2l4NgrwbHMWIdimiFgom2e4JKhi5i2WQTiXiZnf08teTGdgENzry63QbeGo= X-Received: by 2002:a17:902:6ac9:b029:12c:3bac:8d78 with SMTP id i9-20020a1709026ac9b029012c3bac8d78mr348102plt.34.1627612989962; Thu, 29 Jul 2021 19:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-3-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-3-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 30 Jul 2021 10:42:29 +0800 Message-ID: Subject: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=JgClgnU9; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D5767B00C767 X-Stat-Signature: 8bysfntcmt7kxac8nccxrny8gh6w4du9 X-HE-Tag: 1627612990-909933 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 29, 2021 at 8:58 PM Miaohe Lin wrote: > > Since percpu_charge_mutex is only used inside drain_all_stock(), we can > narrow the scope of percpu_charge_mutex by moving it here. > > Signed-off-by: Miaohe Lin LGTM. Reviewed-by: Muchun Song From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex Date: Fri, 30 Jul 2021 10:42:29 +0800 Message-ID: References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-3-linmiaohe@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=JgClgnU9EdwSANU8A5FerpxJDoCmKESOX5v+FZM6r2TrDY8Hsmgx4fSSGUaIChBFJW nJ4E/ZBbz1I3MA/8EDBPDxWMF5E3u1sHgvJuQ0NooOw3kwGeUDjcHTC+SoVHq9wRE0PY V4+8QyMzbmoBDl3xFidcOKambkn17SDAQFg8woP+NP1uNpxlfm+hNQguFbWO9M9rTIVj MwfqoK+BfnglDvvyR3no3rQ73c+0mKGVgwByOa85doAmoI1ui4CnZ0yfBRS+cazSq3l2 5gkMKx8CC8QVd/AoL8jHejUm2ApZHIr/tSINLrhVkby6HYZ5KngrD4z7/lZ6WSX0Me4t aXPw== In-Reply-To: <20210729125755.16871-3-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups On Thu, Jul 29, 2021 at 8:58 PM Miaohe Lin wrote: > > Since percpu_charge_mutex is only used inside drain_all_stock(), we can > narrow the scope of percpu_charge_mutex by moving it here. > > Signed-off-by: Miaohe Lin LGTM. Reviewed-by: Muchun Song