From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF97C433DF for ; Tue, 19 May 2020 17:57:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B8A120674 for ; Tue, 19 May 2020 17:57:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EIsN0lIb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729478AbgESR5B (ORCPT ); Tue, 19 May 2020 13:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbgESR5A (ORCPT ); Tue, 19 May 2020 13:57:00 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42B5C08C5C0 for ; Tue, 19 May 2020 10:57:00 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id 19so511630oiy.8 for ; Tue, 19 May 2020 10:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1Imt22fDb9rnr1PM83spQEypfOoKpDmdt07ir12ZROw=; b=EIsN0lIbnGIseCKOMt9BxMm/yWGyBEmTV5UMfUPoo/OqAhixo/cmfRZ8PLapt9xQAZ EvY8ivhjEUN2ugOhTzS3I8IPZB6ohdVmRnkDraf4nPeoXjr2jlvsgFiCxDxsByl9TAXQ pAmhmUFyOz0yzlDkcJuU3bzN7xpeS8Ai+ZaI1hUZUr4jdgg90ce8y7m1UKN3zaaVqGm6 3+Y2WR81+fMMC9ZgpPZmu4UDVhOzY6TRWNNskcuJ/bp86b/rP7UOsPWMJMbyTWcMTzEM 1Y9OWUyxLmR6V0GXOKY/bJb0RMQ31GUUFH0WpDj3S6aFg7zjL7rYSEI2+ALKMOmWHTt+ e+SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1Imt22fDb9rnr1PM83spQEypfOoKpDmdt07ir12ZROw=; b=YlxbiJpR4KjGHYKBRi2uiefctLyxMtzMdDBQvVFGKLq2auFL2ur7tUg53SSr1kE803 BK57kNvQZz7tY5QNBGU/Do8dAJsGgobvidVpvSVPPheuReJTKROtK1MhfDo3K6i+Slgy V36ub6S/UzXup7/H3vLbybKKFZEwhhX/TfOcJ28k7o1m9dZ7cz0yHVYMjVrSB94vuzxu 4UY/nkh6Ncjn9CTHs67xyCPDFte5dQpchJKs87UVaKXDaZwLbHl17kdZ4/NCT/oV4is/ EpyY4G8Tmo2+FkZ+fomdAjEAk9zt/Tg1LDrdCie5FsXMd8mNPQkC78LAHKdSK7xsheql rCKQ== X-Gm-Message-State: AOAM53162apI8FMxGImpuQX/RVTmbVb7Ax3XNxPtUaLzEqJLQel4T0As HEtFoninZg/uCp24Hgz848q6MIAsqClmBV8ZC2se/Z47k3g= X-Google-Smtp-Source: ABdhPJzgwKLsqnNnvVUXLg0MZzc0QWm3E3MHSTVw3p+KUEEpHEvY7nr10nCYRLd4eIXwnt9PpMLWSbeltwjkXP9DJPY= X-Received: by 2002:aca:e1d6:: with SMTP id y205mr474943oig.142.1589911020044; Tue, 19 May 2020 10:57:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Cong Wang Date: Tue, 19 May 2020 10:56:47 -0700 Message-ID: Subject: Re: iproute2: tc deletion freezes whole server To: =?UTF-8?Q?V=C3=A1clav_Zindulka?= Cc: Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 19, 2020 at 1:04 AM V=C3=A1clav Zindulka wrote: > > > > Let me think how to fix this properly, I have some ideas and will provi= de > > you some patch(es) to test soon. > > Sure, I'll wait. I have plenty of time now with the main problem fixed :-= ) Can you help to test the patches below? https://github.com/congwang/linux/commits/qdisc_reset2 I removed the last patch you previously tested and added two more patches on top. These two patches should get rid of most of the unnecessary resets. I tested them with veth pair with 8 TX queues, but I don't have any real physical NIC to test. Thanks.