From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A33DC2BA19 for ; Mon, 13 Apr 2020 17:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29D0320732 for ; Mon, 13 Apr 2020 17:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ChZazmm7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732786AbgDMR3F (ORCPT ); Mon, 13 Apr 2020 13:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1732781AbgDMR3E (ORCPT ); Mon, 13 Apr 2020 13:29:04 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32318C0A3BDC for ; Mon, 13 Apr 2020 10:29:04 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id j4so3243177otr.11 for ; Mon, 13 Apr 2020 10:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=A3en5iyzOMVENH6eYpzFeSxk3riVmI1mcWKP8c73T7Y=; b=ChZazmm7KvFDFM3VM3pWatlAHNL0YXMcxCPK2CDpAnUyJhsjPQxWXacPI8HtajY1x0 I3syb90d59WFS/Ukp6CPForM/Trwa9hY9Kv2oJS3IGfaENAiQxAIajgRxBxQ4usskkCd gvimN4rhrYxe7t8sKvOKw7DZ8hT3QChZ32p6jDrIQz/1PLSysYystK22P/6IrnVPXm1C O0mwy+SCPmOiONTmKwQv/quBg+AZONun9UxX7J4MzYIv8e+7oL3UiGTL5i/d4GmiIokg BZT4qLZH1aP8UBg2LN5ojGH7pUwUb1Z4d5ccsH3lxo7chlviekQJEnx41rg4XpnX/Yw7 ZznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=A3en5iyzOMVENH6eYpzFeSxk3riVmI1mcWKP8c73T7Y=; b=bnYEQUtDhNFI0fP29ht1HFiiOR5lZ0XyfZUTVHF9SOpPSkxp/jE1BH+zgJY0wjBqt2 UnWXXhH+2ezK8+CgdH1sAC0pvy4bFfvvXT2f7bi6ppNxqumMmPyo+HIG80oesSjEAX6Z ruVF9YPshS/lbxr9HmqGO90lH2EMFnw4F8GvLiVxXW0Rx209f1ywB5PUlMiiYJNziymH FnHfJ5Pa25Tmuw7UnTzgIV93qDjRplUVXS4iNCk+YvPQrRyZE4coiOy4M7+OykhlCb/W n5uVTXaTZx5nqHuiWyqkxTSeekbOa21q/2hs2gMD4GZtgvGi0ZmAJ0ZSMLI4aZYitgWs KMBg== X-Gm-Message-State: AGi0PuYy2Qkjx4NxxogMHy5Tt4IOo7kYPJhYNhyz71rBJFu7rgetGdZy j6nTdiLGPTafFmPUBNCwiYNsJO+wDJRe91GdVqhL3w== X-Google-Smtp-Source: APiQypKPm1BjjKl0/1AZ/ilvFZz+12ikgKDW+CyVhqrA0ULNWKiWlkhsCVop2KnOA7ErbWADOBi/Il7TG4AmZa1wKXc= X-Received: by 2002:a05:6830:2410:: with SMTP id j16mr517387ots.189.1586798943455; Mon, 13 Apr 2020 10:29:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Cong Wang Date: Mon, 13 Apr 2020 10:28:52 -0700 Message-ID: Subject: Re: iproute2: tc deletion freezes whole server To: =?UTF-8?Q?V=C3=A1clav_Zindulka?= Cc: Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 12, 2020 at 1:18 PM V=C3=A1clav Zindulka wrote: > > On Wed, Apr 8, 2020 at 10:18 PM Cong Wang wrot= e: > > > > Hi, V=C3=A1clav > > Hello Cong, > > > Sorry for the delay. > > No problem, I'm actually glad you are diagnosing the problem further. > I didn't have much time until today and late yesterday to apply > patches and to test it. > > > The problem is actually more complicated than I thought, although it > > needs more work, below is the first pile of patches I have for you to > > test: > > > > https://github.com/congwang/linux/commits/qdisc_reset > > > > It is based on the latest net-next branch. Please let me know the resul= t. > > I have applied all the patches in your four commits to my custom 5.4.6 > kernel source. There was no change in the amount of fq_codel_reset > calls. Tested on ifb, RJ45 and SFP+ interfaces. It is true my patches do not reduce the number of fq_codel_reset() calls, they are intended to reduce the CPU time spent in each fq_codel_reset(). Can you measure this? Note, you do not have to add your own printk() any more, because my patches add a few tracepoints, especially for qdisc_reset(). So you can obtain the time by checking the timestamps of these trace events. Of course, you can also use perf trace like you did before. Thanks!