All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Dave Hansen <dave.hansen@intel.com>,
	syzbot <syzbot+5d1bad8042a8f0e8117a@syzkaller.appspotmail.com>
Subject: Re: [PATCH] crypto: x86/aes-ni - add missing error checks in XTS code
Date: Mon, 19 Jul 2021 09:11:50 +0200	[thread overview]
Message-ID: <CAMj1kXEyoOnke4=bcCvKuqLP2On63XK2JUP-LgmoBi-H_m+XmA@mail.gmail.com> (raw)
In-Reply-To: <YPIdEwVJsOdrpJJH@quark.localdomain>

On Sat, 17 Jul 2021 at 01:58, Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Fri, Jul 16, 2021 at 06:54:03PM +0200, Ard Biesheuvel wrote:
> > The updated XTS code fails to check the return code of skcipher_walk_virt,
> > which may lead to skcipher_walk_abort() or skcipher_walk_done() being called
> > while the walk argument is in an inconsistent state.
> >
> > So check the return value after each such call, and bail on errors.
> >
> > Fixes: 2481104fe98d ("crypto: x86/aes-ni-xts - rewrite and drop indirections via glue helper")
>
> Add Cc stable?
>
> > Reported-by: Dave Hansen <dave.hansen@intel.com>
> > Reported-by: syzbot <syzbot+5d1bad8042a8f0e8117a@syzkaller.appspotmail.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  arch/x86/crypto/aesni-intel_glue.c | 5 +++++
> >  1 file changed, 5 insertions(+)
>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
>

Thanks Eric. Herbert can add the cc:stable if he decides to, but IIRC,
he prefers relying on the fixes: tag only.

  reply	other threads:[~2021-07-19  7:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 16:54 [PATCH] crypto: x86/aes-ni - add missing error checks in XTS code Ard Biesheuvel
2021-07-16 23:58 ` Eric Biggers
2021-07-19  7:11   ` Ard Biesheuvel [this message]
2021-07-23  6:53 ` Herbert Xu
2021-08-03  2:19 ` [crypto] ed610fb786: will-it-scale.per_thread_ops 4.6% improvement kernel test robot
2021-08-03  2:19   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXEyoOnke4=bcCvKuqLP2On63XK2JUP-LgmoBi-H_m+XmA@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=dave.hansen@intel.com \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=syzbot+5d1bad8042a8f0e8117a@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.