From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9422FC47089 for ; Wed, 26 May 2021 14:15:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6622E613D3 for ; Wed, 26 May 2021 14:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234553AbhEZOQq (ORCPT ); Wed, 26 May 2021 10:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233484AbhEZOQo (ORCPT ); Wed, 26 May 2021 10:16:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B57E613D7; Wed, 26 May 2021 14:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622038513; bh=V9yfVGz48znBhoLYjEcvRlIp+daisCyNDfH0CN868s4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dvLySTxEZiqHBU8DH6u3hrzj/0VudX+Pm4o9KGnIC8axkD+9PaZiv2F7PbCAMhuXl ZeeO7mNhyyyXa9eue79WEGTCXLOOHL4gm432bZz7BcvKQV38DZvaX+GPQIxzETcm8T mD24awDK8Uz+0BUmBoOAbktmxDwSqKnRjK9wiYEzrSANcvvsqFHEbpWBWST4A8FTx3 HclZI2Quz0gpF21n72viLd14SRFeky5BDhX4phZGE3Y7QzuEgUlbhAQtBrD12xLRls AOb2wzA2NOhnENSybyHuEQ+jbJa4Oslqju8HYAuZs9c/n3g2MwlPkKXBHIIfMYWBoL fbBwjsDcOveFg== Received: by mail-ot1-f54.google.com with SMTP id u25-20020a0568302319b02902ac3d54c25eso1149846ote.1; Wed, 26 May 2021 07:15:13 -0700 (PDT) X-Gm-Message-State: AOAM530RRriy6jUaRfONF7+ScC6ggAqCZsfXm3OGM4K8y8Lnu70YsqiW j27hVzaX+Fvl6ABV0aWZjwQqXiXMBaZumJfrRRY= X-Google-Smtp-Source: ABdhPJwW8Rk3emRD0hkgXQcN7xcSCM6FPDi3/JYZuHbFrFSjxpSMXx/i0GLgZamflQJyw1kM6Iit6JpDO+OpdpVyfzw= X-Received: by 2002:a05:6830:4da:: with SMTP id s26mr2542142otd.77.1622038512765; Wed, 26 May 2021 07:15:12 -0700 (PDT) MIME-Version: 1.0 References: <7a1e2ebc-f7d8-8431-d844-41a9c36a8911@arm.com> <01efd004-1c50-25ca-05e4-7e4ef96232e2@arm.com> <87eedxbtkn.fsf@stealth> <877djnaq11.fsf@stealth> <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> In-Reply-To: <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> From: Ard Biesheuvel Date: Wed, 26 May 2021 16:15:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG] rockpro64: PCI BAR reassignment broken by commit 9d57e61bf723 ("of/pci: Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Peter Geis , Punit Agrawal , Robin Murphy , Alexandru Elisei , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , arm-mail-list , Heiko Stuebner , Leonardo Bras , Rob Herring , PCI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 May 2021 at 15:55, Christian K=C3=B6nig wrote: > > Hi Ard, > > Am 25.05.21 um 19:18 schrieb Ard Biesheuvel: > > [SNIP] > >>> I seriously doubt that this is what is going on here. > >>> > >>> lspci -x will give you the bare BAR values - I suspect that those are > >>> probably fine. > >> lspci -x > >> 00:00.0 PCI bridge: Fuzhou Rockchip Electronics Co., Ltd Device 3566 (= rev 01) > >> 00: 87 1d 66 35 07 05 10 40 01 00 04 06 00 00 01 00 > >> 10: 00 00 00 00 00 00 00 00 00 01 ff 00 10 10 00 20 > >> 20: 00 10 00 10 01 00 f1 0f 00 00 00 00 00 00 00 00 > >> 30: 00 00 00 00 40 00 00 00 00 00 00 00 5f 01 02 00 > >> > >> 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. > >> [AMD/ATI] Turks PRO [Radeon HD 7570] > >> 00: 02 10 5d 67 07 00 10 20 00 00 00 03 00 00 80 00 > >> 10: 0c 00 00 00 00 00 00 00 > > This is a 64-bit prefetchable BAR programmed with bus address 0x0 > > > >> 04 00 00 10 00 00 00 00 > > This is a 64-bit non-prefetchable BAR programmed with bus address 0x100= 0_0000 > > > > (https://en.wikipedia.org/wiki/PCI_configuration_space describes the > > meaning of the low order BAR bits) > > Sorry for jumping into the middle of the discussion and to be honest I > haven't fully read it. > > This looks a bit odd since on AMD VGA hardware the non-prefetchable BAR > is usually only 32bit, not 64bit. > > But this hardware generation is rather old and I'm not sure what the BAR > assignment for that generation was. I would need to dig up the register > description in our archives as well. > I have another museum piece in my AMD Seattle: 02:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Oland XT [Radeon HD 8670 / R7 250/350] (rev 81) (prog-if 00 [VGA controller]) Subsystem: Dell Oland XT [Radeon HD 8670 / R7 250/350] Flags: bus master, fast devsel, latency 0, IRQ 255 Memory at 100000000 (64-bit, prefetchable) [size=3D4G] Memory at 40000000 (64-bit, non-prefetchable) [size=3D256K] I/O ports at 1000 [disabled] [size=3D256] Expansion ROM at 40060000 [disabled] [size=3D128K] Capabilities: Kernel modules: radeon, amdgpu So AMD/ATI ASICs definitely exist that expose a 64-bit pref and a 64-bit non-pref BAR. --=20 Ard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390A8C4708B for ; Wed, 26 May 2021 15:23:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03D2E61378 for ; Wed, 26 May 2021 15:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03D2E61378 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQ9TxYM7wc1WRDkxi3XW/b16nKtdRAKQ6Wm3CUwX6yw=; b=NfFCTzniMLdCNz C/EJbcnhlnbkukG8f3QfNhBe35+fUQ5MWdpocUXOO7e7W4QWifKAmzAtyYr0S+e4RmT0R2WYxUaXU jV0s1x6WNr0pnoyj4aStrX+Cn01XQTVa5ipDIxLnx8rxXqHGDJA11wRm/JDLJnwVXfdykEyOHnsBS OHrX0bkO0OdYotdza6uiI9ZjEb0mShQiJUo1lznXxII7bDuB5I1843EvMvqsusVGGRHkff86mdQnb a6Eb9CvHdGD7cPeYVGsGfnTaDfkAcduoItmKMFNrxX20sUqSPiu0/eeHAUZpyPDHNvYAPbKuMdmci L9gQn0WFquLnlmGe8ZDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llvNp-00FKcX-3S; Wed, 26 May 2021 15:23:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lluJV-00EmE7-Uy; Wed, 26 May 2021 14:15:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7054B613E1; Wed, 26 May 2021 14:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622038513; bh=V9yfVGz48znBhoLYjEcvRlIp+daisCyNDfH0CN868s4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dvLySTxEZiqHBU8DH6u3hrzj/0VudX+Pm4o9KGnIC8axkD+9PaZiv2F7PbCAMhuXl ZeeO7mNhyyyXa9eue79WEGTCXLOOHL4gm432bZz7BcvKQV38DZvaX+GPQIxzETcm8T mD24awDK8Uz+0BUmBoOAbktmxDwSqKnRjK9wiYEzrSANcvvsqFHEbpWBWST4A8FTx3 HclZI2Quz0gpF21n72viLd14SRFeky5BDhX4phZGE3Y7QzuEgUlbhAQtBrD12xLRls AOb2wzA2NOhnENSybyHuEQ+jbJa4Oslqju8HYAuZs9c/n3g2MwlPkKXBHIIfMYWBoL fbBwjsDcOveFg== Received: by mail-ot1-f45.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso1106416otl.13; Wed, 26 May 2021 07:15:13 -0700 (PDT) X-Gm-Message-State: AOAM533cfbb7fQqgkm4eH0gTNMdt4eaX6Ja44V7shqnUzh657KyMFA3O PkAkqVxrwjDlqc14QRsSs9sY9A5fI9q4ddY735o= X-Google-Smtp-Source: ABdhPJwW8Rk3emRD0hkgXQcN7xcSCM6FPDi3/JYZuHbFrFSjxpSMXx/i0GLgZamflQJyw1kM6Iit6JpDO+OpdpVyfzw= X-Received: by 2002:a05:6830:4da:: with SMTP id s26mr2542142otd.77.1622038512765; Wed, 26 May 2021 07:15:12 -0700 (PDT) MIME-Version: 1.0 References: <7a1e2ebc-f7d8-8431-d844-41a9c36a8911@arm.com> <01efd004-1c50-25ca-05e4-7e4ef96232e2@arm.com> <87eedxbtkn.fsf@stealth> <877djnaq11.fsf@stealth> <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> In-Reply-To: <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> From: Ard Biesheuvel Date: Wed, 26 May 2021 16:15:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG] rockpro64: PCI BAR reassignment broken by commit 9d57e61bf723 ("of/pci: Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Peter Geis , Punit Agrawal , Robin Murphy , Alexandru Elisei , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , arm-mail-list , Heiko Stuebner , Leonardo Bras , Rob Herring , PCI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_071514_082550_BF5DBBBA X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNiBNYXkgMjAyMSBhdCAxNTo1NSwgQ2hyaXN0aWFuIEvDtm5pZwo8Y2tvZW5pZy5s ZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3RlOgo+Cj4gSGkgQXJkLAo+Cj4gQW0gMjUuMDUu MjEgdW0gMTk6MTggc2NocmllYiBBcmQgQmllc2hldXZlbDoKPiA+IFtTTklQXQo+ID4+PiBJIHNl cmlvdXNseSBkb3VidCB0aGF0IHRoaXMgaXMgd2hhdCBpcyBnb2luZyBvbiBoZXJlLgo+ID4+Pgo+ ID4+PiBsc3BjaSAteCB3aWxsIGdpdmUgeW91IHRoZSBiYXJlIEJBUiB2YWx1ZXMgLSBJIHN1c3Bl Y3QgdGhhdCB0aG9zZSBhcmUKPiA+Pj4gcHJvYmFibHkgZmluZS4KPiA+PiBsc3BjaSAteAo+ID4+ IDAwOjAwLjAgUENJIGJyaWRnZTogRnV6aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwgTHRk IERldmljZSAzNTY2IChyZXYgMDEpCj4gPj4gMDA6IDg3IDFkIDY2IDM1IDA3IDA1IDEwIDQwIDAx IDAwIDA0IDA2IDAwIDAwIDAxIDAwCj4gPj4gMTA6IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAw IDAxIGZmIDAwIDEwIDEwIDAwIDIwCj4gPj4gMjA6IDAwIDEwIDAwIDEwIDAxIDAwIGYxIDBmIDAw IDAwIDAwIDAwIDAwIDAwIDAwIDAwCj4gPj4gMzA6IDAwIDAwIDAwIDAwIDQwIDAwIDAwIDAwIDAw IDAwIDAwIDAwIDVmIDAxIDAyIDAwCj4gPj4KPiA+PiAwMTowMC4wIFZHQSBjb21wYXRpYmxlIGNv bnRyb2xsZXI6IEFkdmFuY2VkIE1pY3JvIERldmljZXMsIEluYy4KPiA+PiBbQU1EL0FUSV0gVHVy a3MgUFJPIFtSYWRlb24gSEQgNzU3MF0KPiA+PiAwMDogMDIgMTAgNWQgNjcgMDcgMDAgMTAgMjAg MDAgMDAgMDAgMDMgMDAgMDAgODAgMDAKPiA+PiAxMDogMGMgMDAgMDAgMDAgMDAgMDAgMDAgMDAK PiA+IFRoaXMgaXMgYSA2NC1iaXQgcHJlZmV0Y2hhYmxlIEJBUiBwcm9ncmFtbWVkIHdpdGggYnVz IGFkZHJlc3MgMHgwCj4gPgo+ID4+IDA0IDAwIDAwIDEwIDAwIDAwIDAwIDAwCj4gPiBUaGlzIGlz IGEgNjQtYml0IG5vbi1wcmVmZXRjaGFibGUgQkFSIHByb2dyYW1tZWQgd2l0aCBidXMgYWRkcmVz cyAweDEwMDBfMDAwMAo+ID4KPiA+IChodHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lraS9QQ0lf Y29uZmlndXJhdGlvbl9zcGFjZSBkZXNjcmliZXMgdGhlCj4gPiBtZWFuaW5nIG9mIHRoZSBsb3cg b3JkZXIgQkFSIGJpdHMpCj4KPiBTb3JyeSBmb3IganVtcGluZyBpbnRvIHRoZSBtaWRkbGUgb2Yg dGhlIGRpc2N1c3Npb24gYW5kIHRvIGJlIGhvbmVzdCBJCj4gaGF2ZW4ndCBmdWxseSByZWFkIGl0 Lgo+Cj4gVGhpcyBsb29rcyBhIGJpdCBvZGQgc2luY2Ugb24gQU1EIFZHQSBoYXJkd2FyZSB0aGUg bm9uLXByZWZldGNoYWJsZSBCQVIKPiBpcyB1c3VhbGx5IG9ubHkgMzJiaXQsIG5vdCA2NGJpdC4K Pgo+IEJ1dCB0aGlzIGhhcmR3YXJlIGdlbmVyYXRpb24gaXMgcmF0aGVyIG9sZCBhbmQgSSdtIG5v dCBzdXJlIHdoYXQgdGhlIEJBUgo+IGFzc2lnbm1lbnQgZm9yIHRoYXQgZ2VuZXJhdGlvbiB3YXMu IEkgd291bGQgbmVlZCB0byBkaWcgdXAgdGhlIHJlZ2lzdGVyCj4gZGVzY3JpcHRpb24gaW4gb3Vy IGFyY2hpdmVzIGFzIHdlbGwuCj4KCkkgaGF2ZSBhbm90aGVyIG11c2V1bSBwaWVjZSBpbiBteSBB TUQgU2VhdHRsZToKCjAyOjAwLjAgVkdBIGNvbXBhdGlibGUgY29udHJvbGxlcjogQWR2YW5jZWQg TWljcm8gRGV2aWNlcywgSW5jLgpbQU1EL0FUSV0gT2xhbmQgWFQgW1JhZGVvbiBIRCA4NjcwIC8g UjcgMjUwLzM1MF0gKHJldiA4MSkgKHByb2ctaWYgMDAKW1ZHQSBjb250cm9sbGVyXSkKICBTdWJz eXN0ZW06IERlbGwgT2xhbmQgWFQgW1JhZGVvbiBIRCA4NjcwIC8gUjcgMjUwLzM1MF0KICBGbGFn czogYnVzIG1hc3RlciwgZmFzdCBkZXZzZWwsIGxhdGVuY3kgMCwgSVJRIDI1NQogIE1lbW9yeSBh dCAxMDAwMDAwMDAgKDY0LWJpdCwgcHJlZmV0Y2hhYmxlKSBbc2l6ZT00R10KICBNZW1vcnkgYXQg NDAwMDAwMDAgKDY0LWJpdCwgbm9uLXByZWZldGNoYWJsZSkgW3NpemU9MjU2S10KICBJL08gcG9y dHMgYXQgMTAwMCBbZGlzYWJsZWRdIFtzaXplPTI1Nl0KICBFeHBhbnNpb24gUk9NIGF0IDQwMDYw MDAwIFtkaXNhYmxlZF0gW3NpemU9MTI4S10KICBDYXBhYmlsaXRpZXM6IDxhY2Nlc3MgZGVuaWVk PgogIEtlcm5lbCBtb2R1bGVzOiByYWRlb24sIGFtZGdwdQoKU28gQU1EL0FUSSBBU0lDcyBkZWZp bml0ZWx5IGV4aXN0IHRoYXQgZXhwb3NlIGEgNjQtYml0IHByZWYgYW5kIGEKNjQtYml0IG5vbi1w cmVmIEJBUi4KCi0tIApBcmQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DC7C47082 for ; Wed, 26 May 2021 15:24:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59B7C613C9 for ; Wed, 26 May 2021 15:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B7C613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BQNpq78qTuBixhPFfWI7wtBXPUFry9+K7E7/sjxCfVU=; b=gkltTmzmUNAAgE sEUE4qUZP72+aLi5Oqdgc+QhfC8xBA5KHKgHLf065qft9DpcVuyVGBUNAx6hm9fldDsSgXQEWR5Du rZtWvur8LHYJDQYEoyojn11amCjbj1mLuLwhS+Wh/DFth9SKHSBc1Y4+4CvnKmfs7q6ncojLu3zQl b/mNrRlReaZZ5LrqbUsbqPEcEUaDkUQH77L79dDo4uIiQScVScgzX4qM80/m4vU0yeZ9hF7QSb727 dX4IOGhAg0jGjO1nh7BYAmOEBCF3crh61asIGZNTc0X8icPON07IwDLVn6f32nknpTJFASO5YAoRI J5OglYyO4NkbeGyXP7IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llvMH-00FJq5-Jd; Wed, 26 May 2021 15:22:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lluJV-00EmE7-Uy; Wed, 26 May 2021 14:15:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7054B613E1; Wed, 26 May 2021 14:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622038513; bh=V9yfVGz48znBhoLYjEcvRlIp+daisCyNDfH0CN868s4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dvLySTxEZiqHBU8DH6u3hrzj/0VudX+Pm4o9KGnIC8axkD+9PaZiv2F7PbCAMhuXl ZeeO7mNhyyyXa9eue79WEGTCXLOOHL4gm432bZz7BcvKQV38DZvaX+GPQIxzETcm8T mD24awDK8Uz+0BUmBoOAbktmxDwSqKnRjK9wiYEzrSANcvvsqFHEbpWBWST4A8FTx3 HclZI2Quz0gpF21n72viLd14SRFeky5BDhX4phZGE3Y7QzuEgUlbhAQtBrD12xLRls AOb2wzA2NOhnENSybyHuEQ+jbJa4Oslqju8HYAuZs9c/n3g2MwlPkKXBHIIfMYWBoL fbBwjsDcOveFg== Received: by mail-ot1-f45.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso1106416otl.13; Wed, 26 May 2021 07:15:13 -0700 (PDT) X-Gm-Message-State: AOAM533cfbb7fQqgkm4eH0gTNMdt4eaX6Ja44V7shqnUzh657KyMFA3O PkAkqVxrwjDlqc14QRsSs9sY9A5fI9q4ddY735o= X-Google-Smtp-Source: ABdhPJwW8Rk3emRD0hkgXQcN7xcSCM6FPDi3/JYZuHbFrFSjxpSMXx/i0GLgZamflQJyw1kM6Iit6JpDO+OpdpVyfzw= X-Received: by 2002:a05:6830:4da:: with SMTP id s26mr2542142otd.77.1622038512765; Wed, 26 May 2021 07:15:12 -0700 (PDT) MIME-Version: 1.0 References: <7a1e2ebc-f7d8-8431-d844-41a9c36a8911@arm.com> <01efd004-1c50-25ca-05e4-7e4ef96232e2@arm.com> <87eedxbtkn.fsf@stealth> <877djnaq11.fsf@stealth> <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> In-Reply-To: <9b99d520-e4b1-ae44-44eb-93c2e3d0c0cb@gmail.com> From: Ard Biesheuvel Date: Wed, 26 May 2021 16:15:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG] rockpro64: PCI BAR reassignment broken by commit 9d57e61bf723 ("of/pci: Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Peter Geis , Punit Agrawal , Robin Murphy , Alexandru Elisei , Linux Kernel Mailing List , "open list:ARM/Rockchip SoC..." , arm-mail-list , Heiko Stuebner , Leonardo Bras , Rob Herring , PCI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_071514_082550_BF5DBBBA X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNiBNYXkgMjAyMSBhdCAxNTo1NSwgQ2hyaXN0aWFuIEvDtm5pZwo8Y2tvZW5pZy5s ZWljaHR6dW1lcmtlbkBnbWFpbC5jb20+IHdyb3RlOgo+Cj4gSGkgQXJkLAo+Cj4gQW0gMjUuMDUu MjEgdW0gMTk6MTggc2NocmllYiBBcmQgQmllc2hldXZlbDoKPiA+IFtTTklQXQo+ID4+PiBJIHNl cmlvdXNseSBkb3VidCB0aGF0IHRoaXMgaXMgd2hhdCBpcyBnb2luZyBvbiBoZXJlLgo+ID4+Pgo+ ID4+PiBsc3BjaSAteCB3aWxsIGdpdmUgeW91IHRoZSBiYXJlIEJBUiB2YWx1ZXMgLSBJIHN1c3Bl Y3QgdGhhdCB0aG9zZSBhcmUKPiA+Pj4gcHJvYmFibHkgZmluZS4KPiA+PiBsc3BjaSAteAo+ID4+ IDAwOjAwLjAgUENJIGJyaWRnZTogRnV6aG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwgTHRk IERldmljZSAzNTY2IChyZXYgMDEpCj4gPj4gMDA6IDg3IDFkIDY2IDM1IDA3IDA1IDEwIDQwIDAx IDAwIDA0IDA2IDAwIDAwIDAxIDAwCj4gPj4gMTA6IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAw IDAxIGZmIDAwIDEwIDEwIDAwIDIwCj4gPj4gMjA6IDAwIDEwIDAwIDEwIDAxIDAwIGYxIDBmIDAw IDAwIDAwIDAwIDAwIDAwIDAwIDAwCj4gPj4gMzA6IDAwIDAwIDAwIDAwIDQwIDAwIDAwIDAwIDAw IDAwIDAwIDAwIDVmIDAxIDAyIDAwCj4gPj4KPiA+PiAwMTowMC4wIFZHQSBjb21wYXRpYmxlIGNv bnRyb2xsZXI6IEFkdmFuY2VkIE1pY3JvIERldmljZXMsIEluYy4KPiA+PiBbQU1EL0FUSV0gVHVy a3MgUFJPIFtSYWRlb24gSEQgNzU3MF0KPiA+PiAwMDogMDIgMTAgNWQgNjcgMDcgMDAgMTAgMjAg MDAgMDAgMDAgMDMgMDAgMDAgODAgMDAKPiA+PiAxMDogMGMgMDAgMDAgMDAgMDAgMDAgMDAgMDAK PiA+IFRoaXMgaXMgYSA2NC1iaXQgcHJlZmV0Y2hhYmxlIEJBUiBwcm9ncmFtbWVkIHdpdGggYnVz IGFkZHJlc3MgMHgwCj4gPgo+ID4+IDA0IDAwIDAwIDEwIDAwIDAwIDAwIDAwCj4gPiBUaGlzIGlz IGEgNjQtYml0IG5vbi1wcmVmZXRjaGFibGUgQkFSIHByb2dyYW1tZWQgd2l0aCBidXMgYWRkcmVz cyAweDEwMDBfMDAwMAo+ID4KPiA+IChodHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lraS9QQ0lf Y29uZmlndXJhdGlvbl9zcGFjZSBkZXNjcmliZXMgdGhlCj4gPiBtZWFuaW5nIG9mIHRoZSBsb3cg b3JkZXIgQkFSIGJpdHMpCj4KPiBTb3JyeSBmb3IganVtcGluZyBpbnRvIHRoZSBtaWRkbGUgb2Yg dGhlIGRpc2N1c3Npb24gYW5kIHRvIGJlIGhvbmVzdCBJCj4gaGF2ZW4ndCBmdWxseSByZWFkIGl0 Lgo+Cj4gVGhpcyBsb29rcyBhIGJpdCBvZGQgc2luY2Ugb24gQU1EIFZHQSBoYXJkd2FyZSB0aGUg bm9uLXByZWZldGNoYWJsZSBCQVIKPiBpcyB1c3VhbGx5IG9ubHkgMzJiaXQsIG5vdCA2NGJpdC4K Pgo+IEJ1dCB0aGlzIGhhcmR3YXJlIGdlbmVyYXRpb24gaXMgcmF0aGVyIG9sZCBhbmQgSSdtIG5v dCBzdXJlIHdoYXQgdGhlIEJBUgo+IGFzc2lnbm1lbnQgZm9yIHRoYXQgZ2VuZXJhdGlvbiB3YXMu IEkgd291bGQgbmVlZCB0byBkaWcgdXAgdGhlIHJlZ2lzdGVyCj4gZGVzY3JpcHRpb24gaW4gb3Vy IGFyY2hpdmVzIGFzIHdlbGwuCj4KCkkgaGF2ZSBhbm90aGVyIG11c2V1bSBwaWVjZSBpbiBteSBB TUQgU2VhdHRsZToKCjAyOjAwLjAgVkdBIGNvbXBhdGlibGUgY29udHJvbGxlcjogQWR2YW5jZWQg TWljcm8gRGV2aWNlcywgSW5jLgpbQU1EL0FUSV0gT2xhbmQgWFQgW1JhZGVvbiBIRCA4NjcwIC8g UjcgMjUwLzM1MF0gKHJldiA4MSkgKHByb2ctaWYgMDAKW1ZHQSBjb250cm9sbGVyXSkKICBTdWJz eXN0ZW06IERlbGwgT2xhbmQgWFQgW1JhZGVvbiBIRCA4NjcwIC8gUjcgMjUwLzM1MF0KICBGbGFn czogYnVzIG1hc3RlciwgZmFzdCBkZXZzZWwsIGxhdGVuY3kgMCwgSVJRIDI1NQogIE1lbW9yeSBh dCAxMDAwMDAwMDAgKDY0LWJpdCwgcHJlZmV0Y2hhYmxlKSBbc2l6ZT00R10KICBNZW1vcnkgYXQg NDAwMDAwMDAgKDY0LWJpdCwgbm9uLXByZWZldGNoYWJsZSkgW3NpemU9MjU2S10KICBJL08gcG9y dHMgYXQgMTAwMCBbZGlzYWJsZWRdIFtzaXplPTI1Nl0KICBFeHBhbnNpb24gUk9NIGF0IDQwMDYw MDAwIFtkaXNhYmxlZF0gW3NpemU9MTI4S10KICBDYXBhYmlsaXRpZXM6IDxhY2Nlc3MgZGVuaWVk PgogIEtlcm5lbCBtb2R1bGVzOiByYWRlb24sIGFtZGdwdQoKU28gQU1EL0FUSSBBU0lDcyBkZWZp bml0ZWx5IGV4aXN0IHRoYXQgZXhwb3NlIGEgNjQtYml0IHByZWYgYW5kIGEKNjQtYml0IG5vbi1w cmVmIEJBUi4KCi0tIApBcmQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==