From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
Drew Fustini <drew@pdp7.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v6 0/7] gpio: expose line bias flags to userspace
Date: Thu, 7 Nov 2019 12:28:09 +0100 [thread overview]
Message-ID: <CAMpxmJXJRsUUU34561jVjQEot58N27P8UWFz292yq_XRSW0ftA@mail.gmail.com> (raw)
In-Reply-To: <20191107103943.GA29374@sol>
czw., 7 lis 2019 o 11:39 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> On Thu, Nov 07, 2019 at 12:58:04AM +0800, Kent Gibson wrote:
> > I've pushed some more changes with the updated API we discussed earlier.
> > Those new tests I'd added now pass. Yay.
> > One problem though - gpiod_line_set_config as written has no way to
> > accept an as-is direction.
> > Hopefully I'll have some time to take another look at that tomorrow.
> >
>
> I've pushed some more updates to my libgpiod branch[1]. They fix the
> direction limitation I mentioned (I was using the wrong set flags),
> and extend the tests to cover all of the SET_CONFIG fields.
>
> That completes the C API changes.
> If that is ok with you then I can take a look at the corresponding
> changes to the C++ and Python bindings.
>
> And I guess we should move this libgpiod discussion to a new thread?
Yes, and better yet - you could simply send these patches for review
and we can continue the discussion there.
Bart
>
> Cheers,
> Kent.
>
> [1] https://github.com/warthog618/libgpiod.git
>
next prev parent reply other threads:[~2019-11-07 11:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 2:04 [PATCH v6 0/7] gpio: expose line bias flags to userspace Kent Gibson
2019-11-05 2:04 ` [PATCH v6 1/7] gpio: expose pull-up/pull-down line " Kent Gibson
2019-11-05 2:04 ` [PATCH v6 2/7] gpiolib: add support for pull up/down to lineevent_create Kent Gibson
2019-11-05 2:04 ` [PATCH v6 3/7] gpiolib: add support for disabling line bias Kent Gibson
2019-11-05 2:04 ` [PATCH v6 4/7] gpiolib: add support for biasing output lines Kent Gibson
2019-11-06 19:39 ` Drew Fustini
2019-11-06 23:56 ` Kent Gibson
2019-11-05 2:04 ` [PATCH v6 5/7] gpio: mockup: add set_config to support pull up/down Kent Gibson
2019-11-05 2:04 ` [PATCH v6 6/7] gpiolib: move validation of line handle flags into helper function Kent Gibson
2019-11-05 2:04 ` [PATCH v6 7/7] gpio: add new SET_CONFIG ioctl() to gpio chardev Kent Gibson
2019-11-05 15:05 ` [PATCH v6 0/7] gpio: expose line bias flags to userspace Bartosz Golaszewski
2019-11-07 8:10 ` Linus Walleij
2019-11-05 15:26 ` Kent Gibson
2019-11-05 16:24 ` Bartosz Golaszewski
2019-11-05 21:07 ` Bartosz Golaszewski
2019-11-06 6:48 ` Kent Gibson
2019-11-06 13:59 ` Bartosz Golaszewski
2019-11-06 16:58 ` Kent Gibson
2019-11-06 17:06 ` Bartosz Golaszewski
2019-11-06 23:20 ` Kent Gibson
2019-11-07 10:39 ` Kent Gibson
2019-11-07 11:28 ` Bartosz Golaszewski [this message]
2019-11-07 12:18 ` Kent Gibson
2019-11-05 23:15 ` Kent Gibson
2019-11-07 17:57 ` Bartosz Golaszewski
2020-04-15 14:03 ` boards to test gpio line bias flags? Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJXJRsUUU34561jVjQEot58N27P8UWFz292yq_XRSW0ftA@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=drew@pdp7.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.