From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6274CC49EAF for ; Fri, 25 Jun 2021 15:22:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 464D06193D for ; Fri, 25 Jun 2021 15:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbhFYPZE convert rfc822-to-8bit (ORCPT ); Fri, 25 Jun 2021 11:25:04 -0400 Received: from mail-ua1-f51.google.com ([209.85.222.51]:33382 "EHLO mail-ua1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhFYPZD (ORCPT ); Fri, 25 Jun 2021 11:25:03 -0400 Received: by mail-ua1-f51.google.com with SMTP id x22so3706629uap.0; Fri, 25 Jun 2021 08:22:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dckc1Y5oArfmqGf9uhmcW+nVHTA44z1zSQ9JQ8A7cx0=; b=OdFz68Ss39x1a3x9wewTT1eEq+Owq4P92wZJSjxYbRsN75VneRc0R979vQnEjDAQ3R htxICHBUvvcrZFGud10IQS4rrn8vYVa4wFpP3DIl13JpwVUQGPUCyFwsFJUhki7Wgo3m 7YixqNtyUdyxLHfsmCb+4gDlAq6Ypa79BCavSC/trjPtPh/PRfUJlqFli/H9uPN7U3vO BIOmCwpaWHNm9oIZJBm2RuLy1rXDNMT9p9Zdyz0tzAz9wcj7dqdPHPoPCnU4Ggk5KZS3 4bZ+z/9uyhU/NuoA7FrmfDNDJs94lBn4zPEc9X9Xzpkz75ITXKKUqH/bPoOJPdOqXug+ x6eQ== X-Gm-Message-State: AOAM532Ra1lXQYquyWN0TEMxj6/hNrCks/8V24AZjnBn+G54EKPX7JFL aT3P2UCKMGzOidvWfkaGtj7lYawUqooo9M6jTlc= X-Google-Smtp-Source: ABdhPJxwYqp45mNSYBwJKHtWJ8GFH7IJzuCBQqhfVtE1/NiRa0Ja4ZkGaTYr8Tie+8VSPZCAVrVmqKI1uLm5wnTFnqw= X-Received: by 2002:ab0:647:: with SMTP id f65mr11970038uaf.4.1624634562204; Fri, 25 Jun 2021 08:22:42 -0700 (PDT) MIME-Version: 1.0 References: <20210624224909.6350-1-pali@kernel.org> <20210625143617.12826-1-pali@kernel.org> <20210625143617.12826-8-pali@kernel.org> In-Reply-To: <20210625143617.12826-8-pali@kernel.org> From: Geert Uytterhoeven Date: Fri, 25 Jun 2021 17:22:31 +0200 Message-ID: Subject: Re: [PATCH v2 07/11] math64: New DIV_U64_ROUND_CLOSEST helper To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?B?TWFyZWsgQmVow7pu?= , linux-clk , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pali, On Fri, Jun 25, 2021 at 4:37 PM Pali Rohár wrote: > Provide DIV_U64_ROUND_CLOSEST helper which uses div_u64 to perform > division rounded to the closest integer using unsigned 64bit > dividend and unsigned 32bit divisor. > > Signed-off-by: Pali Rohár Thanks for your patch! > --- a/include/linux/math64.h > +++ b/include/linux/math64.h > @@ -281,6 +281,19 @@ u64 mul_u64_u64_div_u64(u64 a, u64 mul, u64 div); > #define DIV64_U64_ROUND_CLOSEST(dividend, divisor) \ > ({ u64 _tmp = (divisor); div64_u64((dividend) + _tmp / 2, _tmp); }) > > +/* > + * DIV_U64_ROUND_CLOSEST - unsigned 64bit divide with 32bit divisor rounded to nearest integer > + * @dividend: unsigned 64bit dividend > + * @divisor: unsigned 32bit divisor > + * > + * Divide unsigned 64bit dividend by unsigned 32bit divisor > + * and round to closest integer. > + * > + * Return: dividend / divisor rounded to nearest integer > + */ > +#define DIV_U64_ROUND_CLOSEST(dividend, divisor) \ > + ({ u32 _tmp = (divisor); div_u64((u64)(dividend) + _tmp / 2, _tmp); }) Given "dividend" should already be an unsigned 64-bit value, I don't think the cast to "u64" is needed. Similar macros in this file also don't have the cast. > + > /* > * DIV_S64_ROUND_CLOSEST - signed 64bit divide with 32bit divisor rounded to nearest integer > * @dividend: signed 64bit dividend With the above nit fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C74AC2B9F4 for ; Fri, 25 Jun 2021 15:24:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6846193D for ; Fri, 25 Jun 2021 15:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6846193D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+XE67xV+EMUp5+6W3tgvcXnSgon3DGc8bDoBPXAFNXk=; b=GBG8IRzm7/GRYE VSm1bqkuPtzrP3Hd91G7+AKymA7XBYYp60xx0zD1rz21TnkO3xTyTVuqrHTs3r/vx4tsho5ztYdos uV+4w5/3I4VCd7goNB4UmpbxqzqNV4dX1jBsttozmczND3XmJyIhmhfQ539Vgn9H3GR87v3iLcwCi 10wBk8w/lhsbM3CcQJWNY4H9z/OC/SwZ5noHxkTOk6fwewgrzEDqcSUTHYgLtQJsbuPWNrS14F+hu 4nbqRBqt4yUMmtXuoFmTZNioErvCoZkcvgXhAk1avHW7/1Yvpfjmd9RTZW99arJbQGcRHSAUzigOn qFeSEldUy/EUj1mYWlKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwnfL-0027TB-IH; Fri, 25 Jun 2021 15:22:47 +0000 Received: from mail-ua1-f47.google.com ([209.85.222.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwnfH-0027Rf-Su for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 15:22:45 +0000 Received: by mail-ua1-f47.google.com with SMTP id n61so3688223uan.2 for ; Fri, 25 Jun 2021 08:22:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dckc1Y5oArfmqGf9uhmcW+nVHTA44z1zSQ9JQ8A7cx0=; b=NyQrS7i9vO22hELrER8JI5NfwqHJ2tvjg5aI7cHPOMsZH6FUnJbjBpsHzH2D+GiglR 8MVvxfis3cVA+0GAuRrflZNkuqit3XTd/u5iX/EsNM3x/Ksp6PObnZZWfjb3NhaSENgh v1LQqLZIa5ogkxae/oGsWIU3z3QESAzw/cOk1X3KSG14esMR3Lm4wdw+XH6q9xPV0vk7 ELNXVaRhgOtOg4CyLwW280txjCQ/BIXx+WLzLcqtZVHpb1bcP3x2oNBlQRs6UEtb1Xom NnXivp+4ark8LOf6ctb84o1kSuYluiLDoLPgTZezdTJ2K789Yu4WbzSVUyl/5jEYjxll vI5w== X-Gm-Message-State: AOAM531HYpybxcnwQJjyH0hpvuIOH6cr2VgmX21J8ZWaOCfb5DGpvwdT PUWLEkcrqx2SfidOo2/mOyxjakmE1Csgx1qOaxQ= X-Google-Smtp-Source: ABdhPJxwYqp45mNSYBwJKHtWJ8GFH7IJzuCBQqhfVtE1/NiRa0Ja4ZkGaTYr8Tie+8VSPZCAVrVmqKI1uLm5wnTFnqw= X-Received: by 2002:ab0:647:: with SMTP id f65mr11970038uaf.4.1624634562204; Fri, 25 Jun 2021 08:22:42 -0700 (PDT) MIME-Version: 1.0 References: <20210624224909.6350-1-pali@kernel.org> <20210625143617.12826-1-pali@kernel.org> <20210625143617.12826-8-pali@kernel.org> In-Reply-To: <20210625143617.12826-8-pali@kernel.org> From: Geert Uytterhoeven Date: Fri, 25 Jun 2021 17:22:31 +0200 Message-ID: Subject: Re: [PATCH v2 07/11] math64: New DIV_U64_ROUND_CLOSEST helper To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?B?TWFyZWsgQmVow7pu?= , linux-clk , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_082243_983620_13B85F43 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGFsaSwKCk9uIEZyaSwgSnVuIDI1LCAyMDIxIGF0IDQ6MzcgUE0gUGFsaSBSb2jDoXIgPHBh bGlAa2VybmVsLm9yZz4gd3JvdGU6Cj4gUHJvdmlkZSBESVZfVTY0X1JPVU5EX0NMT1NFU1QgaGVs cGVyIHdoaWNoIHVzZXMgZGl2X3U2NCB0byBwZXJmb3JtCj4gZGl2aXNpb24gcm91bmRlZCB0byB0 aGUgY2xvc2VzdCBpbnRlZ2VyIHVzaW5nIHVuc2lnbmVkIDY0Yml0Cj4gZGl2aWRlbmQgYW5kIHVu c2lnbmVkIDMyYml0IGRpdmlzb3IuCj4KPiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFs aUBrZXJuZWwub3JnPgoKVGhhbmtzIGZvciB5b3VyIHBhdGNoIQoKPiAtLS0gYS9pbmNsdWRlL2xp bnV4L21hdGg2NC5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9tYXRoNjQuaAo+IEBAIC0yODEsNiAr MjgxLDE5IEBAIHU2NCBtdWxfdTY0X3U2NF9kaXZfdTY0KHU2NCBhLCB1NjQgbXVsLCB1NjQgZGl2 KTsKPiAgI2RlZmluZSBESVY2NF9VNjRfUk9VTkRfQ0xPU0VTVChkaXZpZGVuZCwgZGl2aXNvcikg ICAgIFwKPiAgICAgICAgICh7IHU2NCBfdG1wID0gKGRpdmlzb3IpOyBkaXY2NF91NjQoKGRpdmlk ZW5kKSArIF90bXAgLyAyLCBfdG1wKTsgfSkKPgo+ICsvKgo+ICsgKiBESVZfVTY0X1JPVU5EX0NM T1NFU1QgLSB1bnNpZ25lZCA2NGJpdCBkaXZpZGUgd2l0aCAzMmJpdCBkaXZpc29yIHJvdW5kZWQg dG8gbmVhcmVzdCBpbnRlZ2VyCj4gKyAqIEBkaXZpZGVuZDogdW5zaWduZWQgNjRiaXQgZGl2aWRl bmQKPiArICogQGRpdmlzb3I6IHVuc2lnbmVkIDMyYml0IGRpdmlzb3IKPiArICoKPiArICogRGl2 aWRlIHVuc2lnbmVkIDY0Yml0IGRpdmlkZW5kIGJ5IHVuc2lnbmVkIDMyYml0IGRpdmlzb3IKPiAr ICogYW5kIHJvdW5kIHRvIGNsb3Nlc3QgaW50ZWdlci4KPiArICoKPiArICogUmV0dXJuOiBkaXZp ZGVuZCAvIGRpdmlzb3Igcm91bmRlZCB0byBuZWFyZXN0IGludGVnZXIKPiArICovCj4gKyNkZWZp bmUgRElWX1U2NF9ST1VORF9DTE9TRVNUKGRpdmlkZW5kLCBkaXZpc29yKSAgICAgICBcCj4gKyAg ICAgICAoeyB1MzIgX3RtcCA9IChkaXZpc29yKTsgZGl2X3U2NCgodTY0KShkaXZpZGVuZCkgKyBf dG1wIC8gMiwgX3RtcCk7IH0pCgpHaXZlbiAiZGl2aWRlbmQiIHNob3VsZCBhbHJlYWR5IGJlIGFu IHVuc2lnbmVkIDY0LWJpdCB2YWx1ZSwgSSBkb24ndAp0aGluayB0aGUgY2FzdCB0byAidTY0IiBp cyBuZWVkZWQuIFNpbWlsYXIgbWFjcm9zIGluIHRoaXMgZmlsZSBhbHNvCmRvbid0IGhhdmUgdGhl IGNhc3QuCgo+ICsKPiAgLyoKPiAgICogRElWX1M2NF9ST1VORF9DTE9TRVNUIC0gc2lnbmVkIDY0 Yml0IGRpdmlkZSB3aXRoIDMyYml0IGRpdmlzb3Igcm91bmRlZCB0byBuZWFyZXN0IGludGVnZXIK PiAgICogQGRpdmlkZW5kOiBzaWduZWQgNjRiaXQgZGl2aWRlbmQKCldpdGggdGhlIGFib3ZlIG5p dCBmaXhlZDoKUmV2aWV3ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2VlcnQrcmVuZXNhc0Bn bGlkZXIuYmU+CgpHcntvZXRqZSxlZXRpbmd9cywKCiAgICAgICAgICAgICAgICAgICAgICAgIEdl ZXJ0CgotLSAKR2VlcnQgVXl0dGVyaG9ldmVuIC0tIFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlv bmQgaWEzMiAtLSBnZWVydEBsaW51eC1tNjhrLm9yZwoKSW4gcGVyc29uYWwgY29udmVyc2F0aW9u cyB3aXRoIHRlY2huaWNhbCBwZW9wbGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dAp3aGVu IEknbSB0YWxraW5nIHRvIGpvdXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNv bWV0aGluZyBsaWtlIHRoYXQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGlu dXMgVG9ydmFsZHMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK