Re: b4 not finding explicitly specified patch

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: "users@linux.kernel.org" <users@linux.kernel.org>,
	tools@linux.kernel.org
Subject: Re: b4 not finding explicitly specified patch
Date: Mon, 7 Jun 2021 09:30:51 +0200	[thread overview]
Message-ID: <CAMuHMdWFLeROkPnd6GtKsQ5O+cEBxB3YAmw=KkZzXSL9_2OG5g@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWX0iyNFdUV3z8T2dswnczGeXSLLB+txP4thLua+=SiYw@mail.gmail.com>

Hi Konstantin,

On Fri, May 21, 2021 at 3:18 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Fri, May 21, 2021 at 2:28 PM Konstantin Ryabitsev
> <konstantin@linuxfoundation.org> wrote:
> > On Fri, May 21, 2021 at 09:06:20AM +0200, Geert Uytterhoeven wrote:
> > > Note that without "-P_", it still downloads the series not containing the patch
> > > I specified.
> >
> > I'm not sure if I can fix that, because that thread is a bit wonky. You will
> > notice that we have:
> >
> > [PATCH v1 0/5]
> > ...
> > [PATCH v1 5/5]
> >  \- Re: [PATCH v1 5/5]
> >   \- [TEST PATCH v1]
> >
> > b4 is really built around retrieving series, and here we can't figure out
> > where in the series [TEST PATCH v1] belongs. I *believe* the intent here is to
> > replace [PATCH v1 5/5], but it doesn't have any counters on it, so we end up
> > ignoring it because we already have a [PATCH v1 1/5].
>
> Yeah, it's a weird case ;-)

Just ran into another weird case:

$ b4 am 1622957313-321-1-git-send-email-schmitzmic@gmail.com
Looking up https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic%40gmail.com
Analyzing 28 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH RFC 1/2] m68k: io_mm.h: conditionalize ISA address
translation on Atari
  ✓ [PATCH RFC 2/2] m68k: setup_mm.c: set isa_sex for Atari if
ATARI_ROM_ISA not used
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 2
---
Cover: ./20210602_schmitzmic_fix_m68k_multiplatform_isa_support.cover
 Link: https://lore.kernel.org/r/1622611267-15825-1-git-send-email-schmitzmic@gmail.com
 Base: not found (applies clean to current tree)
       git am ./20210602_schmitzmic_fix_m68k_multiplatform_isa_support.mbx

No, that's the RFC.

$ b4 am -P_ 1622957313-321-1-git-send-email-schmitzmic@gmail.com
Looking up https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic%40gmail.com
Analyzing 1 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] m68k: Fix multiplatform ISA support
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1 (cherrypicked:
<1622957313-321-1-git-send-email-schmitzmic@gmail.com>)
---
 Link: https://lore.kernel.org/r/1622957313-321-1-git-send-email-schmitzmic@gmail.com
 Base: not found (applies clean to current tree)
       git am ./20210606_schmitzmic_m68k_fix_multiplatform_isa_support.mbx

Yeah, that's the one I want.

At least the chain "RFC" -> implicit v1 -> "v2" -> "v3" ... is less fuzzy
than "[PATCH v1 5/5]" -> "[TEST PATCH v1]"...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds