From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A143BC433E0 for ; Fri, 8 Jan 2021 13:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 616CF235FC for ; Fri, 8 Jan 2021 13:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbhAHNAX (ORCPT ); Fri, 8 Jan 2021 08:00:23 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:46174 "EHLO mail-ot1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbhAHNAU (ORCPT ); Fri, 8 Jan 2021 08:00:20 -0500 Received: by mail-ot1-f41.google.com with SMTP id w3so9501560otp.13; Fri, 08 Jan 2021 05:00:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nK3cWo1amowhiwULtOouzGk6luz5/qofhSkKlFioO3k=; b=cC8Qj2ffdr8c7tAD151+DWsrnMgb1ABfrDQnZN+v8SHha04UHz/KTRLgLlaVN19PYI AwCQp87dY6MY94GXJ+osY0egjWx22Sw2QzZ3c2/ulTfPmUdjQXZ/wxpAb/tCJ7xJjPch gwGCkCCM+yPWR4flL/8UKB/zVsQdQQyNqDKtBksZbWmqt+MVTfO1u3aKQrQMFOaPFgDm l2ikKvTxv3gtoQa3f9auCnDoGbEMtT1f+fxXZ7L6kHPC5ORJ0TiHv6pv1kPlRvzuVPHy b7+hZwTM88NOtI55bLUJchi0cIJOlbsF6CjKFezboNdlSFBeAG3e4tO0GdcLm8WVwevW FQXg== X-Gm-Message-State: AOAM531W3HHDoWJ3oAHVhliMZwofkAG5ms7uKmIQUbqcaxuj53HSEQI2 AQPiRaFKjQGvA/8hyAIVAZvfKJ6WLOC53iYtM7k= X-Google-Smtp-Source: ABdhPJyXHMuGda2nzp/UaHZmPhb9ahjx0nuAZYkHw7x/W8zRv3eJhC3BNCFyRSG1LicuLkDVg1Wbdz1MAZSPnwe6YJU= X-Received: by 2002:a9d:c01:: with SMTP id 1mr2419145otr.107.1610110778895; Fri, 08 Jan 2021 04:59:38 -0800 (PST) MIME-Version: 1.0 References: <20201227174202.40834-1-wsa+renesas@sang-engineering.com> <20201227174202.40834-7-wsa+renesas@sang-engineering.com> In-Reply-To: <20201227174202.40834-7-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Fri, 8 Jan 2021 13:59:27 +0100 Message-ID: Subject: Re: [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC To: Wolfram Sang Cc: Linux-Renesas , Takeshi Saito , Koji Matsuoka , Magnus Damm , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang wrote: > From: Takeshi Saito > > Enable MMC on the Falcon board. > > Signed-off-by: Koji Matsuoka > [wsa: double checked & rebased] > Signed-off-by: Wolfram Sang Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > @@ -20,6 +20,24 @@ aliases { > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + reg_1p8v: regulator0 { Please use a better node name, to avoid accidental duplicates, cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight regulator name") > + compatible = "regulator-fixed"; > + regulator-name = "fixed-1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_3p3v: regulator1 { Likewise > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > &avb0 { > @@ -169,6 +187,23 @@ &i2c6 { > clock-frequency = <100000>; > }; > > +&mmc0 { > + pinctrl-0 = <&mmc_pins>; > + pinctrl-1 = <&mmc_pins>; > + pinctrl-names = "default", "state_uhs"; > + > + vmmc-supply = <®_3p3v>; > + vqmmc-supply = <®_1p8v>; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + bus-width = <8>; > + no-sd; > + no-sdio; I'm no expert on the no-sd{,io} properties. Just wondering if we need them on other R-Car gen3 boards with eMMC, too/ > + non-removable; > + full-pwr-cycle-in-suspend; > + status = "okay"; > +}; With the node names fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds