From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC8F7C10DCE for ; Fri, 6 Mar 2020 10:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B93DD2084E for ; Fri, 6 Mar 2020 10:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726069AbgCFKpi convert rfc822-to-8bit (ORCPT ); Fri, 6 Mar 2020 05:45:38 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:46024 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgCFKpi (ORCPT ); Fri, 6 Mar 2020 05:45:38 -0500 Received: by mail-oi1-f194.google.com with SMTP id v19so2058321oic.12 for ; Fri, 06 Mar 2020 02:45:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HroD0on08tLEMYhs9qrREoR+/CxJ/32j4jpzzO71uX0=; b=Z5wMs/coYeoADCQXX6FRUPtXvpO2hY+BtsLb9DQ/NQAzWP05gSApTR4kZBFu+mEyHf lTBtSv6k8dZOUwgW/ouAcL4Nam3ynwSfnBF6GVgZmqoWbv9XHO+aadNU9p37jFGHdZbu ET+9ndP4CaeS3eNtxXEIpVyYKZjE/iPl4DBtMGi4z1hqVvDXzGZgeHrH0pNwXExlq37x 6BKv5R2kAri34G/KJ0PbtaUojJIBWQpqm9SimHf2UbWfsgnRVferGSng9brsOROZWHyf q1TyTQEPOdBpBp6cAD+q3s8TlHyRWwL3R2NWT9k572KuASibjKE7AjLr2rDKqoXl3gvr p4ew== X-Gm-Message-State: ANhLgQ1TvHkJA3pIor/pLjK7UAAgk2IllLPhDVoEn/ni18dabaiHPyg7 05hRRCC7XR5hIK8o4K55Lj8pxEzipnLbZlVgLqA= X-Google-Smtp-Source: ADFU+vvtUPH3/Ph9fb3frspC4QqnvQ+CWNfeWzdZ5p3uA2hEhHOsJ1oZpb7TnnmVwlAmCRdczLdbAoij4DJyvJ/brwE= X-Received: by 2002:aca:1a06:: with SMTP id a6mr2005904oia.148.1583491536148; Fri, 06 Mar 2020 02:45:36 -0800 (PST) MIME-Version: 1.0 References: <20200302155703.278421-1-mylene.josserand@collabora.com> <20200302155703.278421-2-mylene.josserand@collabora.com> <2221545.2vEflg7qi2@diego> In-Reply-To: <2221545.2vEflg7qi2@diego> From: Geert Uytterhoeven Date: Fri, 6 Mar 2020 11:45:25 +0100 Message-ID: Subject: Re: [PATCH 1/2] ARM: Rockchip: Handle rk3288/rk3288w revision To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= , Stephen Boyd , Michael Turquette , Russell King , "open list:ARM/Rockchip SoC..." , Collabora Kernel ML , linux-clk , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Heiko, On Wed, Mar 4, 2020 at 12:00 PM Heiko Stübner wrote: > Am Montag, 2. März 2020, 16:57:02 CET schrieb Mylène Josserand: > > Determine which revision of rk3288 by checking the HDMI version. > > According to the Rockchip BSP kernel, on rk3288w, the HDMI > > revision equals 0x1A which is not the case for the rk3288 [1]. > > > > As these SOC have some differences, the new function > > 'soc_is_rk3288w' will help us to know on which revision > > we are. > > what happened to just having a different compatible in the dts? > Aka doing a > > rk3288w.dtsi with > > #include "rk3288.dtsi" > > &cru { > compatible = "rockchip,rk3288w-cru"; > } > > I somehow don't expect boards to just switch between soc variants > on the fly. > > Also, doing things in mach-rockchip is not very future-proof: > > (1) having random soc-specific APIs spanning the kernel feels wrong, > especially as at some point it might not be contained to our own special > drivers like the cru. I cannot really see people being enthusiastic if > something like this would be needed in say the core Analogix-DP bridge ;-) Indeed. You're better of registering an soc_device_attribute using soc_device_register(), after which any driver can use soc_device_match() to differentiate based on the SoC revision. > (2) I guess the rk3288w will not be the last soc doing this and on arm64 you > can't do it that way, as there is no mach-rockchip there There's drivers/soc/rockchip ;-) > So my personal preference would really would be just a specific compatible > for affected ip blocks. Doing that only for affected IP blocks may miss integration differences. Of course, you can always resort to soc_device_match() to handle those... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 047D3C10F00 for ; Fri, 6 Mar 2020 10:45:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD83A2072D for ; Fri, 6 Mar 2020 10:45:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lRfHAcE2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD83A2072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qcvc2DG9TzX2BRaAk7ao7VybelDPFeBwujagw6Ig7i4=; b=lRfHAcE2N6KTne J95we8z/I0/nX5P2D3epR303g5LTrLfyrDw10dLE5W9bh2BHT6oNId3EBkUg1iOf3dkKlEVCWg4dU VZQSshBmC6xVg5JhTWDtrU6ScYwexNJEYlFrNYqvq1/7jZ7G4LV/NwQe4KpjDd0m6tgARSl1ZDCxt g/Tr989O4VcBth37BuZ+8sw1dr9f4AL6tpufeB+a9ei9sszdc93TZjrjwRKvr0FMnRn+Cyrz9PAp7 H0BtaSIBi+FxgDLnoXhI3TXOMZmuYxV5ejBtG6t9AjLAA6Yg31jOPAGxA+swnPLwHxKTmw2maSW5+ M03EH7lQ8fUCEVZg0KFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAAUA-0006BT-La; Fri, 06 Mar 2020 10:45:42 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAAU7-000696-3F; Fri, 06 Mar 2020 10:45:40 +0000 Received: by mail-oi1-f196.google.com with SMTP id a22so2046162oid.13; Fri, 06 Mar 2020 02:45:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HroD0on08tLEMYhs9qrREoR+/CxJ/32j4jpzzO71uX0=; b=c4fklFyB7FFMNJ8U4/gSTO49rNKoeU4dGmm7w4FD/EoDmBkIyXSeHuBwLF+srWsPYo EcovG7jQCxpSsn3i2V2KEJKOZXFtAGnYAQ/q0nUKLuYR2CswOhYOSkqTC6cxNyNO4Wew xxsTp6ipCSwA91hGppV4EKMHa0M1UhAs8xq+CpkIQxw6A0jnsz80poNipb5tvchig5oo huen5cJvceQbIO44ykTwynNfaevyasdlnLFaSJ7VY7+Bpp1g0sE/w8xC2q6651jPf4n3 /uMuxLbe/ltIO3j1cCXbPIpFUlhrd1z/AHy0jFzwUtwmd8IRBbonvc6SUEcY40ZnkC40 mX8g== X-Gm-Message-State: ANhLgQ3B2KPu8nxnmd0QnHHKmgkMYGEI+s6SUS7YM+g7HJx7FueCC+ZA 3aoX7HqkEsR0CXa1bqfejU2sNqhNg2sE8fEELagTDHYT X-Google-Smtp-Source: ADFU+vvtUPH3/Ph9fb3frspC4QqnvQ+CWNfeWzdZ5p3uA2hEhHOsJ1oZpb7TnnmVwlAmCRdczLdbAoij4DJyvJ/brwE= X-Received: by 2002:aca:1a06:: with SMTP id a6mr2005904oia.148.1583491536148; Fri, 06 Mar 2020 02:45:36 -0800 (PST) MIME-Version: 1.0 References: <20200302155703.278421-1-mylene.josserand@collabora.com> <20200302155703.278421-2-mylene.josserand@collabora.com> <2221545.2vEflg7qi2@diego> In-Reply-To: <2221545.2vEflg7qi2@diego> From: Geert Uytterhoeven Date: Fri, 6 Mar 2020 11:45:25 +0100 Message-ID: Subject: Re: [PATCH 1/2] ARM: Rockchip: Handle rk3288/rk3288w revision To: =?UTF-8?Q?Heiko_St=C3=BCbner?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_024539_139638_F3880DCB X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= , Stephen Boyd , Michael Turquette , Russell King , "open list:ARM/Rockchip SoC..." , Collabora Kernel ML , linux-clk , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSGVpa28sCgpPbiBXZWQsIE1hciA0LCAyMDIwIGF0IDEyOjAwIFBNIEhlaWtvIFN0w7xibmVy IDxoZWlrb0BzbnRlY2guZGU+IHdyb3RlOgo+IEFtIE1vbnRhZywgMi4gTcOkcnogMjAyMCwgMTY6 NTc6MDIgQ0VUIHNjaHJpZWIgTXlsw6huZSBKb3NzZXJhbmQ6Cj4gPiBEZXRlcm1pbmUgd2hpY2gg cmV2aXNpb24gb2YgcmszMjg4IGJ5IGNoZWNraW5nIHRoZSBIRE1JIHZlcnNpb24uCj4gPiBBY2Nv cmRpbmcgdG8gdGhlIFJvY2tjaGlwIEJTUCBrZXJuZWwsIG9uIHJrMzI4OHcsIHRoZSBIRE1JCj4g PiByZXZpc2lvbiBlcXVhbHMgMHgxQSB3aGljaCBpcyBub3QgdGhlIGNhc2UgZm9yIHRoZSByazMy ODggWzFdLgo+ID4KPiA+IEFzIHRoZXNlIFNPQyBoYXZlIHNvbWUgZGlmZmVyZW5jZXMsIHRoZSBu ZXcgZnVuY3Rpb24KPiA+ICdzb2NfaXNfcmszMjg4dycgd2lsbCBoZWxwIHVzIHRvIGtub3cgb24g d2hpY2ggcmV2aXNpb24KPiA+IHdlIGFyZS4KPgo+IHdoYXQgaGFwcGVuZWQgdG8ganVzdCBoYXZp bmcgYSBkaWZmZXJlbnQgY29tcGF0aWJsZSBpbiB0aGUgZHRzPwo+IEFrYSBkb2luZyBhCj4KPiBy azMyODh3LmR0c2kgd2l0aAo+Cj4gI2luY2x1ZGUgInJrMzI4OC5kdHNpIgo+Cj4gJmNydSB7Cj4g ICAgICAgICBjb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzI4OHctY3J1IjsKPiB9Cj4KPiBJIHNv bWVob3cgZG9uJ3QgZXhwZWN0IGJvYXJkcyB0byBqdXN0IHN3aXRjaCBiZXR3ZWVuIHNvYyB2YXJp YW50cwo+IG9uIHRoZSBmbHkuCj4KPiBBbHNvLCBkb2luZyB0aGluZ3MgaW4gbWFjaC1yb2NrY2hp cCBpcyBub3QgdmVyeSBmdXR1cmUtcHJvb2Y6Cj4KPiAoMSkgaGF2aW5nIHJhbmRvbSBzb2Mtc3Bl Y2lmaWMgQVBJcyBzcGFubmluZyB0aGUga2VybmVsIGZlZWxzIHdyb25nLAo+ICAgICBlc3BlY2lh bGx5IGFzIGF0IHNvbWUgcG9pbnQgaXQgbWlnaHQgbm90IGJlIGNvbnRhaW5lZCB0byBvdXIgb3du IHNwZWNpYWwKPiAgICAgZHJpdmVycyBsaWtlIHRoZSBjcnUuIEkgY2Fubm90IHJlYWxseSBzZWUg cGVvcGxlIGJlaW5nIGVudGh1c2lhc3RpYyBpZgo+ICAgICBzb21ldGhpbmcgbGlrZSB0aGlzIHdv dWxkIGJlIG5lZWRlZCBpbiBzYXkgdGhlIGNvcmUgQW5hbG9naXgtRFAgYnJpZGdlIDstKQoKSW5k ZWVkLiAgWW91J3JlIGJldHRlciBvZiByZWdpc3RlcmluZyBhbiBzb2NfZGV2aWNlX2F0dHJpYnV0 ZSB1c2luZwpzb2NfZGV2aWNlX3JlZ2lzdGVyKCksIGFmdGVyIHdoaWNoIGFueSBkcml2ZXIgY2Fu IHVzZSBzb2NfZGV2aWNlX21hdGNoKCkKdG8gZGlmZmVyZW50aWF0ZSBiYXNlZCBvbiB0aGUgU29D IHJldmlzaW9uLgoKPiAoMikgSSBndWVzcyB0aGUgcmszMjg4dyB3aWxsIG5vdCBiZSB0aGUgbGFz dCBzb2MgZG9pbmcgdGhpcyBhbmQgb24gYXJtNjQgeW91Cj4gICAgIGNhbid0IGRvIGl0IHRoYXQg d2F5LCBhcyB0aGVyZSBpcyBubyBtYWNoLXJvY2tjaGlwIHRoZXJlCgpUaGVyZSdzIGRyaXZlcnMv c29jL3JvY2tjaGlwIDstKQoKPiBTbyBteSBwZXJzb25hbCBwcmVmZXJlbmNlIHdvdWxkIHJlYWxs eSB3b3VsZCBiZSBqdXN0IGEgc3BlY2lmaWMgY29tcGF0aWJsZQo+IGZvciBhZmZlY3RlZCBpcCBi bG9ja3MuCgpEb2luZyB0aGF0IG9ubHkgZm9yIGFmZmVjdGVkIElQIGJsb2NrcyBtYXkgbWlzcyBp bnRlZ3JhdGlvbiBkaWZmZXJlbmNlcy4KT2YgY291cnNlLCB5b3UgY2FuIGFsd2F5cyByZXNvcnQg dG8gc29jX2RldmljZV9tYXRjaCgpIHRvIGhhbmRsZSB0aG9zZS4uLgoKR3J7b2V0amUsZWV0aW5n fXMsCgogICAgICAgICAgICAgICAgICAgICAgICBHZWVydAoKLS0gCkdlZXJ0IFV5dHRlcmhvZXZl biAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtbTY4 ay5vcmcKCkluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmljYWwgcGVvcGxlLCBJ IGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQKd2hlbiBJJ20gdGFsa2luZyB0byBqb3VybmFsaXN0 cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlrZSB0aGF0LgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC0tIExpbnVzIFRvcnZhbGRzCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==